fix: DefaultTransportを継承するようにする

Author: nekok500

internal/client/controlserver.go

@@ -46,21 +46,8 @@ func NewControlServerClient(serverURL string, systemAdminKey string, insecureSki
 		return nil, fmt.Errorf("failed to parse server URL: %w", err)
 	}
 
-	var transport http.RoundTripper
-	if strings.ToLower(parsedURL.Scheme) == "https" {
-		// Use TLS transport for HTTPS
-		transport = &http.Transport{
-			TLSClientConfig: &tls.Config{
-				InsecureSkipVerify: insecureSkipVerify,
-			},
-		}
-	} else {
-		// Use plain HTTP transport without TLS
-		transport = &http.Transport{}
-	}
-
 	httpClient := &http.Client{
-		Transport: transport,
+		Transport: newControlServerTransport(parsedURL.Scheme, insecureSkipVerify),
 		Timeout:   30 * time.Second,
 	}
 
@@ -78,6 +65,26 @@ func NewControlServerClient(serverURL string, systemAdminKey string, insecureSki
 	}, nil
 }
 
+func newControlServerTransport(scheme string, insecureSkipVerify bool) http.RoundTripper {
+	transport, ok := http.DefaultTransport.(*http.Transport)
+	if !ok {
+		return http.DefaultTransport
+	}
+
+	clone := transport.Clone()
+	if strings.ToLower(scheme) == "https" {
+		tlsConfig := &tls.Config{
+			InsecureSkipVerify: insecureSkipVerify,
+		}
+		if clone.TLSClientConfig != nil {
+			tlsConfig = clone.TLSClientConfig.Clone()
+			tlsConfig.InsecureSkipVerify = insecureSkipVerify
+		}
+		clone.TLSClientConfig = tlsConfig
+	}
+	return clone
+}
+
 // authInterceptor adds authentication to requests
 type authInterceptor struct {
 	auth ionscaleclient.ClientAuth

internal/client/controlserver_test.go

@@ -0,0 +1,34 @@
+package client
+
+import (
+	"net/http"
+	"testing"
+)
+
+func TestNewControlServerTransportUsesDefaultIdleTimeout(t *testing.T) {
+	transport, ok := newControlServerTransport("http", false).(*http.Transport)
+	if !ok {
+		t.Fatalf("expected *http.Transport, got %T", transport)
+	}
+
+	if transport.IdleConnTimeout <= 0 {
+		t.Fatalf("expected IdleConnTimeout to be configured, got %s", transport.IdleConnTimeout)
+	}
+	if transport.MaxIdleConns <= 0 {
+		t.Fatalf("expected MaxIdleConns to be configured, got %d", transport.MaxIdleConns)
+	}
+}
+
+func TestNewControlServerTransportConfiguresTLSSkipVerify(t *testing.T) {
+	transport, ok := newControlServerTransport("https", true).(*http.Transport)
+	if !ok {
+		t.Fatalf("expected *http.Transport, got %T", transport)
+	}
+
+	if transport.TLSClientConfig == nil {
+		t.Fatal("expected TLSClientConfig to be configured")
+	}
+	if !transport.TLSClientConfig.InsecureSkipVerify {
+		t.Fatal("expected InsecureSkipVerify to be true")
+	}
+}