fix: lint

Author: MuNeNiCK

internal/controller/authkey_controller.go

@@ -58,6 +58,10 @@ const (
 	defaultAuthKeyRequeue     = 6 * time.Hour
 	dependentNotReadyRequeue  = 30 * time.Second
 	rotationRetryRequeue      = 30 * time.Second
+
+	phaseReady   = "Ready"
+	phasePending = "Pending"
+	phaseError   = "Error"
 )
 
 // AuthKeyReconciler reconciles a AuthKey object
@@ -70,6 +74,7 @@ type AuthKeyReconciler struct {
 // +kubebuilder:rbac:groups=kodiak.mnicloud.jp,resources=authkeys/status,verbs=get;update;patch
 // +kubebuilder:rbac:groups=kodiak.mnicloud.jp,resources=authkeys/finalizers,verbs=update
 
+// nolint:gocyclo // the reconciliation flow is complex and already factored into helpers where practical
 func (r *AuthKeyReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
 	logger := log.FromContext(ctx).WithValues("authkey", req.NamespacedName)
 
@@ -372,7 +377,7 @@ func (r *AuthKeyReconciler) setReadyStatus(ctx context.Context, resource *kodiak
 		Message:            message,
 	})
 	resource.Status.Ready = true
-	resource.Status.Phase = "Ready"
+	resource.Status.Phase = phaseReady
 	resource.Status.KeyID = remote.GetId()
 	resource.Status.SecretRef = &corev1.LocalObjectReference{Name: secretName}
 	resource.Status.CreatedAt = convertTimestamp(remote.GetCreatedAt())
@@ -397,7 +402,7 @@ func (r *AuthKeyReconciler) setPendingStatus(ctx context.Context, resource *kodi
 		Message:            message,
 	})
 	resource.Status.Ready = false
-	resource.Status.Phase = "Pending"
+	resource.Status.Phase = phasePending
 
 	if equality.Semantic.DeepEqual(current.Status, resource.Status) {
 		return nil
@@ -423,7 +428,7 @@ func (r *AuthKeyReconciler) setErrorStatus(ctx context.Context, resource *kodiak
 		Message:            message,
 	})
 	resource.Status.Ready = false
-	resource.Status.Phase = "Error"
+	resource.Status.Phase = phaseError
 
 	if equality.Semantic.DeepEqual(current.Status, resource.Status) {
 		return nil
@@ -468,7 +473,7 @@ func (r *AuthKeyReconciler) resetAuthKeyStatus(ctx context.Context, resource *ko
 		Message:            message,
 	})
 	resource.Status.Ready = false
-	resource.Status.Phase = "Pending"
+	resource.Status.Phase = phasePending
 	resource.Status.KeyID = 0
 	resource.Status.SecretRef = nil
 	resource.Status.CreatedAt = nil

internal/controller/connector_controller.go

@@ -65,8 +65,8 @@ const (
 	reasonTailscaleDisconnected = "TailscaleDisconnected"
 	reasonAuthKeyNotFound       = "AuthKeyNotFound"
 	reasonAuthKeyNotReady       = "AuthKeyNotReady"
-	reasonAuthKeySecretError   = "AuthKeySecretUnavailable"
-	reasonAuthKeyNotConfigured = "AuthKeyNotConfigured"
+	reasonAuthKeySecretError    = "AuthKeySecretUnavailable"
+	reasonAuthKeyNotConfigured  = "AuthKeyNotConfigured"
 )
 
 var (

internal/controller/controlserver_controller.go

@@ -44,6 +44,11 @@ import (
 	kodiakv1alpha1 "github.com/mNi-Cloud/kodiak/api/v1alpha1"
 )
 
+const (
+	schemeHTTP  = "http"
+	schemeHTTPS = "https"
+)
+
 // ControlServerReconciler reconciles a ControlServer object
 type ControlServerReconciler struct {
 	client.Client
@@ -125,7 +130,7 @@ func (r *ControlServerReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 		return ctrl.Result{RequeueAfter: 10 * time.Second}, nil
 	}
 
-	if err := r.reconcileDeployment(ctx, &resource, portCfg, configHash, adminSecret, oidcSecret); err != nil {
+	if err := r.reconcileDeployment(ctx, &resource, portCfg, configHash, adminSecret); err != nil {
 		logger.Error(err, "failed to reconcile deployment")
 		r.updateStatusWithError(ctx, &resource, "DeploymentError", err)
 		return ctrl.Result{RequeueAfter: 10 * time.Second}, nil
@@ -320,7 +325,7 @@ func (r *ControlServerReconciler) reconcileService(ctx context.Context, resource
 	return err
 }
 
-func (r *ControlServerReconciler) reconcileDeployment(ctx context.Context, resource *kodiakv1alpha1.ControlServer, ports portConfiguration, configHash string, adminSecret *corev1.Secret, oidcSecret *corev1.Secret) error {
+func (r *ControlServerReconciler) reconcileDeployment(ctx context.Context, resource *kodiakv1alpha1.ControlServer, ports portConfiguration, configHash string, adminSecret *corev1.Secret) error {
 	deploy := &appsv1.Deployment{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      deploymentName(resource),
@@ -731,9 +736,9 @@ func renderControlServerConfig(resource *kodiakv1alpha1.ControlServer, includeAd
 }
 
 func controlServerEndpoint(resource *kodiakv1alpha1.ControlServer, ports portConfiguration) string {
-	scheme := "https"
+	scheme := schemeHTTPS
 	if resource.Spec.Config.TLS != nil && resource.Spec.Config.TLS.Disable {
-		scheme = "http"
+		scheme = schemeHTTP
 	}
 
 	if resource.Spec.Config.PublicAddr != "" {
@@ -922,16 +927,16 @@ func sanitizePublicAddr(candidate string, tlsConfig *kodiakv1alpha1.TLSConfig, n
 		return fmt.Sprintf("%s:%d", host, listenPort)
 	}
 
-	scheme := "https"
+	scheme := schemeHTTPS
 	if tlsConfig != nil && tlsConfig.Disable {
-		scheme = "http"
+		scheme = schemeHTTP
 	}
 
 	addr := trimScheme(candidate)
 
 	if _, _, err := net.SplitHostPort(addr); err != nil {
 		defaultPort := 443
-		if scheme == "http" {
+		if scheme == schemeHTTP {
 			defaultPort = 80
 		}
 		addr = fmt.Sprintf("%s:%d", addr, defaultPort)