Skip to content

Incompatibility with PawnPlus, crashes from amx_GetCppString #19

@AdamsLT

Description

@AdamsLT

In reference to an issue on PawnPlus,
IS4Code/PawnPlus#38

Explanation from @IllidanS4:

str_format does not have anything to do with it; any PP string crashes when used in this code. The crash happens inside log-core, which is in turn invoked by the construction of CScopedDebugInfo in mysql_tquery. PawnPlus isn't invoked anywhere in the process.
This is an issue in samp-log-core here. It for some reason uses its own copy of the AMX functions, bypassing PP's hooking mechanism, so dynamic strings could never work with it, unless it properly sticks to the AMX API. However, that could not cause the crash on its own, because amx_GetCppString is actually wrong and assumes that amx_GetAddr never fails, which it normally does when used on a PP string.
This makes samp-log-core violate the first two points of the GCA for AMX API consumers and thus PawnPlus is not expected to work with it. I suggest you post an issue there so that it can be fixed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions