Fix ASAN errors allowing exiting a race

Author: madebr

GolDP/src/render/goldrawstate.cpp

@@ -113,7 +113,7 @@ LegoS32 GolDrawState::CreateDisplay(LegoS32 p_width, LegoS32 p_height, undefined
 // FUNCTION: GOLDP 0x1001d6d0
 void GolDrawState::Present()
 {
-	m_displaySurface->Present(NULL);
+	m_displaySurface->Present(0);
 }
 
 // FUNCTION: GOLDP 0x1001d6e0

LEGORacers/src/race/racer/carvisuals.cpp

@@ -863,7 +863,7 @@ void CarVisuals::UpdateDriver(LegoU32 p_elapsedMs)
 	}
 
 	if (m_racer->m_lapsCompleted >= g_raceLapCount) {
-		if (m_racer->m_lapTimes[5] == 1) {
+		if (m_racer->m_standingsPosition == 1) {
 			if (activePart == c_animationPart13 || activePart == c_animationPart15 || activePart == c_animationPart14) {
 				return;
 			}

LEGORacers/src/race/racestate.cpp

@@ -1093,7 +1093,7 @@ LegoU32 RaceState::GetTimeBehind(Racer* p_racer)
 		return 0;
 	}
 
-	if (p_racer->m_lapTimes[5] == 1) {
+	if (p_racer->m_standingsPosition == 1) {
 		return 0;
 	}
 
@@ -1195,7 +1195,7 @@ void RaceState::ComputeStandingsDeltas(Racer* p_racer, Racer::StandingsDeltaEntr
 				entry->m_delta = otherTime - racerTime;
 			}
 			else {
-				entry->m_delta = otherRacer->m_lapTimes[5] + 2147483641;
+				entry->m_delta = otherRacer->m_standingsPosition + 2147483641;
 			}
 
 			racerIndex++;

common/src/goldecompress.cpp

@@ -43,7 +43,8 @@ LegoU32 GolDecompress(LegoU8* p_src, LegoU8* p_dst)
 					dst++;
 				} while (count != 0);
 
-				ctrl *= 2;
+				// Overflow of a signed integer is undefined behavior, so cast to a unsigned one.
+				ctrl = static_cast<LegoS32>(2 * static_cast<LegoU32>(ctrl));
 				if (!(ctrl & 0xff)) {
 					break;
 				}

common/src/golnametable.cpp

@@ -61,9 +61,9 @@ void GolNameTable::AddName(const LegoChar* p_name, void* p_value)
 			break;
 		}
 
-		startIndex += c << shift;
+		startIndex += static_cast<LegoU32>(c) << shift;
 		shift += 7;
-		shift &= 0x1f;
+		shift %= 32;
 	}
 
 	startIndex %= m_capacity;
@@ -105,9 +105,9 @@ void* GolNameTable::GetName(const LegoChar* p_name) const
 			break;
 		}
 
-		startIndex += c << shift;
+		startIndex += static_cast<LegoU32>(c) << shift;
 		shift += 7;
-		shift &= 0x1f;
+		shift %= 32;
 	}
 
 	startIndex %= m_capacity;