cmake: small tidy

Author: madebr

CMakeLists.txt

@@ -29,7 +29,7 @@ if (NOT bits EQUAL 32)
 endif()
 
 cmake_dependent_option(RACERS_USE_DX6 "Build with internal DirectX 6 SDK" ON "CMAKE_SIZEOF_VOID_P EQUAL 4" OFF)
-if(RACERS_USE_DX6)
+if (RACERS_USE_DX6)
   include_directories("${PROJECT_SOURCE_DIR}/3rdparty/dx6/inc")
   link_directories("${PROJECT_SOURCE_DIR}/3rdparty/dx6/lib")
   foreach(name d3dim d3drm d3dxof ddraw ddraw16 dinput dplayx dsetup dsound dxguid)
@@ -47,7 +47,7 @@ if (MSVC)
 endif()
 
 function(add_cxx_warning WARNING)
-  if(RACERS_WERROR)
+  if (RACERS_WERROR)
     set(compiler_option "-Werror=${WARNING}")
   else()
     set(compiler_option "-W${WARNING}")
@@ -56,15 +56,15 @@ function(add_cxx_warning WARNING)
 
   cmake_push_check_state(RESET)
   set(CMAKE_REQUIRED_FLAGS "${compiler_option} ")
-  if(MSVC)
+  if (MSVC)
     string(APPEND CMAKE_REQUIRED_FLAGS "/WX")
   else()
     string(APPEND CMAKE_REQUIRED_FLAGS "-Werror")
   endif()
   check_cxx_source_compiles("int main() { return 0; }" ${varname})
   cmake_pop_check_state()
 
-  if(${varname})
+  if (${varname})
     add_compile_options(${compiler_option})
   endif()
 endfunction()
@@ -286,11 +286,11 @@ add_custom_target(game DEPENDS legoracers goldp)
 # --- Modern compiler compatibility ---
 if (MSVC)
   if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "15")
-    set_property(TARGET goldp legoracers common_goldp common_legoracers APPEND PROPERTY COMPILE_DEFINITIONS "_CRT_SECURE_NO_WARNINGS")
+    add_definitions(-D_CRT_SECURE_NO_WARNINGS)
   endif()
   # Visual Studio 2017 version 15.7 needs "/Zc:__cplusplus" for __cplusplus
   if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "19.14.26428")
-    set_property(TARGET goldp legoracers common_goldp common_legoracers APPEND PROPERTY COMPILE_OPTIONS "-Zc:__cplusplus")
+    add_compile_options(-Zc:__cplusplus)
   endif()
 endif()
 
@@ -318,10 +318,8 @@ if (MSVC_FOR_DECOMP)
   endif()
 
   # LegoRacers.exe links to MSVCRT.dll (/MD), GolDP.dll has embedded its runtime library (/MT)
-  set_property(TARGET legoracers PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL")
-  set_property(TARGET goldp PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
-  set_property(TARGET common_legoracers PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL")
-  set_property(TARGET common_goldp PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
+  set_property(TARGET legoracers common_legoracers PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL")
+  set_property(TARGET goldp common_goldp PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
 
   # Embed debug information (/Z7) for Debug and RelWithDebInfo configuration type
   set_property(TARGET goldp legoracers common_goldp common_legoracers PROPERTY MSVC_DEBUG_INFORMATION_FORMAT "$<$<CONFIG:Debug,RelWithDebInfo>:Embedded>")
@@ -348,16 +346,16 @@ if (MSVC_FOR_DECOMP)
 endif()
 
 find_program(CLANGFORMAT_BIN NAMES clang-format)
-if(EXISTS "${CLANGFORMAT_BIN}")
+if (EXISTS "${CLANGFORMAT_BIN}")
   execute_process(COMMAND "${CLANGFORMAT_BIN}" --version
     OUTPUT_VARIABLE "CLANGFORMAT_VERSION_OUTPUT"
     RESULT_VARIABLE "CLANGFORMAT_RESULT"
   )
-  if(CLANGFORMAT_RESULT EQUAL 0 AND CLANGFORMAT_VERSION_OUTPUT MATCHES "version ([0-9\\.]+)")
+  if (CLANGFORMAT_RESULT EQUAL 0 AND CLANGFORMAT_VERSION_OUTPUT MATCHES "version ([0-9\\.]+)")
     set(CLANGFORMAT_VERSION "${CMAKE_MATCH_1}")
     set(CLANGFORMAT_VERSION_REQUIRED "17.0")
     message(DEBUG "Found clang-format version ${CLANGFORMAT_VERSION} (needs ${CLANGFORMAT_VERSION_REQUIRED}")
-    if(CLANGFORMAT_VERSION VERSION_GREATER_EQUAL "${CLANGFORMAT_VERSION_REQUIRED}")
+    if (CLANGFORMAT_VERSION VERSION_GREATER_EQUAL "${CLANGFORMAT_VERSION_REQUIRED}")
       file(GLOB_RECURSE racers_sources
         "${PROJECT_SOURCE_DIR}/LEGORacers/*.cpp"
         "${PROJECT_SOURCE_DIR}/LEGORacers/*.h"
@@ -375,7 +373,7 @@ endif()
 
 find_library(CLANG_LIBRARY NAMES "clang" DOC "libclang from host (NOT target) system")
 find_package(Python3 COMPONENTS Interpreter QUIET)
-if(CLANG_LIBRARY AND TARGET Python3::Interpreter)
+if (CLANG_LIBRARY AND TARGET Python3::Interpreter)
   add_custom_target(ncc
     Python3::Interpreter "${PROJECT_SOURCE_DIR}/tools/ncc/ncc.py"
       --clang-lib "${CLANG_LIBRARY}"