ci: generate message in pull requests

Author: madebr

.editorconfig

@@ -12,5 +12,5 @@ tab_width = 4
 insert_final_newline = true
 trim_trailing_whitespace = true
 
-[{CMakeLists.txt,*.cmake}]
+[{CMakeLists.txt,*.cmake,*.yml}]
 indent_size = 2

.github/workflows/build.yml

@@ -121,8 +121,11 @@ jobs:
         curl -fLSs -o LEGORACERSPROGRESS-old.json $RELEASE_URL/LEGORACERSPROGRESS.json || echo "" >LEGORACERSPROGRESS-old.json
         curl -fLSs -o GOLDPPROGRESS-old.json $RELEASE_URL/GOLDPPROGRESS.json || echo "" >GOLDPPROGRESS-old.json
 
-        reccmp-reccmp --target LEGORACERS --nolib --diff LEGORACERSPROGRESS-old.json || echo "Current master not found"
-        reccmp-reccmp --target GOLDP --nolib --diff GOLDPPROGRESS-old.json || echo "Current master not found"
+        (reccmp-reccmp --target LEGORACERS --nolib --diff LEGORACERSPROGRESS-old.json || echo "Current master not found")>"LEGORACERS-diff.txt"
+        (reccmp-reccmp --target GOLDP --nolib --diff GOLDPPROGRESS-old.json || echo "Current master not found")>"GOLDP-diff.txt"
+
+        cat LEGORACERS-diff.txt
+        cat GOLDP-diff.txt
 
     - name: Check Vtables
       if: ${{ steps.detection.conclusion == 'success' && always() }}
@@ -145,6 +148,30 @@ jobs:
         python tools/check_folded.py --target LEGORACERS
         python tools/check_folded.py --target GOLDP
 
+    - name: 'Create comment on PR'
+      if: ${{ github.event_name == 'pull_request' }}
+      shell: sh
+      env:
+        GH_TOKEN: ${{ github.token }}
+      run: |
+        cat <<EOF >reccmp-pr-message.txt
+        # reccmp report
+        ## LEGORACERS (LEGORacers.exe)
+        \`\`\`
+        $(cat LEGORACERS-diff.txt | sed 's/\x1b\[[0-9;]*m//g')
+        \`\`\`
+        ## GOLDP (GolDP.dll)
+        \`\`\`
+        $(cat GOLDP-diff.txt | sed 's/\x1b\[[0-9;]*m//g')
+        \`\`\`
+        EOF
+
+        gh pr comment ${{ github.event.number }} \
+          --repo "${{ github.repository }}" \
+          --create-if-none \
+          --edit-last \
+          --body-file "reccmp-pr-message.txt"
+
     - name: Upload Artifact
       uses: actions/upload-artifact@main
       with:

GolDP/src/scene/golbillboardex.cpp

@@ -23,12 +23,12 @@ extern const LegoFloat g_unk0x1005675c = 1.0f;
 GolBillboardInitializerFunction g_unk0x1005c010 = &GolBillboard::FUN_10014e20;
 #pragma data_seg()
 
-// STUB: GOLDP 0x10014e20
+// FUNCTION: GOLDP 0x10014e20
 void GolBillboard::FUN_10014e20()
 {
-	g_billboardTexCoords[2].m_y = 0.0f;
 	g_billboardTexCoords[1].m_y = g_unk0x1005675c;
 	g_billboardTexCoords[2].m_x = g_unk0x1005675c;
+	g_billboardTexCoords[2].m_y = 0.0f;
 	g_billboardTexCoords[3].m_x = g_unk0x1005675c;
 	g_billboardTexCoords[3].m_y = g_unk0x1005675c;
 }
@@ -49,22 +49,20 @@ LegoBool32 GolBillboard::FUN_10014e50(const GolVec3* p_arg1, const GolVec3* p_ar
 
 	if (m_flags & c_flagBit1) {
 		row2 = &m_unk0x30;
-		LegoFloat dot = row2->m_z * row0.m_z;
-		dot += row0.m_y * row2->m_y;
-		dot += row0.m_x * row2->m_x;
-		row0.m_x -= dot * row2->m_x;
-		row0.m_y -= row2->m_y * dot;
-		row0.m_z -= row2->m_z * dot;
+		LegoFloat dot = row0.m_x * row2->m_x + row0.m_y * row2->m_y + row2->m_z * row0.m_z;
+		row0.m_x -= dot * m_unk0x30.m_x;
+		row0.m_y -= dot * m_unk0x30.m_y;
+		row0.m_z -= dot * m_unk0x30.m_z;
 	}
 	else {
 		row2 = p_arg2;
 	}
 
 	GolMath::NormalizeVector3(row0, &row0);
 
-	row1.m_x = row0.m_z * row2->m_y - row2->m_z * row0.m_y;
-	row1.m_y = row2->m_z * row0.m_x - row0.m_z * row2->m_x;
-	row1.m_z = row0.m_y * row2->m_x - row2->m_y * row0.m_x;
+	row1.m_x = row2->m_y * row0.m_z - row2->m_z * row0.m_y;
+	row1.m_y = row2->m_z * row0.m_x - row2->m_x * row0.m_z;
+	row1.m_z = row2->m_x * row0.m_y - row2->m_y * row0.m_x;
 
 	p_matrix->m_m[0][0] = row0.m_x;
 	p_matrix->m_m[0][1] = row0.m_y;
@@ -81,8 +79,8 @@ LegoBool32 GolBillboard::FUN_10014e50(const GolVec3* p_arg1, const GolVec3* p_ar
 	p_matrix->m_m[2][2] = row2->m_z;
 	p_matrix->m_m[2][3] = 0.0f;
 
-	LegoFloat halfWidth = m_width * 0.5f;
-	LegoFloat halfHeight = m_height * 0.5f;
+	LegoFloat halfWidth = m_width / 2.0f;
+	LegoFloat halfHeight = m_height / 2.0f;
 	p_matrix->m_m[3][0] = position.m_x - halfWidth * row1.m_x - halfHeight * row2->m_x;
 	p_matrix->m_m[3][1] = position.m_y - halfWidth * row1.m_y - halfHeight * row2->m_y;
 	p_matrix->m_m[3][2] = position.m_z - halfWidth * row1.m_z - halfHeight * row2->m_z;

LEGORacers/include/menu/widgets/menuwidget.h

@@ -73,8 +73,8 @@ class MenuWidget {
 	Rect* GetGlobalRect();
 	Rect* GetRect() { return &m_unk0x34; }
 	LegoBool32 ClipRect(Rect*, Rect*);
-	Rect* FUN_00472c80(Rect*, Rect*);
-	Rect* MeasureText(GolFontBase*, GolString*, Rect*, Rect*, LegoS32);
+	void FUN_00472c80(const Rect*, Rect*) const;
+	void MeasureText(GolFontBase*, GolString*, Rect*, Rect*, LegoS32);
 	void DrawImage(Rect*, Rect*, UtopianPan0xa4*);
 	void DrawString(Rect*, Rect*, GolFontBase*, GolString*, LegoS32, LegoS32);
 	Rect* TranslateRectByOffset(Rect*);

LEGORacers/src/menu/widgets/menuwidget.cpp

@@ -211,9 +211,9 @@ undefined4 MenuWidget::HitTest(LegoS32 p_x, LegoS32 p_y)
 }
 
 // STUB: LEGORACERS 0x00472c80
-Rect* MenuWidget::FUN_00472c80(Rect* p_source, Rect* p_dest)
+void MenuWidget::FUN_00472c80(const Rect* p_source, Rect* p_dest) const
 {
-	Rect* source = p_source;
+	const Rect* source = p_source;
 	LegoU32 sourceTop = source->m_top;
 	LegoU32 sourceHeight = source->m_bottom;
 	LegoS32 sourceLeft = source->m_left;
@@ -248,12 +248,10 @@ Rect* MenuWidget::FUN_00472c80(Rect* p_source, Rect* p_dest)
 		dest->m_top = source->m_top;
 		dest->m_bottom = source->m_bottom;
 	}
-
-	return dest;
 }
 
 // FUNCTION: LEGORACERS 0x00472d00
-Rect* MenuWidget::MeasureText(
+void MenuWidget::MeasureText(
 	GolFontBase* p_font,
 	GolString* p_string,
 	Rect* p_source,
@@ -275,7 +273,7 @@ Rect* MenuWidget::MeasureText(
 	p_dest->m_top = 0;
 	p_dest->m_right = width;
 	p_dest->m_bottom = height;
-	return FUN_00472c80(p_source, p_dest);
+	FUN_00472c80(p_source, p_dest);
 }
 
 // FUNCTION: LEGORACERS 0x00472d70

common/include/golfontbase.h

@@ -57,7 +57,7 @@ class GolFontBase {
 	LegoBool32 ComputeClipRect(GolRenderDevice*, Rect*, Rect*);
 	void ClipRects(Rect*, Rect*, Rect*, LegoFloat, LegoFloat);
 	static LegoS32 __cdecl CompareGlyphChars(const void* p_left, const void* p_right);
-	void MeasureString(GolString* p_string, LegoS32* p_width, LegoS32* p_height);
+	void MeasureString(GolString* p_string, LegoS32* p_width, LegoS32* p_height) const;
 	void MeasureString(const LegoChar* p_string, LegoS32* p_width, LegoS32* p_height);
 	void FUN_00408d50(
 		GolString* p_string,
@@ -81,7 +81,7 @@ class GolFontBase {
 		ColorRGBA* p_color,
 		LegoS32 p_unk0x2c
 	);
-	LegoU32 FindGlyphIndex(LegoU16 p_char);
+	LegoU32 FindGlyphIndex(LegoU16 p_char) const;
 
 	LegoBool32 HasLoadedData() const { return m_glyphs != NULL; }
 	void SetColor(LegoU8 p_red, LegoU8 p_green, LegoU8 p_blue, LegoU8 p_alpha)

common/src/golfontbase.cpp

@@ -458,9 +458,9 @@ void GolFontBase::CopyGlyphsToTextures()
 
 // FUNCTION: GOLDP 0x1001e970
 // FUNCTION: LEGORACERS 0x00408be0
-void GolFontBase::MeasureString(GolString* p_string, LegoS32* p_width, LegoS32* p_height)
+void GolFontBase::MeasureString(GolString* p_string, LegoS32* p_width, LegoS32* p_height) const
 {
-	GolFontBase* font = this;
+	const GolFontBase* font = this;
 
 	if (p_string == NULL) {
 		if (p_width != NULL) {
@@ -824,7 +824,7 @@ void GolFontBase::FUN_00408fe0(
 }
 
 // FUNCTION: LEGORACERS 0x004092b0
-LegoU32 GolFontBase::FindGlyphIndex(LegoU16 p_char)
+LegoU32 GolFontBase::FindGlyphIndex(LegoU16 p_char) const
 {
 	LegoS32 low = 0;
 	LegoS32 high = m_glyphCount - 1;