Skip to content

Commit ebe4f1c

Browse files
committed
Fix SDD / style
1 parent 832fb05 commit ebe4f1c

7 files changed

Lines changed: 44 additions & 48 deletions

File tree

GolDP/src/fluffygloomkins0x118.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ undefined4* FluffyGloomkins0x118::VTable0x08()
145145

146146
if (GetUnk0x1c() != 0) {
147147
m_unk0x10c = new CmbModelPart0x34[GetUnk0x1c()];
148-
if (m_unk0xf4 == NULL) {
148+
if (m_unk0x10c == NULL) {
149149
GOL_FATALERROR(c_golErrorOutOfMemory);
150150
}
151151
}

LEGORacers/include/aquamarinespirit0x3c.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#ifndef AQUAMARINESPIRIT0X3C_H
22
#define AQUAMARINESPIRIT0X3C_H
33

4-
#include "../../common/include/cmbmodelpart0x34.h"
4+
#include "cmbmodelpart0x34.h"
55
#include "decomp.h"
66
#include "golnametable.h"
77
#include "goltxtparser.h"

common/include/cmbmodelpart0x34.h

Lines changed: 24 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -8,38 +8,35 @@
88
#include "types.h"
99

1010
class GolFileParser;
11-
12-
class CmbModelPartData0x14;
1311
class CmbModelPartData0x28;
1412

15-
// VTABLE: GOLDP 0x10056a68
16-
// VTABLE: LEGORACERS 0x004af23c
17-
// SIZE 0x1fc
18-
class AdbTxtParser : public GolTxtParser {
19-
20-
// SYNTHETIC: GOLDP 0x10030050 FOLDED
21-
// SYNTHETIC: LEGORACERS 0x0041e920 FOLDED
22-
// AdbTxtParser::`scalar deleting destructor'
23-
24-
// SYNTHETIC: GOLDP 0x1001b000 FOLDED
25-
// SYNTHETIC: LEGORACERS 0x0041e93b FOLDED
26-
// AdbTxtParser::~AdbTxtParser
27-
};
28-
29-
// SIZE 0x14
30-
struct CmbModelPartData0x14 {
31-
LegoU32 m_unk0x00;
32-
LegoU32 m_unk0x04;
33-
LegoU32 m_unk0x08;
34-
LegoU32 m_unk0x0c;
35-
LegoU16 m_unk0x10;
36-
LegoU16 m_unk0x12;
37-
};
38-
3913
// VTABLE: GOLDP 0x10056a50
4014
// VTABLE: LEGORACERS 0x004af224
4115
// SIZE 0x34
4216
class CmbModelPart0x34 : public GolNameTable {
17+
// VTABLE: GOLDP 0x10056a68
18+
// VTABLE: LEGORACERS 0x004af23c
19+
// SIZE 0x1fc
20+
class AdbTxtParser : public GolTxtParser {
21+
// SYNTHETIC: GOLDP 0x10030050 FOLDED
22+
// SYNTHETIC: LEGORACERS 0x0041e920 FOLDED
23+
// CmbModelPart0x34::AdbTxtParser::`scalar deleting destructor'
24+
25+
// SYNTHETIC: GOLDP 0x1001b000 FOLDED
26+
// SYNTHETIC: LEGORACERS 0x00498840 FOLDED
27+
// CmbModelPart0x34::AdbTxtParser::~AdbTxtParser
28+
};
29+
30+
// SIZE 0x14
31+
struct Data0x14 {
32+
LegoU32 m_unk0x00; // 0x00
33+
LegoU32 m_unk0x04; // 0x04
34+
LegoU32 m_unk0x08; // 0x08
35+
LegoU32 m_unk0x0c; // 0x0c
36+
LegoU16 m_unk0x10; // 0x10
37+
LegoU16 m_unk0x12; // 0x12
38+
};
39+
4340
public:
4441
CmbModelPart0x34();
4542
~CmbModelPart0x34() override; // vtable+0x00
@@ -54,7 +51,7 @@ class CmbModelPart0x34 : public GolNameTable {
5451

5552
private:
5653
CmbModelPartData0x18 m_data; // 0x0c
57-
CmbModelPartData0x14* m_unk0x24; // 0x24
54+
Data0x14* m_unk0x24; // 0x24
5855
LegoU32 m_unk0x28; // 0x28
5956
CmbModelPartData0x28* m_unk0x2c; // 0x2c
6057
LegoU32 m_unk0x30; // 0x30

common/include/cmbmodelpartdata0x28.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ class CmbModelPartData0x28 {
1414
void FUN_10018670(GolFileParser& p_parser);
1515

1616
private:
17-
LegoFloat m_unk0x00; // 0x00
18-
GolVec3 m_unk0x04; // 0x04
19-
GolVec4 m_unk0x10; /* or GolQuat */ // 0x10
20-
LegoU32 m_unk0x20; // 0x20
21-
LegoU16 m_unk0x24; // 0x24
22-
LegoU16 m_unk0x26; // 0x26
17+
LegoFloat m_unk0x00; // 0x00
18+
GolVec3 m_unk0x04; // 0x04
19+
GolVec4 m_unk0x10; // 0x10
20+
LegoU32 m_unk0x20; // 0x20
21+
LegoU16 m_unk0x24; // 0x24
22+
LegoU16 m_unk0x26; // 0x26
2323
};
2424

2525
#endif // CMBMODELPARTDATA0X28_H

common/src/cmbmodelpart0x34.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
#include "../include/cmbmodelpart0x34.h"
1+
#include "cmbmodelpart0x34.h"
22

3-
#include "../include/cmbmodelpartdata0x28.h"
4-
#include "../include/golbinparser.h"
5-
#include "../include/golerror.h"
3+
#include "cmbmodelpartdata0x28.h"
4+
#include "golbinparser.h"
5+
#include "golerror.h"
66

77
DECOMP_SIZE_ASSERT(CmbModelPart0x34, 0x34)
88

@@ -97,7 +97,7 @@ void CmbModelPart0x34::VTable0x0c(GolFileParser& p_parser)
9797
if (m_unk0x28 == 0) {
9898
p_parser.HandleUnexpectedToken(GolFileParser::e_int);
9999
}
100-
m_unk0x24 = new CmbModelPartData0x14[m_unk0x28];
100+
m_unk0x24 = new Data0x14[m_unk0x28];
101101
if (m_unk0x24 == NULL) {
102102
GOL_FATALERROR(c_golErrorOutOfMemory);
103103
}

common/src/cmbmodelpartdata0x18.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
#include "../include/cmbmodelpartdata0x18.h"
1+
#include "cmbmodelpartdata0x18.h"
22

3-
#include "../include/golerror.h"
4-
#include "../include/golfileparser.h"
3+
#include "golerror.h"
4+
#include "golfileparser.h"
55

66
DECOMP_SIZE_ASSERT(CmbModelPartData0x18, 0x18)
77

common/src/cmbmodelpartdata0x28.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
#include "../include/cmbmodelpartdata0x28.h"
1+
#include "cmbmodelpartdata0x28.h"
2+
3+
#include "golfileparser.h"
24

3-
#include <../include/golfileparser.h>
45
#include <float.h>
56

6-
DECOMP_SIZE_ASSERT(CmbModelPartData0x28, 0x28);
7+
DECOMP_SIZE_ASSERT(CmbModelPartData0x28, 0x28)
78

89
// FUNCTION: GOLDP 0x10018640
910
// FUNCTION: LEGORACERS 0x00401000
1011
CmbModelPartData0x28::CmbModelPartData0x28()
1112
{
12-
1313
m_unk0x24 = 0;
1414
m_unk0x26 = 0;
1515
m_unk0x20 = 0;
@@ -49,7 +49,6 @@ void CmbModelPartData0x28::FUN_10018670(GolFileParser& p_parser)
4949
break;
5050
case GolFileParser::e_unknown0x2f:
5151
m_unk0x00 = static_cast<LegoFloat>(p_parser.ReadInteger()) / 1000.0f;
52-
;
5352
break;
5453
case GolFileParser::e_unknown0x30:
5554
m_unk0x04.m_x = p_parser.ReadFloat();

0 commit comments

Comments
 (0)