Skip to content

Commit ddf9617

Browse files
authored
Merge pull request #4 from maggiezha/k8s-autoscaling
K8s autoscaling
2 parents 1daf081 + c136c37 commit ddf9617

4,119 files changed

Lines changed: 805779 additions & 173001 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.agents/catalog-skills.yaml

Lines changed: 0 additions & 40 deletions
This file was deleted.
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. -->
2+
<!-- SPDX-License-Identifier: Apache-2.0 -->
3+
4+
# Stop for Git and GitHub Access Errors
5+
6+
Use this rule in each workflow that runs `git`, `ssh`, or `gh` commands.
7+
8+
Stop if a Git or GitHub command has an access error. Access errors include authentication, authorization, credentials, SSO, token scope, SSH keys, remote access, and push permissions.
9+
Ask the user to correct the access problem.
10+
11+
Do not try to bypass an access error. Do not:
12+
13+
- switch remote protocols or remotes
14+
- edit credentials, tokens, or SSH config
15+
- generate new tokens or SSH keys
16+
- rewrite remotes to bypass permissions
17+
- force-push or bypass branch protections or required checks.
18+
19+
Report the command and the error. Tell the user which action is necessary. Then, wait.
20+
21+
This rule applies only to access errors.
22+
Handle merge conflicts, stale branches, dirty worktrees, and rebase conflicts in the related workflow.
23+
Ask the user when a resolution can change behavior, contributor intent, or a design decision.
Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. -->
2+
<!-- SPDX-License-Identifier: Apache-2.0 -->
3+
4+
# Follow Up on PR CI and Reviews
5+
6+
Use this workflow after you create a PR or push to an open PR.
7+
8+
## Monitor checks
9+
10+
```bash
11+
PR_NUMBER=${PR_NUMBER:-$(gh pr view --json number -q .number)}
12+
gh pr checks "$PR_NUMBER" --watch
13+
```
14+
15+
When the checks stop, inspect their status:
16+
17+
```bash
18+
gh pr view "$PR_NUMBER" --json url,statusCheckRollup,comments,reviews,reviewDecision
19+
```
20+
21+
## Review feedback
22+
23+
Check PR comments and inline review comments from CodeRabbit and the PR Review Advisor:
24+
25+
```bash
26+
gh api "repos/NVIDIA/NemoClaw/issues/${PR_NUMBER}/comments" --paginate \
27+
--jq '.[] | select((.body // "") | test("CodeRabbit|coderabbit|PR Review Advisor|nemoclaw-pr-review-advisor"; "i")) | {author: .user.login, updated_at, body}'
28+
29+
gh api "repos/NVIDIA/NemoClaw/pulls/${PR_NUMBER}/comments" --paginate \
30+
--jq '.[] | select((.body // "") | test("CodeRabbit|coderabbit|PR Review Advisor|nemoclaw-pr-review-advisor"; "i")) | {author: .user.login, path, line, updated_at, body}'
31+
```
32+
33+
## Handle results
34+
35+
- Follow the [NemoClaw Writing Guide](../../../WRITING.md) for review comments and proposed rewrites.
36+
- The guide defines which language findings can block and how to write a suggestion.
37+
- Before you act on feedback, state the problem and the intended result.
38+
- Do not add a helper, configuration switch, fallback, migration, or compatibility path only to satisfy reviewer wording.
39+
- Treat feedback as a suggestion if you cannot connect it to one of these conditions:
40+
- A defect.
41+
- A demonstrated security or data-safety risk.
42+
- A supported contract.
43+
- Unnecessary complexity in changed code.
44+
- Ambiguity in changed text that can change behavior, security, data safety, test meaning, or release meaning.
45+
- **CI failure:** Inspect the job logs and fix the cause. Run the related local checks. Commit, push, and monitor the PR again.
46+
- **Valid CodeRabbit or PR Review Advisor finding:** Fix correctness, security, or test-coverage problems. Run the related checks. Commit, push, and monitor the PR again.
47+
- **Style comment or false positive:** Avoid unnecessary changes. Explain your decision in the final report. Comment on the PR when reviewers need the explanation.
48+
- **Ambiguous, risky, broad, or design-changing feedback:** Stop and ask the user before you change code.
49+
50+
Repeat this workflow until required CI passes and no actionable automated-review findings remain. Stop if the user tells you to stop.
51+
52+
If a push or GitHub query has an access error, follow [Git and GitHub Access Hard Stop](git-github-hard-stop.md).
53+
Resolve merge conflicts and dirty-worktree problems in the PR workflow.
54+
Ask the user when a resolution can change behavior or contributor intent.

0 commit comments

Comments
 (0)