forge--topic-parse-config-buffer: New function

Replacing `forge--topic-parse-config-buffer'
and `forge--topic-parse-yaml-links'.

Author: tarsius

lisp/forge-topic.el

@@ -1894,23 +1894,16 @@ When point is on the answer, then unmark it and mark no other."
     `((title . ,(string-trim title))
       (body  . ,(string-trim body)))))
 
-(defun forge--topic-parse-link-buffer ()
-  (save-match-data
-    (save-excursion
-      (goto-char (point-min))
-      (mapcar (lambda (alist)
-                (cons (cons 'prompt (concat (alist-get 'name alist) " -- "
-                                            (alist-get 'about alist)))
-                      alist))
-              (forge--topic-parse-yaml-links)))))
-
-(defun forge--topic-parse-yaml-links ()
-  (alist-get 'contact_links
-             (yaml-parse-string (buffer-substring-no-properties
-                                 (point-min)
-                                 (point-max))
-                                :object-type 'alist
-                                :sequence-type 'list)))
+(defun forge--topic-parse-config-buffer ()
+  (let-alist (save-match-data
+               (yaml-parse-string
+                (buffer-substring-no-properties (point-min) (point-max))
+                :object-type 'alist
+                :sequence-type 'list))
+    (mapcar (lambda (link)
+              `(,@link
+                (prompt ,(let-alist link (concat .name " -- " .about)))))
+            .contact_links)))
 
 (cl-defgeneric forge--topic-template-files (repo class)
   "Return a list of topic template files for REPO and a topic of CLASS.")
@@ -1927,7 +1920,7 @@ alist, containing just `text' and `position'.")
               (with-temp-buffer
                 (magit-git-insert "cat-file" "-p" (concat branch ":" f))
                 (if (equal (file-name-nondirectory f) "config.yml")
-                    (forge--topic-parse-link-buffer)
+                    (forge--topic-parse-config-buffer)
                   (list (forge--topic-parse-buffer f)))))
             (forge--topic-template-files repo class))))