forge--completing-read: Remove function

`magit-completing-read' now supports "" as a member of COLLECTION
even when REQUIRE-MATCH is non-nil.

Author: tarsius

lisp/forge-topic.el

@@ -713,9 +713,11 @@ can be selected from the start."
   (read-string "Title: " (oref topic title)))
 
 (defun forge-read-topic-milestone (&optional topic)
-  (forge--completing-read
+  (magit-completing-read
    "Milestone"
-   (mapcar #'caddr (oref (forge-get-repository (or topic :tracked)) milestones))
+   (cons ""
+         (mapcar #'caddr
+                 (oref (forge-get-repository (or topic :tracked)) milestones)))
    nil t
    (and topic (forge--format-topic-milestone topic))))
 
@@ -758,24 +760,6 @@ can be selected from the start."
      'confirm
      (mapconcat #'cadr value ","))))
 
-(defun forge--completing-read ( prompt collection &optional
-                                predicate require-match initial-input
-                                hist def)
-  ;; NOTE Only required until `magit-completing-read' has been
-  ;; updated to allow empty input if require-match is t.
-  (let ((reply (funcall magit-completing-read-function
-                        (concat prompt ": ")
-                        (if (and def (not (member def collection)))
-                            (cons def collection)
-                          collection)
-                        predicate
-                        require-match initial-input hist def)))
-    (if (equal reply "")
-        (if (and require-match (not (eq require-match t)))
-            (user-error "Nothing selected")
-          nil)
-      reply)))
-
 ;;; Format
 
 (cl-defmethod forge--format ((topic forge-topic) slot &optional spec)