Fix split maxsplit zero handling

Author: CodingFeng101

boltons/iterutils.py

@@ -158,7 +158,7 @@ def split_iter(src, sep=None, maxsplit=None):
     if maxsplit is not None:
         maxsplit = int(maxsplit)
         if maxsplit == 0:
-            yield [src]
+            yield list(src)
             return
 
     if callable(sep):

tests/test_iterutils.py

@@ -4,6 +4,7 @@
 
 from boltons.dictutils import OMD
 from boltons.iterutils import (first,
+                               split,
                                pairwise,
                                pairwise_iter,
                                windowed,
@@ -24,6 +25,14 @@
 is_meaning_of_life = lambda x: x == 42
 
 
+class TestSplit:
+    def test_maxsplit_zero_returns_unsplit_values(self):
+        values = [1, None, 2]
+
+        assert split(values, maxsplit=0) == [values]
+        assert split(iter(values), maxsplit=0) == [values]
+
+
 class TestFirst:
     def test_empty_iterables(self):
         """
@@ -634,4 +643,3 @@ def test_partition_multiple():
     assert positive == [2, 3]
     assert negative == [-1, -2]
     assert zero == [0]
-