Merge pull request #445 from mainmatter/drop-old-node

Drop support for Node < 22

Author: mansona

.eslintrc.js

@@ -5,13 +5,11 @@ module.exports = {
   parserOptions: {
     ecmaVersion: '2019',
   },
-  plugins: ['eslint-plugin', 'filenames', 'import', 'jest', 'node', 'prettier'],
+  plugins: ['eslint-plugin', 'filenames', 'import', 'node', 'prettier'],
   extends: [
     'eslint:recommended',
     'plugin:eslint-comments/recommended',
     'plugin:eslint-plugin/all',
-    'plugin:jest/recommended',
-    'plugin:jest/style',
     'plugin:import/errors',
     'plugin:import/warnings',
     'plugin:node/recommended',
@@ -26,8 +24,15 @@ module.exports = {
   overrides: [
     {
       // Test files:
-      files: ['tests/**/*.js'],
-      env: { jest: true },
+      files: ['**/*.test.js'],
+      parserOptions: {
+        ecmaVersion: '2019',
+        sourceType: 'module',
+      },
+      rules: {
+        'node/no-unsupported-features/es-syntax': 'off',
+        'import/named': 'off',
+      },
     },
   ],
 };

.github/workflows/ci.yml

@@ -4,57 +4,51 @@ on:
   push:
     branches:
       - main
-      - "v*"
-  pull_request:
+      - master
+  pull_request: {}
 
-env:
-  FORCE_COLOR: 1
-  PNPM_VERSION: 6.15.0
+concurrency:
+  group: ci-${{ github.head_ref || github.ref }}
+  cancel-in-progress: true
 
 jobs:
   lint:
     name: Linting
     runs-on: ubuntu-latest
+    timeout-minutes: 5
 
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
-
-      - uses: pnpm/action-setup@v2.4.1
-        with:
-          version: ${{ env.PNPM_VERSION }}
-
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v7
+      - uses: pnpm/action-setup@v6
+      - uses: actions/setup-node@v6
         with:
-          node-version: 14.x
+          node-version: 22.x
           cache: 'pnpm'
-
       - run: pnpm install
       - run: pnpm lint
 
   test-node:
+    timeout-minutes: 5
     strategy:
+      fail-fast: false
       matrix:
-        node-version: [12.x, 14.x, 16.x]
+        node-version: [22.x, 24.x, 26.x]
 
     name: Tests (Node.js ${{ matrix.node-version }})
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
-
-      - uses: pnpm/action-setup@v2.4.1
-        with:
-          version: ${{ env.PNPM_VERSION }}
-
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v7
+      - uses: pnpm/action-setup@v6
+      - uses: actions/setup-node@v6
         with:
           node-version: ${{ matrix.node-version }}
           cache: 'pnpm'
-
       - run: pnpm install
       - run: pnpm test -- --coverage
 
   test-eslint:
+    timeout-minutes: 5
     strategy:
       matrix:
         eslint-version: [7.0.0]
@@ -63,19 +57,12 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
-
-      - uses: pnpm/action-setup@v2.4.1
+      - uses: actions/checkout@v7
+      - uses: pnpm/action-setup@v6
+      - uses: actions/setup-node@v6
         with:
-          version: ${{ env.PNPM_VERSION }}
-
-      - uses: actions/setup-node@v3
-        with:
-          node-version: 14.x
-          # cache disabled because the extra `pnpm add` might conflict with the
-          # `test-node` job cache, and there is currently no way to influence
-          # the cache key
-          # cache: 'pnpm'
+          node-version: 22.x
+          cache: 'pnpm'
 
       - run: pnpm install
       - run: pnpm add --save-dev eslint@${{ matrix.eslint-version }}

.github/workflows/release.yml

@@ -11,10 +11,10 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v7
+      - uses: actions/setup-node@v6
         with:
-          node-version: 12.x
+          node-version: 22.x
           registry-url: 'https://registry.npmjs.org'
 
       - run: npm publish

configs.test.js

@@ -1,19 +1,23 @@
+import { describe, it, expect } from 'vitest';
+
+import { configs } from './index.js';
+
 describe('configs', () => {
   it('recommended is stable', () => {
     // if you change the list of recommended rules, make sure to release this
     // as a breaking change!!
 
-    expect(require('./index').configs.recommended).toMatchInlineSnapshot(`
-Object {
-  "plugins": Array [
-    "qunit-dom",
-  ],
-  "rules": Object {
-    "qunit-dom/no-checked-selector": "error",
-    "qunit-dom/no-ok-find": "error",
-    "qunit-dom/require-assertion": "error",
-  },
-}
-`);
+    expect(configs.recommended).toMatchInlineSnapshot(`
+      {
+        "plugins": [
+          "qunit-dom",
+        ],
+        "rules": {
+          "qunit-dom/no-checked-selector": "error",
+          "qunit-dom/no-ok-find": "error",
+          "qunit-dom/require-assertion": "error",
+        },
+      }
+    `);
   });
 });

package.json

@@ -5,11 +5,11 @@
   "main": "index.js",
   "repository": "https://github.com/Mainmatter/eslint-plugin-qunit-dom/",
   "scripts": {
-    "lint": "npm-run-all \"lint:*\"",
+    "lint": "pnpm run \"/^lint:.*/\"",
     "lint:js": "eslint .",
     "lint:readme": "eslint-doc-generator --check",
     "release": "release-it",
-    "test": "jest",
+    "test": "vitest",
     "update-readme": "eslint-doc-generator"
   },
   "devDependencies": {
@@ -20,20 +20,19 @@
     "eslint-plugin-eslint-plugin": "6.5.0",
     "eslint-plugin-filenames": "1.3.2",
     "eslint-plugin-import": "2.32.0",
-    "eslint-plugin-jest": "27.9.0",
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-prettier": "5.5.6",
-    "jest": "28.1.3",
-    "npm-run-all": "4.1.5",
     "prettier": "3.8.4",
     "release-it": "15.11.0",
-    "release-it-lerna-changelog": "5.0.0"
+    "release-it-lerna-changelog": "5.0.0",
+    "vitest": "^4.1.9"
   },
   "peerDependencies": {
     "eslint": "^7.11.0 || ^8.0.0"
   },
+  "packageManager": "pnpm@11.9.0",
   "engines": {
-    "node": "12.* || 14.* || >= 16.*"
+    "node": "22.* || >= 24.*"
   },
   "changelog": {
     "repo": "Mainmatter/eslint-plugin-qunit-dom"