Skip to content

Commit fc63d23

Browse files
Merge pull request #2185 from mainmatter/expose-installed-types
chore(qunit-dom): expose private install types
2 parents 2bd8a49 + 63bce31 commit fc63d23

2 files changed

Lines changed: 14 additions & 12 deletions

File tree

packages/qunit-dom/lib/install.ts

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,23 @@ import DOMAssertions from './assertions.js';
22
import { getRootElement } from './root-element.js';
33
import type { IDOMElementDescriptor } from 'dom-element-descriptors';
44

5-
declare global {
6-
type RootElement = Element | Document | ShadowRoot | null;
5+
type TRoot = Element | Document | ShadowRoot | null;
76

8-
interface Assert {
9-
dom(
10-
target?: string | Element | IDOMElementDescriptor | null,
11-
rootElement?: RootElement
12-
): DOMAssertions;
13-
}
7+
interface IAssert {
8+
dom(target?: DOMTarget, rootElement?: RootElement): DOMAssertions;
9+
}
10+
11+
export type RootElement = TRoot;
12+
export type Assert = IAssert;
13+
export type DOMTarget = string | Element | IDOMElementDescriptor | null;
14+
15+
declare global {
16+
type RootElement = TRoot;
17+
interface Assert extends IAssert {}
1418
}
1519

1620
export default function (assert: Assert) {
17-
assert.dom = function (
18-
target?: string | Element | IDOMElementDescriptor | null,
19-
rootElement?: RootElement
20-
): DOMAssertions {
21+
assert.dom = function (target?: DOMTarget, rootElement?: RootElement): DOMAssertions {
2122
if (!isValidRootElement(rootElement)) {
2223
throw new Error(`${rootElement} is not a valid root element`);
2324
}

packages/qunit-dom/lib/qunit-dom.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,6 @@
22
import install from './install.js';
33

44
export { setup } from './qunit-dom-modules.js';
5+
export type { RootElement, Assert, DOMTarget } from './install.js';
56

67
install(QUnit.assert);

0 commit comments

Comments
 (0)