Skip to content

Commit 79376c8

Browse files
jackwangfengclaude
andcommitted
pgvector: fix hnsw_*_support blank-line formatting, update harness README
The halfvec/sparsevec merge left hnsw_halfvec_support and hnsw_sparsevec_support's CREATE FUNCTION statements adjacent with no blank line between them; upstream separates every statement in that block by a blank line (hnsw_bit_support sits between them there but is unported, so this tree's block is just the two). A whole-file diff against upstream sql/vector.sql (excluding the unported bit/ivfflat material) is now byte-identical. Update test/README.md now that the halfvec<->sparsevec casts land: an argument-less pgvector-regress.sh run passes all nine selected tests on this tree. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
1 parent 945c60c commit 79376c8

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

crates/contrib/pgvector/extension/vector--0.8.5.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,7 @@ COMMENT ON ACCESS METHOD hnsw IS 'hnsw index access method';
258258

259259
CREATE FUNCTION hnsw_halfvec_support(internal) RETURNS internal
260260
AS 'MODULE_PATHNAME' LANGUAGE C;
261+
261262
CREATE FUNCTION hnsw_sparsevec_support(internal) RETURNS internal
262263
AS 'MODULE_PATHNAME' LANGUAGE C;
263264

crates/contrib/pgvector/test/README.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,13 @@ stripped, cwd = the upstream `test/` directory).
1212
`bit`, `hnsw_bit` and `ivfflat_*` are skipped: pgrust does not ship those
1313
opclasses / that access method. With no arguments the script otherwise runs
1414
every test under upstream's `test/sql/`, whether or not this port has caught
15-
up to it. On the current tree that means `vector_type`, `hnsw_vector`,
16-
`halfvec`, `hnsw_halfvec`, `sparsevec` and `hnsw_sparsevec` all pass, and so do
17-
`btree`, `cast` and `copy` once the halfvec<->sparsevec casts are present (they
18-
exercise both types together). A full, argument-less run is expected to exit
19-
zero on a tree that carries both types; pass explicit test names (as above) to
20-
check a subset.
15+
up to it. On the current tree (which carries the vector, halfvec and
16+
sparsevec types, HNSW for all three, and the halfvec<->sparsevec casts) an
17+
argument-less run passes all nine selected tests: `vector_type`,
18+
`hnsw_vector`, `halfvec`, `hnsw_halfvec`, `sparsevec`, `hnsw_sparsevec`,
19+
`btree`, `cast` and `copy` (the last three exercise both halfvec and
20+
sparsevec together, including the cast pair). Pass explicit test names (as
21+
above) to check a subset.
2122

2223
On FAIL the script leaves that test's diff (and upstream's raw output) in a
2324
`mktemp -d` directory, printed in the failure line, for inspection.

0 commit comments

Comments
 (0)