Skip to content

Commit 0034dde

Browse files
mamehazemamehaze
authored
nes_vt: added 2 not working Go Retro sets + cleanups + lxcap research (#15228)
New clones marked not working ----------------------------- Go Retro Portable 250+ Games (US, V1.3) [Sean Riddle, David Haywood] Go Retro Portable 250+ Games (US, V1.2) [Sean Riddle, David Haywood] these licensed devices are protected like the other 2 sets (~0x100 bytes of code read from mystery device) * simulated protection for lxcap, tetrtin, pactin rather than bypassing it * also hooked up lxcap protection device to otrail, which boots with it present * hooked it up to mog_m320 and pixel246, the former of which now goes to menu (pixel246 seems to ignore the results anyway) * hooked up seeprom to otrail, allowing for game to be loaded / saved and high score table to show correctly * various cleanups (ATTR_COLD, formatting)
1 parent ed1d1a4 commit 0034dde

20 files changed

Lines changed: 859 additions & 434 deletions

‎src/mame/mame.lst‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36141,6 +36141,8 @@ gcs2mgp
3614136141
gon100
3614236142
goretrop
3614336143
goretropa
36144+
goretropu12
36145+
goretropu13
3614436146
gtct885
3614536147
h12p1000
3614636148
hkb502

‎src/mame/nintendo/nes_clone.cpp‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,10 @@ class nes_clone_dancexpt_state : public nes_clone_state
106106
class nes_clone_dnce2000_state : public nes_clone_state
107107
{
108108
public:
109-
nes_clone_dnce2000_state(const machine_config& mconfig, device_type type, const char* tag) :
109+
nes_clone_dnce2000_state(const machine_config &mconfig, device_type type, const char *tag) :
110110
nes_clone_state(mconfig, type, tag)
111111
{ }
112-
void nes_clone_dnce2000(machine_config& config) ATTR_COLD;
112+
void nes_clone_dnce2000(machine_config &config) ATTR_COLD;
113113

114114
private:
115115
void nes_clone_dnce2000_map(address_map &map) ATTR_COLD;
@@ -123,13 +123,13 @@ class nes_clone_dnce2000_state : public nes_clone_state
123123
class nes_clone_sudoku_state : public nes_clone_state
124124
{
125125
public:
126-
nes_clone_sudoku_state(const machine_config& mconfig, device_type type, const char* tag) :
126+
nes_clone_sudoku_state(const machine_config &mconfig, device_type type, const char *tag) :
127127
nes_clone_state(mconfig, type, tag)
128128
{ }
129129

130130
void init_sudoku() ATTR_COLD;
131131

132-
void nes_clone_sudoku(machine_config& config) ATTR_COLD;
132+
void nes_clone_sudoku(machine_config &config) ATTR_COLD;
133133

134134
private:
135135
void nes_clone_sudoku_map(address_map &map) ATTR_COLD;
@@ -143,12 +143,12 @@ class nes_clone_sudoku_state : public nes_clone_state
143143
class nes_clone_vtvsocr_state : public nes_clone_state
144144
{
145145
public:
146-
nes_clone_vtvsocr_state(const machine_config& mconfig, device_type type, const char* tag) :
146+
nes_clone_vtvsocr_state(const machine_config &mconfig, device_type type, const char *tag) :
147147
nes_clone_state(mconfig, type, tag)
148148
{ }
149149

150-
void nes_clone_vtvsocr(machine_config& config);
151-
void nes_clone_danzkara_pal(machine_config& config);
150+
void nes_clone_vtvsocr(machine_config &config) ATTR_COLD;
151+
void nes_clone_danzkara_pal(machine_config &config) ATTR_COLD;
152152

153153
private:
154154
void nes_clone_vtvsocr_map(address_map &map) ATTR_COLD;
@@ -164,15 +164,15 @@ class nes_clone_vtvsocr_state : public nes_clone_state
164164
class nes_clone_afbm7800_state : public nes_clone_state
165165
{
166166
public:
167-
nes_clone_afbm7800_state(const machine_config& mconfig, device_type type, const char* tag) :
167+
nes_clone_afbm7800_state(const machine_config &mconfig, device_type type, const char *tag) :
168168
nes_clone_state(mconfig, type, tag),
169169
m_prgbank(*this, "prgbank%u", 0),
170170
m_cbank(*this, "cbank%u", 0),
171171
m_nametables(*this, "nametable%u", 0),
172172
m_charbank(*this, "charbank"),
173173
m_rom_solderpad_bank(*this, "rom_sldpad_bank")
174174
{ }
175-
void nes_clone_afbm7800(machine_config& config) ATTR_COLD;
175+
void nes_clone_afbm7800(machine_config &config) ATTR_COLD;
176176

177177
protected:
178178
virtual void machine_start() override ATTR_COLD;
@@ -316,7 +316,7 @@ void nes_clone_state::in0_w(uint8_t data)
316316
}
317317

318318

319-
void nes_clone_state::nes_clone_basemap(address_map& map)
319+
void nes_clone_state::nes_clone_basemap(address_map &map)
320320
{
321321
map(0x0000, 0x07ff).ram();
322322
map(0x2000, 0x3fff).rw(m_ppu, FUNC(ppu2c0x_device::read), FUNC(ppu2c0x_device::write));
@@ -327,7 +327,7 @@ void nes_clone_state::nes_clone_basemap(address_map& map)
327327
map(0x4017, 0x4017).r(FUNC(nes_clone_state::in1_r));
328328
}
329329

330-
void nes_clone_state::nes_clone_map(address_map& map)
330+
void nes_clone_state::nes_clone_map(address_map &map)
331331
{
332332
nes_clone_basemap(map);
333333
map(0x8000, 0xffff).rom();
@@ -647,13 +647,13 @@ void nes_clone_dancexpt_state::nes_clone_dancexpt_map(address_map &map)
647647
Dance 2000 Specifics
648648
**************************************************/
649649

650-
void nes_clone_dnce2000_state::nes_clone_dnce2000(machine_config& config)
650+
void nes_clone_dnce2000_state::nes_clone_dnce2000(machine_config &config)
651651
{
652652
nes_clone_pal(config);
653653
m_maincpu->set_addrmap(AS_PROGRAM, &nes_clone_dnce2000_state::nes_clone_dnce2000_map);
654654
}
655655

656-
void nes_clone_dnce2000_state::nes_clone_dnce2000_map(address_map& map)
656+
void nes_clone_dnce2000_state::nes_clone_dnce2000_map(address_map &map)
657657
{
658658
nes_clone_basemap(map);
659659
map(0x8000, 0xffff).rw(FUNC(nes_clone_dnce2000_state::rom_r), FUNC(nes_clone_dnce2000_state::bank_w));
@@ -685,7 +685,7 @@ void nes_clone_dnce2000_state::bank_w(uint8_t data)
685685
Atari Flashback Specifics
686686
**************************************************/
687687

688-
void nes_clone_afbm7800_state::nes_clone_afbm7800(machine_config& config)
688+
void nes_clone_afbm7800_state::nes_clone_afbm7800(machine_config &config)
689689
{
690690
nes_clone_pal(config);
691691
m_maincpu->set_addrmap(AS_PROGRAM, &nes_clone_afbm7800_state::nes_clone_afbm7800_map);
@@ -1090,7 +1090,7 @@ void nes_clone_afbm7800_state::vram_map(address_map &map)
10901090
map(0x3800, 0x3fff).bankrw("cbank1");
10911091
}
10921092

1093-
void nes_clone_afbm7800_state::ntram_map(address_map& map)
1093+
void nes_clone_afbm7800_state::ntram_map(address_map &map)
10941094
{
10951095
map(0x0000, 0x03ff).bankrw("nametable0");
10961096
map(0x0400, 0x07ff).bankrw("nametable1");
@@ -1229,13 +1229,13 @@ void nes_clone_sudoku_state::machine_start()
12291229
save_item(NAME(m_rombase));
12301230
}
12311231

1232-
void nes_clone_sudoku_state::nes_clone_sudoku(machine_config& config)
1232+
void nes_clone_sudoku_state::nes_clone_sudoku(machine_config &config)
12331233
{
12341234
nes_clone(config);
12351235
m_maincpu->set_addrmap(AS_PROGRAM, &nes_clone_sudoku_state::nes_clone_sudoku_map);
12361236
}
12371237

1238-
void nes_clone_sudoku_state::nes_clone_sudoku_map(address_map& map)
1238+
void nes_clone_sudoku_state::nes_clone_sudoku_map(address_map &map)
12391239
{
12401240
nes_clone_basemap(map);
12411241
map(0x8000, 0xffff).rw(FUNC(nes_clone_sudoku_state::rom_r), FUNC(nes_clone_sudoku_state::bank_w));
@@ -1295,19 +1295,19 @@ void nes_clone_vtvsocr_state::machine_start()
12951295
save_item(NAME(m_bankregs));
12961296
}
12971297

1298-
void nes_clone_vtvsocr_state::nes_clone_vtvsocr(machine_config& config)
1298+
void nes_clone_vtvsocr_state::nes_clone_vtvsocr(machine_config &config)
12991299
{
13001300
nes_clone(config);
13011301
m_maincpu->set_addrmap(AS_PROGRAM, &nes_clone_vtvsocr_state::nes_clone_vtvsocr_map);
13021302
}
13031303

1304-
void nes_clone_vtvsocr_state::nes_clone_danzkara_pal(machine_config& config)
1304+
void nes_clone_vtvsocr_state::nes_clone_danzkara_pal(machine_config &config)
13051305
{
13061306
nes_clone_pal(config);
13071307
m_maincpu->set_addrmap(AS_PROGRAM, &nes_clone_vtvsocr_state::nes_clone_vtvsocr_map);
13081308
}
13091309

1310-
void nes_clone_vtvsocr_state::nes_clone_vtvsocr_map(address_map& map)
1310+
void nes_clone_vtvsocr_state::nes_clone_vtvsocr_map(address_map &map)
13111311
{
13121312
nes_clone_basemap(map);
13131313
map(0x4800, 0x4803).w(FUNC(nes_clone_vtvsocr_state::bank_w));

‎src/mame/nintendo/nes_sh6578.cpp‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ namespace {
3737
class nes_sh6578_state : public driver_device
3838
{
3939
public:
40-
nes_sh6578_state(const machine_config& mconfig, device_type type, const char* tag) :
40+
nes_sh6578_state(const machine_config &mconfig, device_type type, const char *tag) :
4141
driver_device(mconfig, type, tag),
4242
m_bank(*this, "cartbank"),
4343
m_maincpu(*this, "maincpu"),
@@ -50,10 +50,10 @@ class nes_sh6578_state : public driver_device
5050
m_ext(*this, "EXT")
5151
{ }
5252

53-
void nes_sh6578(machine_config& config);
54-
void nes_sh6578_pal(machine_config& config);
53+
void nes_sh6578(machine_config &config) ATTR_COLD;
54+
void nes_sh6578_pal(machine_config &config) ATTR_COLD;
5555

56-
void init_nes_sh6578();
56+
void init_nes_sh6578() ATTR_COLD;
5757

5858
int unknown_random_r()
5959
{
@@ -138,7 +138,7 @@ class nes_sh6578_state : public driver_device
138138

139139
void rom_map(address_map &map) ATTR_COLD;
140140
void nes_sh6578_map(address_map &map) ATTR_COLD;
141-
void ppu_map(address_map &map);
141+
void ppu_map(address_map &map) ATTR_COLD;
142142

143143
//uint16_t get_tileaddress(uint8_t x, uint8_t y, bool ishigh);
144144

@@ -157,7 +157,7 @@ class nes_sh6578_state : public driver_device
157157
class nes_sh6578_abl_wikid_state : public nes_sh6578_state
158158
{
159159
public:
160-
nes_sh6578_abl_wikid_state(const machine_config& mconfig, device_type type, const char* tag) :
160+
nes_sh6578_abl_wikid_state(const machine_config &mconfig, device_type type, const char *tag) :
161161
nes_sh6578_state(mconfig, type, tag)
162162
{ }
163163

@@ -168,7 +168,7 @@ class nes_sh6578_abl_wikid_state : public nes_sh6578_state
168168
class nes_sh6578_max10in1_state : public nes_sh6578_state
169169
{
170170
public:
171-
nes_sh6578_max10in1_state(const machine_config& mconfig, device_type type, const char* tag) :
171+
nes_sh6578_max10in1_state(const machine_config &mconfig, device_type type, const char *tag) :
172172
nes_sh6578_state(mconfig, type, tag)
173173
{ }
174174

@@ -475,7 +475,7 @@ uint8_t nes_sh6578_state::apu_read_mem(offs_t offset)
475475

476476

477477

478-
void nes_sh6578_state::nes_sh6578_map(address_map& map)
478+
void nes_sh6578_state::nes_sh6578_map(address_map &map)
479479
{
480480
map(0x0000, 0x1fff).ram();
481481
map(0x2000, 0x2007).rw(m_ppu, FUNC(ppu2c0x_device::read), FUNC(ppu2c0x_device::write));
@@ -605,7 +605,7 @@ void nes_sh6578_state::machine_start()
605605
}
606606

607607
// SH6578 can address 20-bit address space (1MB of ROM)
608-
void nes_sh6578_state::rom_map(address_map& map)
608+
void nes_sh6578_state::rom_map(address_map &map)
609609
{
610610
map(0x00000, 0xfffff).bankr("cartbank");
611611
}
@@ -640,7 +640,7 @@ void nes_sh6578_state::ppu_map(address_map &map)
640640
}
641641

642642

643-
void nes_sh6578_state::nes_sh6578(machine_config& config)
643+
void nes_sh6578_state::nes_sh6578(machine_config &config)
644644
{
645645
/* basic machine hardware */
646646
M6502(config, m_maincpu, NTSC_APU_CLOCK); // regular M6502 core, not RP2A03?
@@ -676,7 +676,7 @@ void nes_sh6578_state::nes_sh6578(machine_config& config)
676676
m_apu->add_route(ALL_OUTPUTS, "mono", 0.50);
677677
}
678678

679-
void nes_sh6578_state::nes_sh6578_pal(machine_config& config)
679+
void nes_sh6578_state::nes_sh6578_pal(machine_config &config)
680680
{
681681
nes_sh6578(config);
682682

0 commit comments

Comments
 (0)