Skip to content

Commit 47d9544

Browse files
committed
dvmemory: redo 47377bf
1 parent 603917f commit 47d9544

3 files changed

Lines changed: 4 additions & 12 deletions

File tree

src/emu/debug/debugvw.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,10 +277,10 @@ class debug_view_expression
277277
void set_context(symbol_table *context);
278278
void set_default_base(int base) { m_parsed.set_default_base(base); }
279279

280-
private:
281-
// internal helpers
280+
// helpers
282281
bool recompute();
283282

283+
private:
284284
// internal state
285285
running_machine & m_machine; // reference to the machine
286286
bool m_dirty; // true if the expression needs to be re-evaluated

src/emu/debug/dvmemory.cpp

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -717,18 +717,11 @@ bool debug_view_memory::needs_recompute()
717717
{
718718
bool recompute = m_recompute;
719719

720-
offs_t val = m_expression.value();
721-
// checks if evaluated expression value has changed since last time
722-
if (val != m_expression_computed)
723-
{
724-
m_expression_computed = val;
725-
m_expression.mark_dirty();
726-
}
727-
728720
// handle expression changes
729-
if (m_expression.dirty())
721+
if (m_expression.recompute())
730722
{
731723
const debug_view_memory_source &source = downcast<const debug_view_memory_source &>(*m_source);
724+
offs_t val = m_expression.last_value();
732725
if (source.m_memintf)
733726
{
734727
const address_space_config *config = m_no_translation ? source.m_memintf->space_config(source.m_spacenum) : source.m_memintf->logical_space_config(source.m_spacenum);

src/emu/debug/dvmemory.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ class debug_view_memory : public debug_view
134134

135135
// internal state
136136
debug_view_expression m_expression; // expression describing the start address
137-
offs_t m_expression_computed; // latest value of computed expression
138137
u32 m_chunks_per_row; // number of chunks displayed per line
139138
u8 m_bytes_per_chunk; // bytes per chunk
140139
u8 m_steps_per_chunk; // bytes per chunk

0 commit comments

Comments
 (0)