namco_c148: make ext read a callback

Author: happppp

src/mame/namco/namco_c148.cpp

@@ -70,6 +70,7 @@ DEFINE_DEVICE_TYPE(NAMCO_C148, namco_c148_device, "namco_c148", "Namco C148 Inte
 
 namco_c148_device::namco_c148_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock) :
 	device_t(mconfig, NAMCO_C148, tag, owner, clock),
+	m_in_ext_cb(*this, 0x07),
 	m_out_ext1_cb(*this),
 	m_out_ext2_cb(*this),
 	m_hostcpu(*this, finder_base::DUMMY_TAG),
@@ -185,7 +186,7 @@ void namco_c148_device::sci_irq_trigger()    { m_hostcpu->set_input_line(m_irqle
 
 uint8_t namco_c148_device::ext_r()
 {
-	return 0xff; // TODO: bit 0 EEPROM bit ready
+	return m_in_ext_cb() & 7;
 }
 
 void namco_c148_device::ext1_w(uint8_t data)
@@ -196,7 +197,6 @@ void namco_c148_device::ext1_w(uint8_t data)
 void namco_c148_device::ext2_w(uint8_t data)
 {
 	m_out_ext2_cb(data & 7);
-	// TODO: bit 1/2 in Winning Run GPU might be irq enable?
 }
 
 uint8_t namco_c148_device::bus_ctrl_r()

src/mame/namco/namco_c148.h

@@ -39,6 +39,7 @@ class namco_c148_device : public device_t
 
 	template <typename T> void link_c148_device(T &&tag) { m_linked_c148.set_tag(std::forward<T>(tag)); }
 
+	auto in_ext_callback() { return m_in_ext_cb.bind(); }
 	auto out_ext1_callback() { return m_out_ext1_cb.bind(); }
 	auto out_ext2_callback() { return m_out_ext2_cb.bind(); }
 
@@ -55,6 +56,7 @@ class namco_c148_device : public device_t
 	virtual void device_reset() override ATTR_COLD;
 
 private:
+	devcb_read8 m_in_ext_cb;
 	devcb_write8 m_out_ext1_cb;
 	devcb_write8 m_out_ext2_cb;
 

src/mame/namco/namcos21.cpp

@@ -31,7 +31,7 @@ a stream of quad descriptors.
 
 Each quad has a reference color (shared across vertices), and for each vertex the tuple: (screenx,screeny,z-code).
 The z-code scalar accounts for depth bias.  Quads are sorted by z-code before rendering quads, and depth cueing
-is used to shade pixels according to their depth.
+is used to shade quads according to their depth.
 
 -------------------
 
@@ -828,6 +828,9 @@ void namcos21_state::winrun(machine_config &config)
 	M68000(config, m_slave, 49.152_MHz_XTAL / 4); // Slave
 	m_slave->set_addrmap(AS_PROGRAM, &namcos21_state::slave_map);
 
+	M68000(config, m_gpu, 49.152_MHz_XTAL / 4); // Graphics coprocessor
+	m_gpu->set_addrmap(AS_PROGRAM, &namcos21_state::gpu_map);
+
 	MC6809E(config, m_audiocpu, 49.152_MHz_XTAL / 24); // Sound
 	m_audiocpu->set_addrmap(AS_PROGRAM, &namcos21_state::sound_map);
 
@@ -854,9 +857,6 @@ void namcos21_state::winrun(machine_config &config)
 	NAMCOS21_DSP(config, m_namcos21_dsp, 0);
 	m_namcos21_dsp->set_renderer_tag("namcos21_3d");
 
-	M68000(config, m_gpu, 49.152_MHz_XTAL / 4); // graphics coprocessor
-	m_gpu->set_addrmap(AS_PROGRAM, &namcos21_state::gpu_map);
-
 	NAMCO_C148(config, m_master_intc, 0, m_maincpu, true);
 	m_master_intc->link_c148_device(m_slave_intc);
 	m_master_intc->out_ext1_callback().set(FUNC(namcos21_state::sound_reset_w));