osd/netdev/pcap.cpp: Fix inverted success/failure return from send() (#15874)

* osd/netdev/pcap.cpp: Fix inverted success/failure return from send().

pcap_sendpacket() returns 0 on success and PCAP_ERROR on failure, but
netdev_pcap::send() was returning the byte count only when the call
failed and 0 on success.

* osd/netdev/pcap.cpp: Remove orphaned dead comment in send().

Author: nburns

src/osd/modules/netdev/pcap.cpp

@@ -231,8 +231,7 @@ int pcap_module::netdev_pcap::send(void const *buf, int len)
 	}
 	int ret = (*m_module.pcap_sendpacket_dl)(m_p, reinterpret_cast<const u_char *>(buf), len);
 	printf("sent packet length %d, returned %d\n", len, ret);
-	return ret ? len : 0;
-	//return (!pcap_sendpacket_dl(m_p, reinterpret_cast<const u_char *>(buf), len)) ? len : 0;
+	return !ret ? len : 0;
 }
 
 int pcap_module::netdev_pcap::recv_dev(uint8_t **buf)