c140: assume keyon reg 0x40 is some kind of retrigger

Author: happppp

src/devices/sound/c140.cpp

@@ -2,7 +2,7 @@
 // copyright-holders:R. Belmont
 /*
 
-c140.cpp
+Namco C140
 
 Simulator based on AMUSE sources.
 The C140 sound chip is used by Namco System 2 and System 21
@@ -21,7 +21,8 @@ Channels can be 8 bit compressed PCM, or 12 bit signed PCM.
 - Acknowledge A9 bit (9th address bit) of host interface
 - Verify data bus bits of C219
 - Verify C219 LFSR algorithm (same as c352.cpp?)
-- Verify unknown mode bits (0x40 for C140, 0x02 for C219)
+- Verify unknown mode bits (eg. Final Lap & Winning Run games)
+- Verify status register (see keyon_status_read)
 
 --------------
 
@@ -459,9 +460,11 @@ inline u8 c140_device::keyon_status_read(u16 offset)
 	m_stream->update();
 	C140_VOICE const &v = m_voi[offset >> 4];
 
-	// suzuka 8 hours and final lap games read from here, expecting bit 6 to be an in-progress sample flag.
-	// four trax also expects bit 4 high for some specific channels to make engine noises to work properly
-	// (sounds kinda bogus when player crashes in an object and jump spin, needs real HW verification)
+	// Suzuka 8 Hours and Final Lap games read from here, expecting bit 6 to be
+	// an in-progress sample flag. Simply returning the register value, even after
+	// clearing the highest 2 bits after keyoff won't work.
+	// Four Trax also expects bit 4 high for some specific channels (the loop flag),
+	// so assume that part of register 0x5 is still returned as normal.
 	return (v.key ? 0x40 : 0x00) | (m_REG[offset] & 0x3f);
 }
 
@@ -499,7 +502,7 @@ void c140_device::c140_w(offs_t offset, u8 data)
 
 		if ((offset & 0xf) == 0x5)
 		{
-			if (data & 0x80)
+			if (data & 0x80 || (data & 0x40 && v->key))
 			{
 				const struct voice_registers *vreg = (struct voice_registers *) &m_REG[offset & 0x1f0];
 				v->key = 1;
@@ -598,7 +601,7 @@ void c219_device::c219_w(offs_t offset, u8 data)
 
 		if ((offset & 0xf) == 0x5)
 		{
-			if (data & 0x80)
+			if (data & 0x80 || (data & 0x40 && v->key))
 			{
 				const struct voice_registers *vreg = (struct voice_registers *) &m_REG[offset & 0x1f0];
 				v->key = 1;

src/devices/sound/c140.h

@@ -1,6 +1,5 @@
 // license:BSD-3-Clause
 // copyright-holders:R. Belmont
-/* c140.h */
 
 #ifndef MAME_SOUND_C140_H
 #define MAME_SOUND_C140_H
@@ -123,6 +122,7 @@ class c219_device : public c140_device
 	virtual int find_sample(int adrs, int bank, int voice) override;
 
 	virtual const inline bool ch_mulaw(C140_VOICE *v) override { return BIT(v->mode, 0); }
+
 private:
 	// bit 1 used, unknown
 	const inline bool ch_noise(C140_VOICE *v) { return BIT(v->mode, 2); }

src/mame/namco/namcos2.cpp

@@ -1507,11 +1507,11 @@ static INPUT_PORTS_START( dirtfox )
 	PORT_START("AN4")       /* 63B05Z0 - 8 CHANNEL ANALOG - CHANNEL 4 */
 	PORT_BIT( 0xff, IP_ACTIVE_LOW, IPT_UNUSED )
 	PORT_START("AN5")       /* Steering Wheel */
-	PORT_BIT( 0xff, 0x80, IPT_PADDLE ) PORT_MINMAX(0x01,0xff) PORT_SENSITIVITY(70) PORT_KEYDELTA(50)
+	PORT_BIT( 0xff, 0x80, IPT_PADDLE ) PORT_MINMAX(0x01,0xff) PORT_SENSITIVITY(50) PORT_KEYDELTA(8)
 	PORT_START("AN6")       /* Brake pedal */
-	PORT_BIT( 0xff, 0x00, IPT_PEDAL2 ) PORT_MINMAX(0x00,0x40) PORT_SENSITIVITY(100) PORT_KEYDELTA(15) PORT_NAME("Brake")
+	PORT_BIT( 0xff, 0x00, IPT_PEDAL2 ) PORT_MINMAX(0x00,0x40) PORT_SENSITIVITY(50) PORT_KEYDELTA(8) PORT_NAME("Brake")
 	PORT_START("AN7")       /* Accelerator pedal */
-	PORT_BIT( 0xff, 0x00, IPT_PEDAL ) PORT_MINMAX(0x00,0x80) PORT_SENSITIVITY(100) PORT_KEYDELTA(15) PORT_NAME("Accelerator")
+	PORT_BIT( 0xff, 0x00, IPT_PEDAL ) PORT_MINMAX(0x00,0x80) PORT_SENSITIVITY(50) PORT_KEYDELTA(8) PORT_NAME("Accelerator")
 
 	PORT_START("MCUH")      /* 63B05Z0 - PORT H */
 	PORT_BIT( 0xff, IP_ACTIVE_LOW, IPT_UNUSED )
@@ -1538,11 +1538,11 @@ static INPUT_PORTS_START( metlhawk )
 	PORT_START("AN4")       /* 63B05Z0 - 8 CHANNEL ANALOG - CHANNEL 4 */
 	PORT_BIT( 0xff, IP_ACTIVE_LOW, IPT_UNUSED )
 	PORT_START("AN5")       /* Joystick Y */
-	PORT_BIT( 0xff, 0x80, IPT_AD_STICK_Y ) PORT_MINMAX(0x20,0xe0) PORT_SENSITIVITY(100) PORT_KEYDELTA(16)
+	PORT_BIT( 0xff, 0x80, IPT_AD_STICK_Y ) PORT_MINMAX(0x20,0xe0) PORT_SENSITIVITY(50) PORT_KEYDELTA(8)
 	PORT_START("AN6")       /* Joystick X */
-	PORT_BIT( 0xff, 0x80, IPT_AD_STICK_X ) PORT_MINMAX(0x20,0xe0) PORT_SENSITIVITY(100) PORT_KEYDELTA(16)
+	PORT_BIT( 0xff, 0x80, IPT_AD_STICK_X ) PORT_MINMAX(0x20,0xe0) PORT_SENSITIVITY(50) PORT_KEYDELTA(8)
 	PORT_START("AN7")       /* Lever */
-	PORT_BIT( 0xff, 0x80, IPT_AD_STICK_Z ) PORT_MINMAX(0x20,0xe0) PORT_SENSITIVITY(100) PORT_KEYDELTA(16)
+	PORT_BIT( 0xff, 0x80, IPT_AD_STICK_Z ) PORT_MINMAX(0x20,0xe0) PORT_SENSITIVITY(50) PORT_KEYDELTA(8)
 
 	PORT_START("MCUH")      /* 63B05Z0 - PORT H */
 	PORT_BIT( 0x20, IP_ACTIVE_LOW, IPT_BUTTON1 )

src/mame/namco/namcos21.cpp

@@ -36,7 +36,6 @@ is used to shade pixels according to their depth.
 
 TODO:
 - polygon glitches/flicker
-- car engine sound is wrong
 - pressing service mode while the game is running causes it to lock up (need to press F3)
 - is there a video_enable flag? or at least one for the bitmap layer (see screen transitions)
 - winrungp: some missing bitmap layer gfx due to underdumps of the gpu program roms (see attract mode
@@ -1051,8 +1050,8 @@ ROM_END
 
 /*    YEAR  NAME       PARENT    MACHINE   INPUT       CLASS           INIT          MONITOR  COMPANY  FULLNAME                                                           FLAGS */
 
-GAME( 1988, winrun,    0,        winrun,   winrun,     namcos21_state, empty_init,   ROT0,    "Namco", "Winning Run (World) (89/06/06, Ver.09)",                          MACHINE_IMPERFECT_GRAPHICS | MACHINE_IMPERFECT_SOUND | MACHINE_SUPPORTS_SAVE ) // Sub Ver.09, 1989, Graphic Ver .06, 89/01/14, Sound Ver.2.00
-GAME( 1989, winrungp,  0,        winrun,   winrungp,   namcos21_state, empty_init,   ROT0,    "Namco", "Winning Run Suzuka Grand Prix (Japan) (89/12/03, Ver.02)",        MACHINE_IMPERFECT_GRAPHICS | MACHINE_IMPERFECT_SOUND | MACHINE_NODEVICE_LAN | MACHINE_SUPPORTS_SAVE ) // Sub Ver.02, 1989, Graphic Ver.02 89/12/03, Sound Ver.0000
+GAME( 1988, winrun,    0,        winrun,   winrun,     namcos21_state, empty_init,   ROT0,    "Namco", "Winning Run (World) (89/06/06, Ver.09)",                          MACHINE_IMPERFECT_GRAPHICS | MACHINE_SUPPORTS_SAVE ) // Sub Ver.09, 1989, Graphic Ver .06, 89/01/14, Sound Ver.2.00
+GAME( 1989, winrungp,  0,        winrun,   winrungp,   namcos21_state, empty_init,   ROT0,    "Namco", "Winning Run Suzuka Grand Prix (Japan) (89/12/03, Ver.02)",        MACHINE_IMPERFECT_GRAPHICS | MACHINE_NODEVICE_LAN | MACHINE_SUPPORTS_SAVE ) // Sub Ver.02, 1989, Graphic Ver.02 89/12/03, Sound Ver.0000
 
 // Available on a size/cost reduced 2 PCB set with 'Namco System 21B' printed on each board, still C65 I/O MCU, appears to be functionally identical to original NS21
-GAME( 1991, winrun91,  0,        winrun,   winrungp,   namcos21_state, empty_init,   ROT0,    "Namco", "Winning Run '91 (Japan) (1991/03/05, Main Ver 1.0, Sub Ver 1.0)", MACHINE_IMPERFECT_GRAPHICS | MACHINE_IMPERFECT_SOUND | MACHINE_NODEVICE_LAN | MACHINE_SUPPORTS_SAVE )
+GAME( 1991, winrun91,  0,        winrun,   winrungp,   namcos21_state, empty_init,   ROT0,    "Namco", "Winning Run '91 (Japan) (1991/03/05, Main Ver 1.0, Sub Ver 1.0)", MACHINE_IMPERFECT_GRAPHICS | MACHINE_NODEVICE_LAN | MACHINE_SUPPORTS_SAVE )

src/mame/namco/namcos21_c67.cpp

@@ -8,7 +8,7 @@ Namco System 21 (later hardware with 5 TMS320C25 DSPs)
 - lamp/vibration outputs, from MCU? (particularly starblad);
 - verify DSP clocks, they should be 40MHz, currently underclocked on purpose on MAME, otherwise polygons
   may disappear on some frames (try playing starblad until after the asteroids), tightening quantum by
-  a factor of 40/24 does not fix it;
+  a factor of 40/24 does not fix it, actually it also happens when underclocked, but less;
 - verify video timing, pixel clock is from 38.76922?;
 - verify audiocpu irq frequency;
 - is m_layer0_pivot software-controlled and if so, where? (solvalou sprite layer 0 is further back than

src/mame/namco/namcos21_de.cpp

@@ -842,4 +842,4 @@ ROM_END
 /*    YEAR  NAME       PARENT    MACHINE   INPUT       CLASS           INIT           MONITOR  COMPANY  FULLNAME                                 FLAGS */
 
 // 3 PCB stacks in a single cage (3x 4 PCBs) linked for 3 screen panorama, boards look similar to original Namco System 21 (not 21B) including TMS320C25 DSP, but use C68 I/O MCU and sprite chip instead of "68000 'GPU'" ?
-GAME( 1992, driveyes,  0,        driveyes, driveyes,   namcos21_de_state, empty_init, ROT0,    "Namco", "Driver's Eyes (Japan) (1992/01/10, Main Ver 2.1, Sub Ver 1.1)", MACHINE_NOT_WORKING | MACHINE_IMPERFECT_GRAPHICS | MACHINE_IMPERFECT_SOUND | MACHINE_NODEVICE_LAN | MACHINE_SUPPORTS_SAVE )
+GAME( 1992, driveyes,  0,        driveyes, driveyes,   namcos21_de_state, empty_init, ROT0,    "Namco", "Driver's Eyes (Japan) (1992/01/10, Main Ver 2.1, Sub Ver 1.1)", MACHINE_NOT_WORKING | MACHINE_IMPERFECT_GRAPHICS | MACHINE_NODEVICE_LAN | MACHINE_SUPPORTS_SAVE )