Skip to content

Commit cf5c893

Browse files
committed
remove all platfrom checks from tests
1 parent fb05022 commit cf5c893

3 files changed

Lines changed: 11 additions & 35 deletions

File tree

halo/halo.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
decode_utf_8_text,
2121
get_environment,
2222
get_terminal_columns,
23-
is_supported,
2423
is_text_type,
2524
encode_utf_8_text,
2625
)

tests/test_halo.py

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from spinners.spinners import Spinners
1717

1818
from halo import Halo
19-
from halo._utils import get_terminal_columns, is_supported
19+
from halo._utils import get_terminal_columns
2020
from tests._utils import strip_ansi, find_colors, encode_utf_8_text, decode_utf_8_text
2121

2222
from termcolor import COLORS
@@ -26,12 +26,8 @@
2626
else:
2727
get_coded_text = decode_utf_8_text
2828

29-
if is_supported():
30-
frames = [get_coded_text(frame) for frame in Spinners['dots'].value['frames']]
31-
default_spinner = Spinners['dots'].value
32-
else:
33-
frames = [get_coded_text(frame) for frame in Spinners['line'].value['frames']]
34-
default_spinner = Spinners['line'].value
29+
frames = [get_coded_text(frame) for frame in Spinners['dots'].value['frames']]
30+
default_spinner = Spinners['dots'].value
3531

3632

3733
class SpecificException(Exception):
@@ -127,10 +123,7 @@ def test_text_spinner_color(self):
127123

128124
def test_spinner_getter(self):
129125
instance = Halo()
130-
if is_supported():
131-
default_spinner_value = "dots"
132-
else:
133-
default_spinner_value = "line"
126+
default_spinner_value = "dots"
134127

135128
instance.spinner = default_spinner_value
136129
self.assertEqual(default_spinner, instance.spinner)
@@ -368,16 +361,10 @@ def test_spinner_getters_setters(self):
368361
self.assertEqual(spinner.text_color, 'red')
369362
self.assertEqual(spinner.color, 'red')
370363

371-
if is_supported():
372-
self.assertEqual(spinner.spinner, Spinners['dots12'].value)
373-
else:
374-
self.assertEqual(spinner.spinner, default_spinner)
364+
self.assertEqual(spinner.spinner, Spinners['dots12'].value)
375365

376366
spinner.spinner = 'dots11'
377-
if is_supported():
378-
self.assertEqual(spinner.spinner, Spinners['dots11'].value)
379-
else:
380-
self.assertEqual(spinner.spinner, default_spinner)
367+
self.assertEqual(spinner.spinner, Spinners['dots11'].value)
381368

382369
spinner.spinner = 'foo_bar'
383370
self.assertEqual(spinner.spinner, default_spinner)

tests/test_halo_notebook.py

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from spinners.spinners import Spinners
1111

1212
from halo import HaloNotebook
13-
from halo._utils import get_terminal_columns, is_supported
13+
from halo._utils import get_terminal_columns
1414
from tests._utils import decode_utf_8_text, encode_utf_8_text, find_colors, strip_ansi
1515

1616
from termcolor import COLORS
@@ -21,12 +21,8 @@
2121
get_coded_text = decode_utf_8_text
2222

2323

24-
if is_supported():
25-
frames = [get_coded_text(frame) for frame in Spinners['dots'].value['frames']]
26-
default_spinner = Spinners['dots'].value
27-
else:
28-
frames = [get_coded_text(frame) for frame in Spinners['line'].value['frames']]
29-
default_spinner = Spinners['line'].value
24+
frames = [get_coded_text(frame) for frame in Spinners['dots'].value['frames']]
25+
default_spinner = Spinners['dots'].value
3026

3127

3228
class TestHaloNotebook(unittest.TestCase):
@@ -327,16 +323,10 @@ def test_spinner_getters_setters(self):
327323
self.assertEqual(spinner.text, 'bar')
328324
self.assertEqual(spinner.color, 'red')
329325

330-
if is_supported():
331-
self.assertEqual(spinner.spinner, Spinners['dots12'].value)
332-
else:
333-
self.assertEqual(spinner.spinner, default_spinner)
326+
self.assertEqual(spinner.spinner, Spinners['dots12'].value)
334327

335328
spinner.spinner = 'dots11'
336-
if is_supported():
337-
self.assertEqual(spinner.spinner, Spinners['dots11'].value)
338-
else:
339-
self.assertEqual(spinner.spinner, default_spinner)
329+
self.assertEqual(spinner.spinner, Spinners['dots11'].value)
340330

341331
spinner.spinner = 'foo_bar'
342332
self.assertEqual(spinner.spinner, default_spinner)

0 commit comments

Comments
 (0)