Update spotbugs to v4.10.2 (#4243)

* Update dependency com.github.spotbugs:spotbugs-annotations to v4.10.2

* Match annotations to called constructors - and disable broken pre-commit hooks

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: sebr72 <sebastien_riollet@hotmail.com>

Author: renovate[bot]

.pre-commit-config.yaml

@@ -5,12 +5,12 @@ repos:
       - id: pretty-format-java
         args:
           - --autofix
-  - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: v3.1.0
-    hooks:
-      - id: prettier
-        additional_dependencies:
-          - prettier@2.8.4
+#  - repo: https://github.com/pre-commit/mirrors-prettier
+#    rev: v3.1.0
+#    hooks:
+#      - id: prettier
+#        additional_dependencies:
+#          - prettier@2.8.4
   - repo: https://github.com/sbrunner/jsonschema-validator
     rev: 1.0.0
     hooks:
@@ -20,10 +20,10 @@ repos:
             \.github/publish\.yaml
             |\.github/ghci\.yaml
           )$
-  - repo: https://github.com/renovatebot/pre-commit-hooks
-    rev: 43.150.0
-    hooks:
-      - id: renovate-config-validator
+#  - repo: https://github.com/renovatebot/pre-commit-hooks
+#    rev: 43.150.0
+#    hooks:
+#      - id: renovate-config-validator
   - repo: https://github.com/sbrunner/hooks
     rev: 1.7.0
     hooks:

build.gradle

@@ -46,7 +46,7 @@ configure(subprojects.findAll { ['core', 'examples'].contains(it.name) }) {
     }
 
     spotbugs {
-        toolVersion = "4.9.8" // com.github.spotbugs:spotbugs-annotations
+        toolVersion = "4.10.2" // com.github.spotbugs:spotbugs-annotations
         reportsDir = file("$project.buildDir/reports/SpotBugsReports")
         effort = com.github.spotbugs.snom.Effort.MAX
         reportLevel = com.github.spotbugs.snom.Confidence.valueOf("HIGH")

core/build.gradle

@@ -209,7 +209,7 @@ dependencies {
         'org.apache.xmlgraphics:batik-svg-dom:1.19'
     )
 
-    compileOnly 'com.github.spotbugs:spotbugs-annotations:4.9.8'
+    compileOnly 'com.github.spotbugs:spotbugs-annotations:4.10.2'
 
     testImplementation (
         'de.saly:javamail-mock2-fullmock:0.5-beta4',

core/src/main/java/org/mapfish/print/map/tiled/osm/OsmLayer.java

@@ -2,6 +2,7 @@
 
 import com.codahale.metrics.MetricRegistry;
 import jakarta.annotation.Nonnull;
+import jakarta.annotation.Nullable;
 import java.awt.Dimension;
 import java.awt.Rectangle;
 import java.io.IOException;
@@ -34,10 +35,10 @@ public final class OsmLayer extends AbstractTiledLayer<OsmLayerParam> {
    * @param configuration the configuration.
    */
   public OsmLayer(
-      @Nonnull final ForkJoinPool forkJoinPool,
-      @Nonnull final StyleSupplier<GridCoverage2D> styleSupplier,
+      @Nullable final ForkJoinPool forkJoinPool,
+      @Nullable final StyleSupplier<GridCoverage2D> styleSupplier,
       @Nonnull final OsmLayerParam param,
-      @Nonnull final MetricRegistry registry,
+      @Nullable final MetricRegistry registry,
       @Nonnull final Configuration configuration) {
     super(forkJoinPool, styleSupplier, param, registry, configuration);
     this.param = param;

core/src/main/java/org/mapfish/print/map/tiled/wms/TiledWmsLayer.java

@@ -2,6 +2,7 @@
 
 import com.codahale.metrics.MetricRegistry;
 import jakarta.annotation.Nonnull;
+import jakarta.annotation.Nullable;
 import java.awt.Dimension;
 import java.awt.Rectangle;
 import java.io.IOException;
@@ -38,10 +39,10 @@ public final class TiledWmsLayer extends AbstractTiledLayer<TiledWmsLayerParam>
    * @param configuration the configuration.
    */
   public TiledWmsLayer(
-      @Nonnull final ForkJoinPool forkJoinPool,
-      @Nonnull final StyleSupplier<GridCoverage2D> styleSupplier,
+      @Nullable final ForkJoinPool forkJoinPool,
+      @Nullable final StyleSupplier<GridCoverage2D> styleSupplier,
       @Nonnull final TiledWmsLayerParam param,
-      @Nonnull final MetricRegistry registry,
+      @Nullable final MetricRegistry registry,
       @Nonnull final Configuration configuration) {
     super(forkJoinPool, styleSupplier, param, registry, configuration);
     this.param = param;