update injected vars for sap_ha role

Author: marcelmamula

roles/sap_ha_pacemaker_cluster/tasks/include_vars/detect_platform_type.yml

@@ -5,37 +5,37 @@
 ### Facts already available to Ansible
 #
 ### Amazon Web Services EC2 Virtual Server. Not applicable for AWS Classic.
-# ansible_chassis_asset_tag: "Amazon EC2" # SMBIOS Chassis Asset Tag
-# ansible_board_asset_tag: "i-043d3c1a889ed9016" # SMBIOS Baseboard Asset Tag, ID of virtual machine on platform
-# ansible_chassis_vendor: "Amazon EC2"
-# ansible_product_name: "r5.8xlarge" # IaaS profile name
-# ansible_system_vendor: "Amazon EC2"
+# ansible_facts['chassis_asset_tag']: "Amazon EC2" # SMBIOS Chassis Asset Tag
+# ansible_facts['board_asset_tag']: "i-043d3c1a889ed9016" # SMBIOS Baseboard Asset Tag, ID of virtual machine on platform
+# ansible_facts['chassis_vendor']: "Amazon EC2"
+# ansible_facts['product_name']: "r5.8xlarge" # IaaS profile name
+# ansible_facts['system_vendor']: "Amazon EC2"
 #
 ### Google Cloud Compute Engine Virtual Machine.
-# ansible_chassis_asset_tag: "NA" # SMBIOS Chassis Asset Tag
-# ansible_board_asset_tag: "9EAF3038-7EF5-3F1E-6620-FB3BDA7A3709" # SMBIOS Baseboard Asset Tag, ID of virtual machine on platform
-# ansible_chassis_vendor: "Google"
-# ansible_product_name: "Google Compute Engine"
-# ansible_system_vendor: "Google"
+# ansible_facts['chassis_asset_tag']: "NA" # SMBIOS Chassis Asset Tag
+# ansible_facts['board_asset_tag']: "9EAF3038-7EF5-3F1E-6620-FB3BDA7A3709" # SMBIOS Baseboard Asset Tag, ID of virtual machine on platform
+# ansible_facts['chassis_vendor']: "Google"
+# ansible_facts['product_name']: "Google Compute Engine"
+# ansible_facts['system_vendor']: "Google"
 #
 ### IBM Cloud Virtual Server. Not applicable for IBM Cloud Classic Infrastructure.
-# ansible_chassis_asset_tag: "ibmcloud" # SMBIOS Chassis Asset Tag
-# ansible_board_asset_tag: "0c7d4459-xxxx-yyyy-zzzz-abcdefghijkl" # SMBIOS Baseboard Asset Tag, ID of virtual machine on platform
-# ansible_chassis_vendor: "IBM:Cloud Compute Server 1.0:mx2-16x128" # IaaS profile name as suffix (after colon)
-# ansible_product_name: "Standard PC (i440FX + PIIX, 1996)"
-# ansible_system_vendor: "QEMU"
+# ansible_facts['chassis_asset_tag']: "ibmcloud" # SMBIOS Chassis Asset Tag
+# ansible_facts['board_asset_tag']: "0c7d4459-xxxx-yyyy-zzzz-abcdefghijkl" # SMBIOS Baseboard Asset Tag, ID of virtual machine on platform
+# ansible_facts['chassis_vendor']: "IBM:Cloud Compute Server 1.0:mx2-16x128" # IaaS profile name as suffix (after colon)
+# ansible_facts['product_name']: "Standard PC (i440FX + PIIX, 1996)"
+# ansible_facts['system_vendor']: "QEMU"
 #
 ### Microsoft Azure Virtual Machine. Not applicable for MS Azure Classic/ASM.
-# ansible_chassis_asset_tag: "7783-xxxx-yyyy-zzzz-aaaa-bbbb-cc" # SMBIOS Chassis Asset Tag
-# ansible_board_asset_tag: "None" # SMBIOS Baseboard Asset Tag
-# ansible_chassis_vendor: "Microsoft Corporation"
-# ansible_product_name: "Virtual Machine"
-# ansible_system_vendor: "70f4a858-1eea-4c35-b9e1-e179c32fc6b5" # ID of virtual machine on platform
+# ansible_facts['chassis_asset_tag']: "7783-xxxx-yyyy-zzzz-aaaa-bbbb-cc" # SMBIOS Chassis Asset Tag
+# ansible_facts['board_asset_tag']: "None" # SMBIOS Baseboard Asset Tag
+# ansible_facts['chassis_vendor']: "Microsoft Corporation"
+# ansible_facts['product_name']: "Virtual Machine"
+# ansible_facts['system_vendor']: "70f4a858-1eea-4c35-b9e1-e179c32fc6b5" # ID of virtual machine on platform
 #
 ### VMware vSphere
-# ansible_product_name: "VMware7,1",
-# ansible_system_vendor: "VMware, Inc.",
-# ansible_virtualization_type: "VMware"
+# ansible_facts['product_name']: "VMware7,1",
+# ansible_facts['system_vendor']: "VMware, Inc.",
+# ansible_facts['virtualization_type']: "VMware"
 #
 ### End of comment
 
@@ -49,28 +49,28 @@
 
 - name: "SAP HA Prepare Pacemaker - Check if platform is Amazon Web Services EC2 Virtual Server"
   when:
-    - '"amazon" in ansible_system_vendor | lower
-      or "amazon" in ansible_product_name | lower
-      or "amazon" in ansible_product_version | lower'
+    - '"amazon" in ansible_facts["system_vendor"] | lower
+      or "amazon" in ansible_facts["product_name"] | lower
+      or "amazon" in ansible_facts["product_version"] | lower'
   ansible.builtin.set_fact:
     __sap_ha_pacemaker_cluster_platform: cloud_aws_ec2_vs
 
 - name: "SAP HA Prepare Pacemaker - Check if platform is Google Cloud Compute Engine Virtual Machine"
   when:
-    - ansible_product_name == 'Google Compute Engine'
+    - ansible_facts['product_name'] == 'Google Compute Engine'
   ansible.builtin.set_fact:
     __sap_ha_pacemaker_cluster_platform: cloud_gcp_ce_vm
 
 - name: "SAP HA Prepare Pacemaker - Check if platform is IBM Cloud Virtual Server"
   when:
-    - ansible_chassis_asset_tag == 'ibmcloud'
+    - ansible_facts['chassis_asset_tag'] == 'ibmcloud'
   ansible.builtin.set_fact:
     __sap_ha_pacemaker_cluster_platform: cloud_ibmcloud_vs
 
 - name: "SAP HA Prepare Pacemaker - Check if platform is Microsoft Azure Virtual Machine"
   when:
-    - ansible_product_name == 'Virtual Machine'
-    - ansible_chassis_vendor == 'Microsoft Corporation'
+    - ansible_facts['product_name'] == 'Virtual Machine'
+    - ansible_facts['chassis_vendor'] == 'Microsoft Corporation'
   ansible.builtin.set_fact:
     __sap_ha_pacemaker_cluster_platform: cloud_msazure_vm
 
@@ -80,13 +80,13 @@
   register: __sap_ha_pacemaker_cluster_power_rsct_check
   changed_when: false
   check_mode: false
-  when: ansible_architecture == "ppc64le"
+  when: ansible_facts['architecture'] == "ppc64le"
 
 - name: "SAP HA Prepare Pacemaker - Check if platform is IBM Power - Fail if RSCT binary is missing"
   ansible.builtin.fail:
     msg: Please install RSCT from IBM Power Systems service and productivity tools repository
   when:
-    - ansible_architecture == "ppc64le"
+    - ansible_facts['architecture'] == "ppc64le"
     - __sap_ha_pacemaker_cluster_power_rsct_check.stdout == ""
 
 - name: "SAP HA Prepare Pacemaker - Check if platform is IBM Power - Run 'ctgethscid'"
@@ -96,26 +96,26 @@
   changed_when: false
   check_mode: false
   when:
-    - ansible_architecture == "ppc64le"
+    - ansible_facts['architecture'] == "ppc64le"
     - __sap_ha_pacemaker_cluster_power_rsct_check.stdout != ""
 
 - name: "SAP HA Prepare Pacemaker - Check if platform is IBM Power Virtual Server from IBM Cloud"
   when:
-    - ansible_architecture == "ppc64le"
+    - ansible_facts['architecture'] == "ppc64le"
     - '"ibmcloud" in __sap_ha_pacemaker_cluster_power_rsct_hscid.stdout'
   ansible.builtin.set_fact:
     __sap_ha_pacemaker_cluster_platform: cloud_ibmcloud_powervs
 
 - name: "SAP HA Prepare Pacemaker - Check if platform is IBM PowerVM"
   when:
-    - ansible_architecture == "ppc64le"
+    - ansible_facts['architecture'] == "ppc64le"
     - '"ibmcloud" not in __sap_ha_pacemaker_cluster_power_rsct_hscid.stdout'
   ansible.builtin.set_fact:
     __sap_ha_pacemaker_cluster_platform: hyp_ibmpower_vm
 
 # - name: "SAP HA Prepare Pacemaker - Check if platform is VMware vSphere"
 #   when:
-#     - ansible_virtualization_type == 'VMware'
+#     - ansible_facts['virtualization_type'] == 'VMware'
 #   ansible.builtin.set_fact:
 #     __sap_ha_pacemaker_cluster_platform: hyp_vmware_vsphere_vm
 

roles/sap_ha_pacemaker_cluster/tasks/include_vars/include_common.yml

@@ -13,9 +13,9 @@
 # Assumption: The local loopback "lo" is always in the list.
 - name: "SAP HA Prepare Pacemaker - Set network interface name when only one interface is present"
   ansible.builtin.set_fact:
-    __sap_ha_pacemaker_cluster_vip_client_interface: "{{ ansible_default_ipv4.interface }}"
+    __sap_ha_pacemaker_cluster_vip_client_interface: "{{ ansible_facts['default_ipv4'].interface }}"
   when:
-    - ansible_interfaces | length <= 2
+    - ansible_facts['interfaces'] | length <= 2
     - sap_ha_pacemaker_cluster_vip_client_interface == ''
 
 
@@ -30,16 +30,16 @@
   loop: "{{ __var_files }}"
   vars:
     __vars_file: "{{ role_path }}/vars/{{ item }}"
-    __distribution_major: "{{ ansible_distribution ~ '_' ~ ansible_distribution_major_version }}"
-    __distribution_minor: "{{ ansible_distribution ~ '_' ~ ansible_distribution_version }}"
+    __distribution_major: "{{ ansible_facts['distribution'] ~ '_' ~ ansible_facts['distribution_major_version'] }}"
+    __distribution_minor: "{{ ansible_facts['distribution'] ~ '_' ~ ansible_facts['distribution_version'] }}"
     # Enables loading of shared vars between SLES and SLES_SAP
-    __distribution_major_split: "{{ ansible_distribution.split('_')[0] ~ '_' ~ ansible_distribution_major_version }}"
-    __distribution_minor_split: "{{ ansible_distribution.split('_')[0] ~ '_' ~ ansible_distribution_version }}"
+    __distribution_major_split: "{{ ansible_facts['distribution'].split('_')[0] ~ '_' ~ ansible_facts['distribution_major_version'] }}"
+    __distribution_minor_split: "{{ ansible_facts['distribution'].split('_')[0] ~ '_' ~ ansible_facts['distribution_version'] }}"
     __var_files: >-
       {{
         [
-          ansible_os_family ~ '.yml',
-          (ansible_distribution ~ '.yml') if ansible_distribution != ansible_os_family else None,
+          ansible_facts['os_family'] ~ '.yml',
+          (ansible_facts['distribution'] ~ '.yml') if ansible_facts['distribution'] != ansible_facts['os_family'] else None,
           (__distribution_major_split ~ '.yml') if __distribution_major_split != __distribution_major else None,
           (__distribution_minor_split ~ '.yml') if __distribution_minor_split != __distribution_minor else None,
           __distribution_major ~ '.yml',

roles/sap_ha_pacemaker_cluster/tasks/include_vars/include_hana.yml

@@ -74,7 +74,7 @@
         else sap_ha_pacemaker_cluster_hanacontroller_resource_name }}"
 
     __sap_ha_pacemaker_cluster_hanacontroller_resource_clone_name:
-      "{{ ('mst' if ansible_os_family == 'Suse' else 'cln') ~ '_SAPHanaCon_' ~ __sap_ha_pacemaker_cluster_hana_sid ~ '_HDB' ~ __sap_ha_pacemaker_cluster_hana_instance_nr
+      "{{ ('mst' if ansible_facts['os_family'] == 'Suse' else 'cln') ~ '_SAPHanaCon_' ~ __sap_ha_pacemaker_cluster_hana_sid ~ '_HDB' ~ __sap_ha_pacemaker_cluster_hana_instance_nr
         if sap_ha_pacemaker_cluster_hanacontroller_resource_clone_name | string | length == 0
         else sap_ha_pacemaker_cluster_hanacontroller_resource_clone_name }}"
 

roles/sap_ha_pacemaker_cluster/tasks/include_vars/include_platform.yml

@@ -16,7 +16,7 @@
   ansible.builtin.set_fact:
     __sap_ha_pacemaker_cluster_pcmk_host_map: |-
       {% for node in ansible_play_hosts_all -%}
-        {{ hostvars[node].ansible_hostname }}:{{ hostvars[node].ansible_board_asset_tag }}
+        {{ hostvars[node].ansible_facts['hostname'] }}:{{ hostvars[node].ansible_facts['board_asset_tag'] }}
       {%- if not loop.last %};{% endif %}
       {% endfor %}
   when: __sap_ha_pacemaker_cluster_platform == "cloud_aws_ec2_vs"
@@ -35,7 +35,7 @@
   ansible.builtin.set_fact:
     __sap_ha_pacemaker_cluster_pcmk_host_map: |-
       {% for node in ansible_play_hosts_all -%}
-        {{ hostvars[node].ansible_hostname }}:{{ hostvars[node].__sap_ha_pacemaker_cluster_register_ibmcloud_powervs_host.stdout }}
+        {{ hostvars[node].ansible_facts['hostname'] }}:{{ hostvars[node].__sap_ha_pacemaker_cluster_register_ibmcloud_powervs_host.stdout }}
       {%- if not loop.last %};{% endif %}
       {% endfor %}
   when: __sap_ha_pacemaker_cluster_platform == "cloud_ibmcloud_powervs"
@@ -55,7 +55,7 @@
   ansible.builtin.set_fact:
     __sap_ha_pacemaker_cluster_pcmk_host_map: |-
       {% for node in ansible_play_hosts_all -%}
-        {{ hostvars[node].ansible_hostname }}:{{ hostvars[node].sap_ha_pacemaker_cluster_ibmpower_vm_hmc_system_partition_name }}
+        {{ hostvars[node].ansible_facts['hostname'] }}:{{ hostvars[node].sap_ha_pacemaker_cluster_ibmpower_vm_hmc_system_partition_name }}
       {%- if not loop.last %};{% endif %}
       {% endfor %}
   when: __sap_ha_pacemaker_cluster_platform == "hyp_ibmpower_vm"
@@ -66,7 +66,7 @@
   ansible.builtin.set_fact:
     __sap_ha_pacemaker_cluster_pcmk_host_map: |-
       {% for node in ansible_play_hosts_all -%}
-        {{ hostvars[node].ansible_hostname }}:{{ hostvars[node].__sap_ha_pacemaker_cluster_register_ibmcloud_vs_host.stdout }}
+        {{ hostvars[node].ansible_facts['hostname'] }}:{{ hostvars[node].__sap_ha_pacemaker_cluster_register_ibmcloud_vs_host.stdout }}
       {%- if not loop.last %};{% endif %}
       {% endfor %}
   when: __sap_ha_pacemaker_cluster_platform == "cloud_ibmcloud_vs"
@@ -77,7 +77,7 @@
   ansible.builtin.set_fact:
     __sap_ha_pacemaker_cluster_pcmk_host_map: |-
       {% for node in ansible_play_hosts_all -%}
-        {{ hostvars[node].ansible_hostname }}:{{ hostvars[node].ansible_hostname }}
+        {{ hostvars[node].ansible_facts['hostname'] }}:{{ hostvars[node].ansible_facts['hostname'] }}
       {%- if not loop.last %};{% endif %}
       {% endfor %}
   when: __sap_ha_pacemaker_cluster_platform == "cloud_msazure_vm"

roles/sap_ha_pacemaker_cluster/tasks/include_vars/validate_input_parameters.yml

@@ -143,16 +143,16 @@
     fail_msg: |
       Multiple interfaces are found on the system.
 
-      {{ ansible_interfaces | to_nice_yaml }}
+      {{ ansible_facts['interfaces'] | to_nice_yaml }}
 
       In this case 'sap_ha_pacemaker_cluster_vip_client_interface' must be defined.
   when:
-    - ansible_interfaces | length > 2
+    - ansible_facts['interfaces'] | length > 2
 
 - name: "SAP HA Prepare Pacemaker - Verify that the custom NIC name exists"
   ansible.builtin.assert:
     that:
-      - sap_ha_pacemaker_cluster_vip_client_interface in ansible_interfaces
+      - sap_ha_pacemaker_cluster_vip_client_interface in ansible_facts['interfaces']
     fail_msg: "The interface '{{ sap_ha_pacemaker_cluster_vip_client_interface }}' does not exist on this system!"
   when:
     - sap_ha_pacemaker_cluster_vip_client_interface | length > 0

roles/sap_ha_pacemaker_cluster/tasks/pre_tasks/pre_nwas_cs_ers.yml

@@ -195,5 +195,5 @@
       else __sap_ha_pacemaker_cluster_nwas_ascs_sapinstance_instance_name
       }}"
   when:
-    - ansible_os_family == 'RedHat'
+    - ansible_facts['os_family'] == 'RedHat'
   ignore_errors: "{{ ansible_check_mode }}"

roles/sap_ha_pacemaker_cluster/tasks/prepare_vars/prepare_common.yml

@@ -37,8 +37,8 @@
     - not sap_ha_pacemaker_cluster_ha_cluster is defined
   ansible.builtin.set_fact:
     __sap_ha_pacemaker_cluster_ha_cluster:
-      node_name: "{{ ansible_hostname }}"
-      pcs_address: "{{ ansible_default_ipv4.address }}"
+      node_name: "{{ ansible_facts['hostname'] }}"
+      pcs_address: "{{ ansible_facts['default_ipv4'].address }}"
 
 
 # Combine following extra packages together:
@@ -61,7 +61,7 @@
       (sap_ha_pacemaker_cluster_zypper_patterns
       + __sap_ha_pacemaker_cluster_sap_zypper_patterns)
       | unique | select() }}"
-  when: ansible_os_family == 'Suse'
+  when: ansible_facts['os_family'] == 'Suse'
 
 # Combine following fence packages together:
 # __sap_ha_pacemaker_cluster_fence_agent_packages_minimal -> os default

roles/sap_ha_pacemaker_cluster/tasks/prepare_vars/prepare_final_hacluster_vars.yml

@@ -89,7 +89,7 @@
     ha_cluster_extra_packages: "{{ __sap_ha_pacemaker_cluster_extra_packages }}"
 
 - name: "SAP HA Prepare Pacemaker - (ha_cluster) Define parameter 'ha_cluster_zypper_patterns'"
-  when: __sap_ha_pacemaker_cluster_zypper_patterns is defined and ansible_os_family == 'Suse'
+  when: __sap_ha_pacemaker_cluster_zypper_patterns is defined and ansible_facts['os_family'] == 'Suse'
   ansible.builtin.set_fact:  # noqa var-naming[no-role-prefix]
     ha_cluster_zypper_patterns: "{{ __sap_ha_pacemaker_cluster_zypper_patterns }}"
 

roles/sap_ha_pacemaker_cluster/tasks/prepare_vars/prepare_hana_scaleup.yml

@@ -72,7 +72,7 @@
           attrs:
             # SUSE recommended monitor interval is 60
             - name: interval
-              value: "{{ 60 if ansible_os_family == 'Suse' else 59 }}"
+              value: "{{ 60 if ansible_facts['os_family'] == 'Suse' else 59 }}"
             - name: role
               value: Master
             - name: timeout
@@ -116,7 +116,7 @@
   ansible.builtin.set_fact:
     __sap_ha_pacemaker_cluster_hana_resource_clone_name: "{{ __sap_ha_pacemaker_cluster_hana_resource_clone_msl_name }}"
   when:
-    - ansible_os_family == 'Suse'
+    - ansible_facts['os_family'] == 'Suse'
 
 
 - name: "SAP HA Prepare Pacemaker - Add resource clone: SAP HANA DB"
@@ -142,7 +142,7 @@
               value: "true"
   when:
     - __clone_hana.resource_id not in (__sap_ha_pacemaker_cluster_resource_clones | map(attribute='resource_id'))
-    - ansible_os_family != 'Suse'
+    - ansible_facts['os_family'] != 'Suse'
 
 - name: "SAP HA Prepare Pacemaker - Add master slave resource clone: SAP HANA DB"
   ansible.builtin.set_fact:
@@ -167,7 +167,7 @@
       ms: true
   when:
     - __clone_hana.resource_id not in (__sap_ha_pacemaker_cluster_resource_clones | map(attribute='resource_id'))
-    - ansible_os_family == 'Suse'
+    - ansible_facts['os_family'] == 'Suse'
 
 # First start Topology, then HANA (automatically stops in reverse order)
 - name: "SAP HA Prepare Pacemaker - Add order constraint: Topology starts before DB"

roles/sap_ha_pacemaker_cluster/tasks/prepare_vars/prepare_nwas_abap_ascs_ers_simple_mount.yml

@@ -21,7 +21,7 @@
             - name: timeout
               value: 20s
             - name: interval
-              value: "{{ '120s' if ansible_os_family == 'Suse' else '0s' }}"
+              value: "{{ '120s' if ansible_facts['os_family'] == 'Suse' else '0s' }}"
             - name: enabled
               value: 'false'
   when:
@@ -45,7 +45,7 @@
             - name: timeout
               value: 20s
             - name: interval
-              value: "{{ '120s' if ansible_os_family == 'Suse' else '0s' }}"
+              value: "{{ '120s' if ansible_facts['os_family'] == 'Suse' else '0s' }}"
             - name: enabled
               value: 'false'
   when: