Skip to content

Commit 3e070b7

Browse files
committed
update linting config
1 parent e3a9102 commit 3e070b7

37 files changed

Lines changed: 54 additions & 588 deletions

.ansible-lint

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,26 @@
11
---
2-
# Collection wide lint-file
3-
# DO NOT CHANGE
2+
## Collection wide ansible-lint configuration file.
3+
# Changes for ansible-lint v25.7.0+
4+
# - Always executed from collection root using collection configuration.
5+
# - .ansible-lint-ignore can be used to ignore files, not folders.
6+
## Execution examples:
7+
# ansible-lint
8+
# ansible-lint roles/sap_swpm
9+
# ansible-lint roles/sap_install_media_detect -c roles/sap_install_media_detect/.ansible-lint
10+
411
exclude_paths:
512
- .ansible/
613
- .cache/
714
- .github/
8-
#- docs/
915
- changelogs/
1016
- playbooks/
11-
- roles/sap_anydb_install_oracle
12-
#- roles/sap_general_preconfigure
13-
#- roles/sap_ha_install_anydb_ibmdb2
14-
#- roles/sap_ha_install_hana_hsr
15-
#- roles/sap_ha_pacemaker_cluster
16-
#- roles/sap_hana_install
17-
#- roles/sap_hana_preconfigure
18-
#- roles/sap_hostagent
19-
#- roles/sap_install_media_detect
20-
#- roles/sap_netweaver_preconfigure
21-
#- roles/sap_storage_setup
22-
#- roles/sap_swpm
2317
- tests/
18+
# Roles that require linting validation
19+
- roles/sap_anydb_install_oracle
20+
2421
enable_list:
2522
- yaml
23+
2624
skip_list:
2725
# We don't want to enforce new Ansible versions for Galaxy:
2826
- meta-runtime[unsupported-version]

.github/workflows/ansible-lint-sap_general_preconfigure.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ jobs:
2929
# Avoid using @main, which can introduce breaking changes unexpectedly.
3030
- uses: ansible/ansible-lint@v25
3131
with:
32-
# Sets the linter's execution path to the specific role's directory.
33-
# Uses role specific .ansible-lint, if present.
34-
working_directory: ./roles/sap_general_preconfigure
32+
# v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
33+
# Role specific .ansible-lint can be added with argument '-c'.
34+
args: roles/sap_general_preconfigure
3535
# Use the shared requirements file from the collection root for dependency context.
36-
requirements_file: ../../requirements.yml
36+
requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_ha_install_hana_hsr.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ jobs:
2929
# Avoid using @main, which can introduce breaking changes unexpectedly.
3030
- uses: ansible/ansible-lint@v25
3131
with:
32-
# Sets the linter's execution path to the specific role's directory.
33-
# Uses role specific .ansible-lint, if present.
34-
working_directory: ./roles/sap_ha_install_hana_hsr
32+
# v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
33+
# Role specific .ansible-lint can be added with argument '-c'.
34+
args: roles/sap_ha_install_hana_hsr
3535
# Use the shared requirements file from the collection root for dependency context.
36-
requirements_file: ../../requirements.yml
36+
requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_ha_pacemaker_cluster.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ jobs:
2929
# Avoid using @main, which can introduce breaking changes unexpectedly.
3030
- uses: ansible/ansible-lint@v25
3131
with:
32-
# Sets the linter's execution path to the specific role's directory.
33-
# Uses role specific .ansible-lint, if present.
34-
working_directory: ./roles/sap_ha_pacemaker_cluster
32+
# v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
33+
# Role specific .ansible-lint can be added with argument '-c'.
34+
args: roles/sap_ha_pacemaker_cluster
3535
# Use the shared requirements file from the collection root for dependency context.
36-
requirements_file: ../../requirements.yml
36+
requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_hana_install.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ jobs:
2929
# Avoid using @main, which can introduce breaking changes unexpectedly.
3030
- uses: ansible/ansible-lint@v25
3131
with:
32-
# Sets the linter's execution path to the specific role's directory.
33-
# Uses role specific .ansible-lint, if present.
34-
working_directory: ./roles/sap_hana_install
32+
# v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
33+
# Role specific .ansible-lint can be added with argument '-c'.
34+
args: roles/sap_hana_install
3535
# Use the shared requirements file from the collection root for dependency context.
36-
requirements_file: ../../requirements.yml
36+
requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_hana_preconfigure.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ jobs:
2929
# Avoid using @main, which can introduce breaking changes unexpectedly.
3030
- uses: ansible/ansible-lint@v25
3131
with:
32-
args: roles/sap_hana_preconfigure -c roles/sap_hana_preconfigure/.ansible-lint
32+
# v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
33+
# Role specific .ansible-lint can be added with argument '-c'.
34+
args: roles/sap_hana_preconfigure
3335
# Use the shared requirements file from the collection root for dependency context.
3436
requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_install_media_detect.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ jobs:
2929
# Avoid using @main, which can introduce breaking changes unexpectedly.
3030
- uses: ansible/ansible-lint@v25
3131
with:
32-
# Sets the linter's execution path to the specific role's directory.
33-
# Uses role specific .ansible-lint, if present.
34-
working_directory: ./roles/sap_install_media_detect
32+
# v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
33+
# Role specific .ansible-lint can be added with argument '-c'.
34+
args: roles/sap_install_media_detect -c roles/sap_install_media_detect/.ansible-lint
3535
# Use the shared requirements file from the collection root for dependency context.
36-
requirements_file: ../../requirements.yml
36+
requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_maintain_etc_hosts.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ jobs:
2929
# Avoid using @main, which can introduce breaking changes unexpectedly.
3030
- uses: ansible/ansible-lint@v25
3131
with:
32-
# Sets the linter's execution path to the specific role's directory.
33-
# Uses role specific .ansible-lint, if present.
34-
working_directory: ./roles/sap_maintain_etc_hosts
32+
# v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
33+
# Role specific .ansible-lint can be added with argument '-c'.
34+
args: roles/sap_maintain_etc_hosts
3535
# Use the shared requirements file from the collection root for dependency context.
36-
requirements_file: ../../requirements.yml
36+
requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_netweaver_preconfigure.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ jobs:
2929
# Avoid using @main, which can introduce breaking changes unexpectedly.
3030
- uses: ansible/ansible-lint@v25
3131
with:
32-
# Sets the linter's execution path to the specific role's directory.
33-
# Uses role specific .ansible-lint, if present.
34-
working_directory: ./roles/sap_netweaver_preconfigure
32+
# v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
33+
# Role specific .ansible-lint can be added with argument '-c'.
34+
args: roles/sap_netweaver_preconfigure
3535
# Use the shared requirements file from the collection root for dependency context.
36-
requirements_file: ../../requirements.yml
36+
requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_storage_setup.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ jobs:
2929
# Avoid using @main, which can introduce breaking changes unexpectedly.
3030
- uses: ansible/ansible-lint@v25
3131
with:
32-
# Sets the linter's execution path to the specific role's directory.
33-
# Uses role specific .ansible-lint, if present.
34-
working_directory: ./roles/sap_storage_setup
32+
# v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
33+
# Role specific .ansible-lint can be added with argument '-c'.
34+
args: roles/sap_storage_setup
3535
# Use the shared requirements file from the collection root for dependency context.
36-
requirements_file: ../../requirements.yml
36+
requirements_file: ./requirements.yml

0 commit comments

Comments
 (0)