Merge pull request sap-linuxlab#1118 from marcelmamula/linting

collection: Update linting workflows and configuration to latest version

Author: marcelmamula

.ansible-lint

@@ -1,28 +1,26 @@
 ---
-# Collection wide lint-file
-# DO NOT CHANGE
+## Collection wide ansible-lint configuration file.
+# Changes for ansible-lint v25.7.0+
+# - Always executed from collection root using collection configuration.
+# - .ansible-lint-ignore can be used to ignore files, not folders.
+## Execution examples:
+# ansible-lint
+# ansible-lint roles/sap_swpm
+# ansible-lint roles/sap_install_media_detect -c roles/sap_install_media_detect/.ansible-lint
+
 exclude_paths:
   - .ansible/
   - .cache/
   - .github/
-  #- docs/
   - changelogs/
   - playbooks/
-  - roles/sap_anydb_install_oracle
-  #- roles/sap_general_preconfigure
-  #- roles/sap_ha_install_anydb_ibmdb2
-  #- roles/sap_ha_install_hana_hsr
-  #- roles/sap_ha_pacemaker_cluster
-  #- roles/sap_hana_install
-  #- roles/sap_hana_preconfigure
-  #- roles/sap_hostagent
-  #- roles/sap_install_media_detect
-  #- roles/sap_netweaver_preconfigure
-  #- roles/sap_storage_setup
-  #- roles/sap_swpm
   - tests/
+  # Roles which need to be excluded until their linting errors are resolved:
+  - roles/sap_anydb_install_oracle
+
 enable_list:
   - yaml
+
 skip_list:
   # We don't want to enforce new Ansible versions for Galaxy:
   - meta-runtime[unsupported-version]

.ansible-lint-ignore

@@ -0,0 +1,9 @@
+# This file is replacement for role specific .ansible-lint files with skip_list and warn_list.
+# Path has to point to a file because folders or wildcards are not accepted.
+
+# 'sap_install_media_detect' sets variables used by 'sap_swpm' and 'sap_hana_install'
+roles/sap_install_media_detect/tasks/set_global_vars.yml var-naming[no-role-prefix]
+roles/sap_install_media_detect/tasks/find_files_after_extraction.yml var-naming[no-role-prefix]
+
+# 'sap_ha_pacemaker_cluster' sets variables used by LSR role 'ha_cluster'.
+roles/sap_ha_pacemaker_cluster/tasks/construct_final_hacluster_vars.yml var-naming[no-role-prefix]

.github/workflows/ansible-lint-sap_general_preconfigure.yml

@@ -1,8 +1,5 @@
 ---
-
-# Workflow for ansible-lint of a role, using reusable workflow
-
-name: ansible-lint of the role sap_general_preconfigure
+name: Ansible Lint - sap_general_preconfigure
 
 on:
   push:
@@ -17,15 +14,23 @@ on:
       - dev
     paths:
       - 'roles/sap_general_preconfigure/**'
+
   workflow_dispatch:
-    branches:
-      - main
-      - dev
-    paths:
-      - 'roles/sap_general_preconfigure/**'
 
 jobs:
-  ansible-lint-exec:
-    uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
-    with:
-      role: sap_general_preconfigure
+  ansible-lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v5
+
+        # Use @v25 to automatically track the latest release from the year 2025.
+        # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH).
+        # Avoid using @main, which can introduce breaking changes unexpectedly.
+      - uses: ansible/ansible-lint@v25
+        with:
+          # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
+          # Role specific .ansible-lint can be added with argument '-c'.
+          args: roles/sap_general_preconfigure
+          # Use the shared requirements file from the collection root for dependency context.
+          requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_ha_install_hana_hsr.yml

@@ -1,8 +1,5 @@
 ---
-
-# Workflow for ansible-lint of a role, using reusable workflow
-
-name: ansible-lint of the role sap_ha_install_hana_hsr
+name: Ansible Lint - sap_ha_install_hana_hsr
 
 on:
   push:
@@ -17,15 +14,23 @@ on:
       - dev
     paths:
       - 'roles/sap_ha_install_hana_hsr/**'
+
   workflow_dispatch:
-    branches:
-      - main
-      - dev
-    paths:
-      - 'roles/sap_ha_install_hana_hsr/**'
 
 jobs:
-  ansible-lint-exec:
-    uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
-    with:
-      role: sap_ha_install_hana_hsr
+  ansible-lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v5
+
+        # Use @v25 to automatically track the latest release from the year 2025.
+        # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH).
+        # Avoid using @main, which can introduce breaking changes unexpectedly.
+      - uses: ansible/ansible-lint@v25
+        with:
+          # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
+          # Role specific .ansible-lint can be added with argument '-c'.
+          args: roles/sap_ha_install_hana_hsr
+          # Use the shared requirements file from the collection root for dependency context.
+          requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_ha_pacemaker_cluster.yml

@@ -1,8 +1,5 @@
 ---
-
-# Workflow for ansible-lint of a role, using reusable workflow
-
-name: ansible-lint of the role sap_ha_pacemaker_cluster
+name: Ansible Lint - sap_ha_pacemaker_cluster
 
 on:
   push:
@@ -17,15 +14,23 @@ on:
       - dev
     paths:
       - 'roles/sap_ha_pacemaker_cluster/**'
+
   workflow_dispatch:
-    branches:
-      - main
-      - dev
-    paths:
-      - 'roles/sap_ha_pacemaker_cluster/**'
 
 jobs:
-  ansible-lint-exec:
-    uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
-    with:
-      role: sap_ha_pacemaker_cluster
+  ansible-lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v5
+
+        # Use @v25 to automatically track the latest release from the year 2025.
+        # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH).
+        # Avoid using @main, which can introduce breaking changes unexpectedly.
+      - uses: ansible/ansible-lint@v25
+        with:
+          # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
+          # Role specific .ansible-lint can be added with argument '-c'.
+          args: roles/sap_ha_pacemaker_cluster
+          # Use the shared requirements file from the collection root for dependency context.
+          requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_hana_install.yml

@@ -1,8 +1,5 @@
 ---
-
-# Workflow for ansible-lint of a role, using reusable workflow
-
-name: ansible-lint of the role sap_hana_install
+name: Ansible Lint - sap_hana_install
 
 on:
   push:
@@ -17,15 +14,23 @@ on:
       - dev
     paths:
       - 'roles/sap_hana_install/**'
+
   workflow_dispatch:
-    branches:
-      - main
-      - dev
-    paths:
-      - 'roles/sap_hana_install/**'
 
 jobs:
-  ansible-lint-exec:
-    uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
-    with:
-      role: sap_hana_install
+  ansible-lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v5
+
+        # Use @v25 to automatically track the latest release from the year 2025.
+        # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH).
+        # Avoid using @main, which can introduce breaking changes unexpectedly.
+      - uses: ansible/ansible-lint@v25
+        with:
+          # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
+          # Role specific .ansible-lint can be added with argument '-c'.
+          args: roles/sap_hana_install
+          # Use the shared requirements file from the collection root for dependency context.
+          requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_hana_preconfigure.yml

@@ -1,8 +1,5 @@
 ---
-
-# Workflow for ansible-lint of a role, using reusable workflow
-
-name: ansible-lint of the role sap_hana_preconfigure
+name: Ansible Lint - sap_hana_preconfigure
 
 on:
   push:
@@ -17,15 +14,23 @@ on:
       - dev
     paths:
       - 'roles/sap_hana_preconfigure/**'
+
   workflow_dispatch:
-    branches:
-      - main
-      - dev
-    paths:
-      - 'roles/sap_hana_preconfigure/**'
 
 jobs:
-  ansible-lint-exec:
-    uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
-    with:
-      role: sap_hana_preconfigure
+  ansible-lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v5
+
+        # Use @v25 to automatically track the latest release from the year 2025.
+        # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH).
+        # Avoid using @main, which can introduce breaking changes unexpectedly.
+      - uses: ansible/ansible-lint@v25
+        with:
+          # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
+          # Role specific .ansible-lint can be added with argument '-c'.
+          args: roles/sap_hana_preconfigure
+          # Use the shared requirements file from the collection root for dependency context.
+          requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_install_media_detect.yml

@@ -1,8 +1,5 @@
 ---
-
-# Workflow for ansible-lint of a role, using reusable workflow
-
-name: ansible-lint of the role sap_install_media_detect
+name: Ansible Lint - sap_install_media_detect
 
 on:
   push:
@@ -17,15 +14,23 @@ on:
       - dev
     paths:
       - 'roles/sap_install_media_detect/**'
+
   workflow_dispatch:
-    branches:
-      - main
-      - dev
-    paths:
-      - 'roles/sap_install_media_detect/**'
 
 jobs:
-  ansible-lint-exec:
-    uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
-    with:
-      role: sap_install_media_detect
+  ansible-lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v5
+
+        # Use @v25 to automatically track the latest release from the year 2025.
+        # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH).
+        # Avoid using @main, which can introduce breaking changes unexpectedly.
+      - uses: ansible/ansible-lint@v25
+        with:
+          # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
+          # Role specific .ansible-lint can be added with argument '-c'.
+          args: roles/sap_install_media_detect
+          # Use the shared requirements file from the collection root for dependency context.
+          requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_maintain_etc_hosts.yml

@@ -1,8 +1,5 @@
 ---
-
-# Workflow for ansible-lint of a role, using reusable workflow
-
-name: ansible-lint of the role sap_maintain_etc_hosts
+name: Ansible Lint - sap_maintain_etc_hosts
 
 on:
   push:
@@ -17,15 +14,23 @@ on:
       - dev
     paths:
       - 'roles/sap_maintain_etc_hosts/**'
+
   workflow_dispatch:
-    branches:
-      - main
-      - dev
-    paths:
-      - 'roles/sap_maintain_etc_hosts/**'
 
 jobs:
-  ansible-lint-exec:
-    uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
-    with:
-      role: sap_maintain_etc_hosts
+  ansible-lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v5
+
+        # Use @v25 to automatically track the latest release from the year 2025.
+        # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH).
+        # Avoid using @main, which can introduce breaking changes unexpectedly.
+      - uses: ansible/ansible-lint@v25
+        with:
+          # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
+          # Role specific .ansible-lint can be added with argument '-c'.
+          args: roles/sap_maintain_etc_hosts
+          # Use the shared requirements file from the collection root for dependency context.
+          requirements_file: ./requirements.yml

.github/workflows/ansible-lint-sap_netweaver_preconfigure.yml

@@ -1,8 +1,5 @@
 ---
-
-# Workflow for ansible-lint of a role, using reusable workflow
-
-name: ansible-lint of the role sap_netweaver_preconfigure
+name: Ansible Lint - sap_netweaver_preconfigure
 
 on:
   push:
@@ -17,15 +14,23 @@ on:
       - dev
     paths:
       - 'roles/sap_netweaver_preconfigure/**'
+
   workflow_dispatch:
-    branches:
-      - main
-      - dev
-    paths:
-      - 'roles/sap_netweaver_preconfigure/**'
 
 jobs:
-  ansible-lint-exec:
-    uses: sap-linuxlab/community.sap_install/.github/workflows/ansible-lint-sap_reusable_workflow.yml@main
-    with:
-      role: sap_netweaver_preconfigure
+  ansible-lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v5
+
+        # Use @v25 to automatically track the latest release from the year 2025.
+        # ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH).
+        # Avoid using @main, which can introduce breaking changes unexpectedly.
+      - uses: ansible/ansible-lint@v25
+        with:
+          # v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
+          # Role specific .ansible-lint can be added with argument '-c'.
+          args: roles/sap_netweaver_preconfigure
+          # Use the shared requirements file from the collection root for dependency context.
+          requirements_file: ./requirements.yml