fix linting errors in 2.20 with facts and register var names

Author: marcelmamula

roles/sap_general_preconfigure/tasks/SLES/assert-installation.yml

@@ -95,9 +95,9 @@
      ([ -f /var/run/zypp.pid ] && [ -s /var/run/zypp.pid ]); do
       sleep 10;
     done'
-  register: __packagekit_service_check
+  register: __sap_general_preconfigure_register_packagekit
   changed_when: false
-  until: __packagekit_service_check.rc == 0
+  until: __sap_general_preconfigure_register_packagekit.rc == 0
   retries: 60
   when: "'packagekit.service' in ansible_facts.services"
 

roles/sap_general_preconfigure/tasks/SLES/installation.yml

@@ -22,9 +22,9 @@
      ([ -f /var/run/zypp.pid ] && [ -s /var/run/zypp.pid ]); do
       sleep 10;
     done'
-  register: __packagekit_service_check
+  register: __sap_general_preconfigure_register_packagekit
   changed_when: false
-  until: __packagekit_service_check.rc == 0
+  until: __sap_general_preconfigure_register_packagekit.rc == 0
   retries: 60
   when: "'packagekit.service' in ansible_facts.services"
 

roles/sap_hana_preconfigure/tasks/SLES/assert-installation.yml

@@ -58,9 +58,9 @@
      ([ -f /var/run/zypp.pid ] && [ -s /var/run/zypp.pid ]); do
       sleep 10;
     done'
-  register: __packagekit_service_check
+  register: __sap_hana_preconfigure_register_packagekit
   changed_when: false
-  until: __packagekit_service_check.rc == 0
+  until: __sap_hana_preconfigure_register_packagekit.rc == 0
   retries: 60
   when: "'packagekit.service' in ansible_facts.services"
 

roles/sap_hana_preconfigure/tasks/SLES/installation.yml

@@ -22,9 +22,9 @@
      ([ -f /var/run/zypp.pid ] && [ -s /var/run/zypp.pid ]); do
       sleep 10;
     done'
-  register: __packagekit_service_check
+  register: __sap_hana_preconfigure_register_packagekit
   changed_when: false
-  until: __packagekit_service_check.rc == 0
+  until: __sap_hana_preconfigure_register_packagekit.rc == 0
   retries: 60
   when: "'packagekit.service' in ansible_facts.services"
 

roles/sap_netweaver_preconfigure/tasks/SLES/assert-installation.yml

@@ -56,9 +56,9 @@
      ([ -f /var/run/zypp.pid ] && [ -s /var/run/zypp.pid ]); do
       sleep 10;
     done'
-  register: __packagekit_service_check
+  register: __sap_netweaver_preconfigure_register_packagekit
   changed_when: false
-  until: __packagekit_service_check.rc == 0
+  until: __sap_netweaver_preconfigure_register_packagekit.rc == 0
   retries: 60
   when: "'packagekit.service' in ansible_facts.services"
 

roles/sap_netweaver_preconfigure/tasks/SLES/installation.yml

@@ -22,9 +22,9 @@
      ([ -f /var/run/zypp.pid ] && [ -s /var/run/zypp.pid ]); do
       sleep 10;
     done'
-  register: __packagekit_service_check
+  register: __sap_netweaver_preconfigure_register_packagekit
   changed_when: false
-  until: __packagekit_service_check.rc == 0
+  until: __sap_netweaver_preconfigure_register_packagekit.rc == 0
   retries: 60
   when: "'packagekit.service' in ansible_facts.services"
 

roles/sap_storage_setup/tasks/generic_tasks/configure_local_filesystems.yml

@@ -8,7 +8,7 @@
     pesize: "{{ vg_item.pesize }}"
     vg_options: "{{ vg_item.vg_opts }}"
     pv_options: "{{ vg_item.pv_opts }}"
-  loop: "{{ volume_map }}"
+  loop: "{{ __sap_storage_setup_fact_volume_map }}"
   loop_control:
     loop_var: vg_item
     label: "{{ vg_item.volume_group }}"
@@ -21,7 +21,7 @@
     size: 100%VG
     state: present
     opts: "{{ lv_item.lv_opts }}"
-  loop: "{{ volume_map }}"
+  loop: "{{ __sap_storage_setup_fact_volume_map }}"
   loop_control:
     loop_var: lv_item
     label: "{{ lv_item.volume_name }}"
@@ -32,7 +32,7 @@
   community.general.filesystem:
     fstype: "{{ fs_item.filesystem_type }}"
     dev: "/dev/{{ fs_item.volume_group }}/{{ fs_item.volume_name }}"
-  loop: "{{ volume_map }}"
+  loop: "{{ __sap_storage_setup_fact_volume_map }}"
   loop_control:
     loop_var: fs_item
     label: "{{ fs_item.volume_name }}"
@@ -45,7 +45,7 @@
     src: "/dev/{{ mnt_item.volume_group }}/{{ mnt_item.volume_name }}"
     fstype: "{{ mnt_item.filesystem_type }}"
     state: mounted # performs fstab entry and mount
-  loop: "{{ volume_map }}"
+  loop: "{{ __sap_storage_setup_fact_volume_map }}"
   loop_control:
     loop_var: mnt_item
     label: "{{ mnt_item.volume_name }}"

roles/sap_storage_setup/tasks/generic_tasks/configure_multipathing.yml

@@ -39,11 +39,11 @@
 # - no "links.uuids"
 # - no "partitions"
 # - "wwn" defined
-# - "size" matching any of the filesystems defined in {{ sap_storage_setup_new_mounts_fact }}
+# - "size" matching any of the filesystems defined in {{ __sap_storage_setup_fact_new_mounts }}
 
 - name: SAP Storage Setup - (Multipathing) Make a list of unused WWNs of the requested sizes
   ansible.builtin.set_fact:
-    available_devices_multipath: |
+    __sap_storage_setup_fact_available_devices_multipath: |
       {% set av_disks = [] %}
       {% set all_disks = (ansible_devices | dict2items) %}
       {% for disk in all_disks %}
@@ -52,7 +52,7 @@
             and disk.value.partitions | length == 0
             and disk.value.holders | length == 0
             %}
-          {%- for fs in sap_storage_setup_new_mounts_fact %}
+          {%- for fs in __sap_storage_setup_fact_new_mounts %}
             {%- if fs.disk_size is defined
                 and (fs.disk_size | string + 'GB') in (disk.value.size | regex_replace('(\.\d+\s*)', '')) %}
               {%- set add_to_list = av_disks.append(disk) %}
@@ -68,7 +68,7 @@
 # !!
 
 # This task assigns device names for each volume to be created.
-# - sap_storage_setup_new_mounts_fact derived from extravars: sap_storage_setup_definition
+# - __sap_storage_setup_fact_new_mounts derived from extravars: sap_storage_setup_definition
 #   and is dynamically generated during runtime to list only unconfigured filesystems
 # - ansible facts: ansible-devices
 
@@ -77,13 +77,14 @@
 
 - name: SAP Storage Setup - (Multipathing) Set fact for target filesystem device mapping
   ansible.builtin.set_fact:
-    filesystem_device_map: "{{ filesystem_device_map | default([]) + __multipath_to_fs_device_map }}"
+    __sap_storage_setup_fact_filesystem_device_map:
+      "{{ __sap_storage_setup_fact_filesystem_device_map | default([]) + __multipath_to_fs_device_map }}"
   vars:
     __multipath_to_fs_device_map: |
       {% set device_map = [] %}
-      {% set av_dev = (available_devices_multipath | dict2items) %}
+      {% set av_dev = (__sap_storage_setup_fact_available_devices_multipath | dict2items) %}
       {% set assigned_dev = [] %}
-      {% for fs in sap_storage_setup_new_mounts_fact -%}
+      {% for fs in __sap_storage_setup_fact_new_mounts -%}
         {% set matching_dev = [] -%}
 
         {%- if fs.disk_size is defined

roles/sap_storage_setup/tasks/generic_tasks/configure_nfs_filesystems.yml

@@ -16,25 +16,25 @@
 # Make sure paths and mountpoints are stripped from trailing '/'.
 # The '/' is added explicitly to the constructed paths.
 
-# Parameter: sap_storage_setup_related_directories
+# Parameter: __sap_storage_setup_fact_related_directories
 # Param Type: list of dictionaries
 #
 # Debug sample for a node of host type 'nwas_abap_ascs':
 #
-# sap_storage_setup_related_directories:
+# __sap_storage_setup_fact_related_directories:
 #		- dir_only: /DB1
 #			mount_src: /my_dir/sapmnt
 #			mountpoint: /sapmnt
 #
-# sap_storage_setup_related_directories:
+# __sap_storage_setup_fact_related_directories:
 #   - mount_src: /my_dir/usr/sap/DB1/SYS
 #     mountpoint: /usr/sap/DB1/SYS
 #   - mount_src: /my_dir/usr/sap/DB1/ASCS00
 #     mountpoint: /usr/sap/DB1/ASCS00
 
 - name: SAP Storage Setup - ({{ nfs_item.name }}) Set fact for directories
   ansible.builtin.set_fact:
-    sap_storage_setup_related_directories: |
+    __sap_storage_setup_fact_related_directories: |
       {% set mount_list = [] %}
 
       {%- if nfs_item.mountpoint | regex_replace('/$', '') == '/sapmnt' -%}
@@ -136,7 +136,7 @@
       ansible.builtin.stat:
         path: "{{ sap_storage_setup_tmpnfs_register.path }}{{ stat_item.mountpoint }}{{ stat_item.dir_only | default('') }}"
       register: sap_storage_setup_nfs_dir_register
-      loop: "{{ sap_storage_setup_related_directories }}"
+      loop: "{{ __sap_storage_setup_fact_related_directories }}"
       loop_control:
         loop_var: stat_item
         label: "{{ stat_item.mountpoint }}{{ stat_item.dir_only | default('') }}"
@@ -193,7 +193,7 @@
     fstype: "{{ nfs_item.nfs_filesystem_type | default(sap_storage_setup_nfs_filesystem_type) }}"
     opts: "{{ nfs_item.nfs_mount_options | default(sap_storage_setup_nfs_mount_options) }}"
     state: mounted
-  loop: "{{ sap_storage_setup_related_directories }}"
+  loop: "{{ __sap_storage_setup_fact_related_directories }}"
   loop_control:
     loop_var: mount_item
     label: "{{ mount_item.mountpoint }}"

roles/sap_storage_setup/tasks/generic_tasks/configure_swap.yml

@@ -26,14 +26,14 @@
     - name: SAP Storage Setup - (swap file) Check if file exists
       ansible.builtin.stat:
         path: "{{ swap_file.swap_path }}"
-      register: check_swapfile
+      register: __sap_storage_setup_register_check_swapfile
 
     - name: SAP Storage Setup - (swap file) Allocate space
       ansible.builtin.shell: |
         fallocate -l {{ swap_file.disk_size | int * 1024 }}MB {{ swap_file.swap_path }}
       changed_when: true
       when:
-        - not check_swapfile.stat.exists
+        - not __sap_storage_setup_register_check_swapfile.stat.exists
 
     - name: SAP Storage Setup - (swap file) Adjust file permissions
       ansible.builtin.file:
@@ -46,7 +46,7 @@
         swapon {{ swap_file.swap_path }}
       changed_when: true
       when:
-        - not check_swapfile.stat.exists
+        - not __sap_storage_setup_register_check_swapfile.stat.exists
 
     - name: SAP Storage Setup - (swap file) Add fstab entry
       ansible.posix.mount:
@@ -86,7 +86,7 @@
     - name: SAP Storage Setup - Check if swap partition exists
       ansible.builtin.shell: |
         set -o pipefail && lsblk | grep SWAP || echo "no active swap"
-      register: check_swap_partition
+      register: __sap_storage_setup_register_check_swap_partition
       changed_when: false
 
     - name: SAP Storage Setup - Add fstab entry for swap
@@ -103,6 +103,6 @@
       changed_when: true
       when:
         - not ansible_check_mode
-        - swap_volume.lvm_lv_name | default("lv_swap") not in check_swap_partition.stdout
+        - swap_volume.lvm_lv_name | default("lv_swap") not in __sap_storage_setup_register_check_swap_partition.stdout
 
 ### End of block: swap filesystem