optional max width for popups to prevent new hash like column calculation from infinitely expanding popup windows

Author: jkukatzki

crates/bevy_animation_graph_editor/src/ui/generic_widgets/data_value.rs

@@ -81,9 +81,13 @@ impl<'a> egui::Widget for DataValueWidget<'a> {
                     response |= ui.add(EntityPathWidget::new_salted(entity_path, "entity path"));
                 }
                 DataValue::BoneMask(bone_mask) => {
-                    response |= PopupWidget::new_salted("bone mask popup").ui(ui, |ui| {
-                        ui.add(BoneMaskWidget::new(bone_mask).with_skeleton(self.skeleton))
-                    });
+                    response |= PopupWidget::new_salted("bone mask popup")
+                        .with_max_width(500.)
+                        .ui(ui, |ui| {
+                            ui.add(
+                                BoneMaskWidget::new(bone_mask).with_skeleton(self.skeleton),
+                            )
+                        });
                 }
                 DataValue::Pose(_) => {
                     response |= ui.label("Pose value editing not supported");

crates/bevy_animation_graph_editor/src/ui/generic_widgets/entity_path.rs

@@ -47,7 +47,8 @@ impl<'a> egui::Widget for EntityPathWidget<'a> {
             });
 
             let response = ui.add(
-                egui::TextEdit::singleline(&mut buffer.value).min_size(egui::Vec2::new(350., 0.)),
+                egui::TextEdit::singleline(&mut buffer.value)
+                    .desired_width(ui.available_width()),
             );
 
             let top_k = self

crates/bevy_animation_graph_editor/src/ui/generic_widgets/popup.rs

@@ -3,33 +3,47 @@ use egui::containers::menu::MenuConfig;
 pub struct PopupWidget {
     pub id_hash: egui::Id,
     pub button_label: String,
+    pub max_width: Option<f32>,
 }
 
 impl PopupWidget {
     pub fn new_salted(salt: impl std::hash::Hash) -> Self {
         Self {
             id_hash: egui::Id::new(salt),
             button_label: "edit".into(),
+            max_width: None,
         }
     }
 
+    pub fn with_max_width(mut self, max_width: f32) -> Self {
+        self.max_width = Some(max_width);
+        self
+    }
+
     pub fn ui(
         self,
         ui: &mut egui::Ui,
         inner: impl FnOnce(&mut egui::Ui) -> egui::Response,
     ) -> egui::Response {
+        let max_width = self.max_width;
+        let wrapped_inner = move |ui: &mut egui::Ui| -> egui::Response {
+            if let Some(w) = max_width {
+                ui.set_max_width(w);
+            }
+            inner(ui)
+        };
         ui.push_id(self.id_hash, |ui| {
             ui.horizontal(|ui| {
                 let config =
                     MenuConfig::new().close_behavior(egui::PopupCloseBehavior::CloseOnClickOutside);
                 let (mut button_response, inner) = if egui::containers::menu::is_in_menu(ui) {
                     egui::containers::menu::SubMenuButton::new(&self.button_label)
                         .config(config)
-                        .ui(ui, inner)
+                        .ui(ui, wrapped_inner)
                 } else {
                     egui::containers::menu::MenuButton::new(&self.button_label)
                         .config(config)
-                        .ui(ui, inner)
+                        .ui(ui, wrapped_inner)
                 };
 
                 if inner.is_some_and(|i| i.inner.changed()) {

crates/bevy_animation_graph_editor/src/ui/generic_widgets/ragdoll_config.rs

@@ -43,6 +43,7 @@ impl<'a> egui::Widget for RagdollConfigWidget<'a> {
             let mut response = ui.button("Edit");
             let popup_response = egui::Popup::from_toggle_button_response(&response)
                 .close_behavior(egui::PopupCloseBehavior::IgnoreClicks)
+                .width(500.)
                 .show(|ui| {
                     let mut response = ui.heading("Defaults");
                     ui.horizontal(|ui| {

crates/bevy_animation_graph_editor/src/ui/generic_widgets/uuid.rs

@@ -46,7 +46,8 @@ impl<'a> egui::Widget for UuidWidget<'a> {
             });
 
             let mut response = ui.add(
-                egui::TextEdit::singleline(&mut data.buffer).min_size(egui::Vec2::new(250., 0.)),
+                egui::TextEdit::singleline(&mut data.buffer)
+                    .desired_width(ui.available_width()),
             );
 
             // Mark non-changed; we only consider the response changed if the uuid string is valid