Skip to content

Review workflows that only run on pull requests against main #1872

Description

@caugner

Summary

Several workflows across the MDN org restrict pull_request triggers to branches: [main], e.g. PR Test in mdn/translated-content:

on:
  pull_request:
    branches:
      - main

This prevents the workflow from running on stacked PRs (PRs that target another PR's branch instead of main). Since these workflows typically compute their diff from the PR's own base and head SHAs, the filter seems unnecessary and may be unintentional.

Example

mdn/translated-content#38394 targets another branch, so PR Test never ran, and hence PR review companion never deployed a preview. Lint content (no branch filter) ran as expected.

Proposal

Review the pull_request triggers across MDN repos (mdn/content, mdn/translated-content, mdn/fred, mdn/rari, mdn/yari, mdn/workflows, ...) and drop the branches: [main] filter where the workflow does not actually depend on the base branch.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

p1We will address this soon and will provide capacity from our team for it in the next few releases.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions