Adding test to existing file: Test with id /path/to/test/file.R&[object Object] could not be found.

[katrinabrock]

Repro steps:

• Run tests from the sidebar by clicking the play button that runs a file.
• Add a test to that file.
• Again click the play button that runs all tests in file (not individual tests).

Expected result: both tests run
Actual result: First test runs successfully. Second test doesn't run (from what I can tell). File is reported as failing with Test with id /path/to/test/file.R&[object Object] could not be found.

Video of issue:
https://github.com/user-attachments/assets/8227d538-98b3-4eb4-8f9b-f3eadc0a937e

Test file in question with surrounding repo can be found here:
https://github.com/katrinabrock/minimal-r-package/blob/main/tests/testthat/test-passes.R

[katrinabrock]

I did some more digging. This happens when there are warnings or errors outside of a test_that(...) block.

in that case, no test or context are passed into add_result method and the result looks something like this:

List of 6
 $ message    : chr "The `code` argument to `test_that()` must be a braced expression to get accurate file-line information for failures."
 $ srcref     : 'srcref' int [1:8] 3 1 3 39 1 39 3 3
  ..- attr(*, "srcfile")=Classes 'srcfilecopy', 'srcfile' <environment: 0x55b7041aab38> 
 $ trace      :Classes ‘rlang_trace’, ‘rlib_trace’, ‘tbl’ and 'data.frame':     1 obs. of  5 variables:
  ..$ call     :List of 1
  .. ..$ : language test_that("Test #1", expect_true(TRUE))
  .. .. ..- attr(*, "srcref")= 'srcref' int [1:8] 3 1 3 39 1 39 3 3
  .. .. .. ..- attr(*, "srcfile")=Classes 'srcfilecopy', 'srcfile' <environment: 0x55b7041aab38> 
  ..$ parent   : int 0
  ..$ visible  : logi TRUE
  ..$ namespace: chr "testthat"
  ..$ scope    : chr "::"
  ..- attr(*, "version")= int 2
 $ start_frame: int 27
 $ end_frame  : num 28
 $ test       : chr "(code run outside of `test_that()`)"
 - attr(*, "class")= chr [1:3] "expectation_warning" "expectation" "condition"

The the VScodeReporter emits and undefined test like this:

{"type":"add_result","context":{},"test":{},"result":"warning","location":"test-passes.R:3:1","filename":"test-passes.R"}

Which then hits this condition:
https://github.com/meakbiyik/vscode-r-test-adapter/blob/master/src/testthat/runner.ts#L112

[meakbiyik]

Dear Katrina, thanks a lot for the detailed report! I will check it out as soon as possible, just a bit busy these days.