fix(dashboard): don't mark promotions with per-attribute campaign budgets as expired (#16018)

## What
Stop the dashboard from showing a red "Campaign expired" badge on active promotions whose campaign uses a per-attribute budget (`use_by_attribute` / `spend_by_attribute`).

Fixes #15960

## Why
`getPromotionStatus` compares `campaignBudget.used > campaignBudget.limit` without looking at the budget type. For per-attribute budgets, `used` is the aggregate across all attribute values (e.g. every customer email) while `limit` applies to each attribute value individually, so the comparison is meaningless — as soon as more distinct customers than the per-customer limit use the promotion, the list and detail views flag it as expired even though the backend keeps redeeming it correctly. Display-only bug, exactly as the reporter diagnosed.

## How
Skip the over-budget check when the budget type is `use_by_attribute` or `spend_by_attribute` (same string-literal comparison the dashboard already uses elsewhere, e.g. the campaign detail widgets). Global `spend`/`usage` budgets and the `ends_at` check behave exactly as before.

## Testing
Added `src/lib/__tests__/promotions.spec.ts` covering: per-attribute budgets over the per-value "limit" stay active (both types — these two fail on current develop and pass with the fix), global `usage` budgets over the limit still show expired, and an ended campaign shows expired regardless of budget type. Ran with vitest in the dashboard workspace, plus eslint on the changed files. Changeset included (patch, `@medusajs/dashboard`).

Author: MahinAnowar

.changeset/fix-promotion-status-per-attribute-budget.md

@@ -0,0 +1,5 @@
+---
+"@medusajs/dashboard": patch
+---
+
+fix(dashboard): don't mark promotions with per-attribute campaign budgets as expired

packages/admin/dashboard/src/lib/__tests__/promotions.spec.ts

@@ -0,0 +1,81 @@
+import { HttpTypes } from "@medusajs/types"
+import i18next from "i18next"
+import { describe, expect, it } from "vitest"
+
+// promotionStatusMap resolves its labels through i18n.t at module load, so
+// i18next has to be initialized before the module under test is imported.
+await i18next.init({ lng: "en", fallbackLng: "en", resources: {} })
+
+const { getPromotionStatus, promotionStatusMap, PromotionStatus } =
+  await import("../promotions")
+
+const buildPromotion = (
+  campaign: Partial<HttpTypes.AdminCampaign>
+): HttpTypes.AdminPromotion =>
+  ({
+    status: "active",
+    campaign: {
+      starts_at: null,
+      ends_at: null,
+      ...campaign,
+    },
+  } as HttpTypes.AdminPromotion)
+
+describe("getPromotionStatus", () => {
+  it("should not mark a promotion as expired when a use_by_attribute budget's aggregate usage exceeds the per-attribute limit", () => {
+    const promotion = buildPromotion({
+      budget: {
+        type: "use_by_attribute",
+        limit: 1,
+        used: 5,
+      } as HttpTypes.AdminCampaign["budget"],
+    })
+
+    expect(getPromotionStatus(promotion)).toEqual(
+      promotionStatusMap[PromotionStatus.ACTIVE]
+    )
+  })
+
+  it("should not mark a promotion as expired when a spend_by_attribute budget's aggregate usage exceeds the per-attribute limit", () => {
+    const promotion = buildPromotion({
+      budget: {
+        type: "spend_by_attribute",
+        limit: 100,
+        used: 500,
+      } as HttpTypes.AdminCampaign["budget"],
+    })
+
+    expect(getPromotionStatus(promotion)).toEqual(
+      promotionStatusMap[PromotionStatus.ACTIVE]
+    )
+  })
+
+  it("should mark a promotion as expired when a global budget is exceeded", () => {
+    const promotion = buildPromotion({
+      budget: {
+        type: "usage",
+        limit: 1,
+        used: 5,
+      } as HttpTypes.AdminCampaign["budget"],
+    })
+
+    expect(getPromotionStatus(promotion)).toEqual(
+      promotionStatusMap[PromotionStatus.EXPIRED]
+    )
+  })
+
+  it("should mark a promotion as expired when its campaign has ended, regardless of budget type", () => {
+    const promotion = buildPromotion({
+      ends_at: "2020-01-01T00:00:00.000Z",
+      budget: {
+        type: "use_by_attribute",
+        limit: 1,
+        used: 0,
+      } as HttpTypes.AdminCampaign["budget"],
+    })
+
+    expect(getPromotionStatus(promotion)).toEqual(
+      promotionStatusMap[PromotionStatus.EXPIRED]
+    )
+  })
+})

packages/admin/dashboard/src/lib/promotions.ts

@@ -42,8 +42,15 @@ export const getPromotionStatus = (promotion: HttpTypes.AdminPromotion) => {
   }
 
   const campaignBudget = campaign.budget
+  // For per-attribute budgets, `used` aggregates usage across all attribute
+  // values while `limit` applies to each attribute value individually, so
+  // comparing them cannot tell whether the budget is exhausted.
+  const isPerAttributeBudget =
+    campaignBudget?.type === "use_by_attribute" ||
+    campaignBudget?.type === "spend_by_attribute"
   const overBudget =
     campaignBudget &&
+    !isPerAttributeBudget &&
     campaignBudget.limit &&
     campaignBudget.used! > campaignBudget.limit!