Commit 01f31bc
authored
fix(product): delete individual variant metadata fields (#16179)
## Summary
**What:** Fix variant metadata updates so an individual field can be deleted without removing or overwriting the remaining fields.
**Why:** `ProductModuleService.updateVariants_` uses `upsertWithReplace`, which bypassed the `mergeMetadata` behavior used by other metadata update paths. As a result, an empty-string value was persisted instead of deleting the key.
**How:** Merge incoming variant metadata with the persisted metadata before calling `upsertWithReplace`. This preserves unspecified keys and removes keys whose incoming value is an empty string. The change includes unit and integration regression coverage plus a patch changeset.
**Testing**
- Product module TypeScript build passes.
- Product module unit suite passes: 2 tests, 2 passed.
- Targeted ESLint checks pass for the implementation and tests.
- The new tests and changeset pass Prettier; `git diff --check` passes.
- Added PostgreSQL-backed integration coverage for the exact multi-field deletion scenario; it will run in CI because PostgreSQL is not available in the local environment.
---
## Examples
```ts
await productModuleService.updateProductVariants(variant.id, {
metadata: {
obsolete: "",
},
})
```
The `obsolete` key is removed while all other metadata fields remain unchanged.
---
## Checklist
- [x] I have added a **changeset** for this PR
- [x] The changes are covered by relevant **tests**
- [x] I have verified the code works as intended locally
- [x] I have linked the related issue(s) if applicable
---
## Additional Context
Fixes #16163.1 parent a42ee08 commit 01f31bc
4 files changed
Lines changed: 104 additions & 5 deletions
File tree
- .changeset
- packages/modules/product
- integration-tests/__tests__/product-module-service
- src/services
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Lines changed: 23 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
444 | 444 | | |
445 | 445 | | |
446 | 446 | | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
447 | 470 | | |
448 | 471 | | |
449 | 472 | | |
| |||
Lines changed: 58 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
Lines changed: 18 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
47 | 48 | | |
48 | 49 | | |
49 | 50 | | |
| |||
659 | 660 | | |
660 | 661 | | |
661 | 662 | | |
662 | | - | |
663 | | - | |
664 | | - | |
665 | | - | |
666 | | - | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
667 | 680 | | |
668 | 681 | | |
669 | 682 | | |
| |||
0 commit comments