fixes

Author: shahednasser

.claude/skills/triaging-issues/SKILL.md

@@ -101,7 +101,9 @@ Rules:
 ### Comment template mapping
 
 The category flow in the reference files describes the wording of comments
-to post. Map the **intent** of that comment to one of the templates below:
+to post. Map the **intent** of that comment to one of the seven templates
+below (four "stay open" templates and three `close-*` templates):
+
 | Reference flow says to post… | Use template |
 |------------------------------|--------------|
 | "Acknowledge this bug, we'll investigate" | `ack-bug` |

.github/workflows/review-pr-action.yml

@@ -43,6 +43,19 @@ jobs:
         with:
           fetch-depth: 1
 
+      - name: Lock down scripts/ as read-only
+        # The agent has the generic `Write` tool (needed to emit the JSON
+        # decision file). Without this step a compromised prompt/model
+        # could overwrite an allowlisted script (e.g. get_pr_diff.sh) and
+        # then execute it via the `Bash(bash scripts/get_pr_diff.sh:*)`
+        # entry to run arbitrary commands and exfiltrate
+        # CLAUDE_CODE_API_TOKEN. Stripping write bits on the directory
+        # and its contents removes that path.
+        run: |
+          set -euo pipefail
+          chmod -R a-w scripts
+          chmod a-w scripts
+
       - name: Review analysis
         uses: anthropics/claude-code-action@v1
         env:

.github/workflows/triage-issue-action.yml

@@ -42,6 +42,19 @@ jobs:
         with:
           fetch-depth: 1
 
+      - name: Lock down scripts/ as read-only
+        # The agent has the generic `Write` tool (needed to emit the JSON
+        # decision file). Without this step a compromised prompt/model
+        # could overwrite an allowlisted script (e.g. get_issue.sh) and
+        # then execute it via the `Bash(bash scripts/get_issue.sh:*)`
+        # entry to run arbitrary commands and exfiltrate
+        # CLAUDE_CODE_API_TOKEN. Stripping write bits on the directory
+        # and its contents removes that path.
+        run: |
+          set -euo pipefail
+          chmod -R a-w scripts
+          chmod a-w scripts
+
       - name: Triage analysis
         uses: anthropics/claude-code-action@v1
         env:

scripts/add_comment.sh

@@ -37,7 +37,10 @@ TEMPLATE=""
 PARAMS_FILE=""
 
 require_value() {
-  if [[ $# -lt 2 || -z "$2" ]]; then
+  # Treat a missing arg, an empty string, or a next token that looks
+  # like another flag (`--foo`) as a missing value so the failure points
+  # at the right argument.
+  if [[ $# -lt 2 || -z "${2:-}" || "$2" == --* ]]; then
     echo "Error: $1 requires a value" >&2
     exit 1
   fi
@@ -90,6 +93,11 @@ if [[ -n "$PARAMS_FILE" && ! -f "$PARAMS_FILE" ]]; then
   exit 1
 fi
 
+if ! command -v python3 >/dev/null 2>&1; then
+  echo "Error: python3 is required to render comment templates but was not found in PATH" >&2
+  exit 1
+fi
+
 # Render the template in Python for robust handling of multi-line values
 # and literal-string substitution (no shell-quoting / regex pitfalls).
 OUT_FILE=$(mktemp)

scripts/close_issue.sh

@@ -20,7 +20,10 @@ set -euo pipefail
 WORKFLOW=""
 
 require_value() {
-  if [[ $# -lt 2 || -z "$2" ]]; then
+  # Treat a missing arg, an empty string, or a next token that looks
+  # like another flag (`--foo`) as a missing value so the failure points
+  # at the right argument.
+  if [[ $# -lt 2 || -z "${2:-}" || "$2" == --* ]]; then
     echo "Error: $1 requires a value" >&2
     exit 1
   fi