fix: handle type change

Author: fPolic

packages/admin/dashboard/src/routes/promotions/promotion-edit-details/components/edit-promotion-form/edit-promotion-details-form.tsx

@@ -10,6 +10,7 @@ import {
 } from "@medusajs/ui"
 import { useForm, useWatch } from "react-hook-form"
 import { Trans, useTranslation } from "react-i18next"
+import { useEffect } from "react"
 import * as zod from "zod"
 
 import { Form } from "../../../../../components/common/form"
@@ -27,7 +28,7 @@ type EditPromotionFormProps = {
 const EditPromotionSchema = zod.object({
   is_automatic: zod.string().toLowerCase(),
   code: zod.string().min(1),
-  is_tax_inclusive: zod.boolean(),
+  is_tax_inclusive: zod.boolean().optional(),
   status: zod.enum(["active", "inactive", "draft"]),
   value_type: zod.enum(["fixed", "percentage"]),
   value: zod.number(),
@@ -83,6 +84,17 @@ export const EditPromotionDetailsForm = ({
     )
   })
 
+  const allocationWatchValue = useWatch({
+    control: form.control,
+    name: "value_type",
+  })
+
+  useEffect(() => {
+    if (!(allocationWatchValue === "fixed" && promotion.type === "standard")) {
+      form.setValue("is_tax_inclusive", false)
+    }
+  }, [allocationWatchValue, form, promotion])
+
   return (
     <RouteDrawer.Form form={form}>
       <KeyboundForm
@@ -172,15 +184,16 @@ export const EditPromotionDetailsForm = ({
               }}
             />
 
-            {promotion?.type === "standard" &&
-            promotion.application_method?.type === "fixed" ? (
-              <SwitchBox
-                control={form.control}
-                name="is_tax_inclusive"
-                label={t("promotions.form.taxInclusive.title")}
-                description={t("promotions.form.taxInclusive.description")}
-              />
-            ) : null}
+            {allocationWatchValue === "fixed" &&
+              promotion.type === "standard" && (
+                <SwitchBox
+                  control={form.control}
+                  name="is_tax_inclusive"
+                  label={t("promotions.form.taxInclusive.title")}
+                  description={t("promotions.form.taxInclusive.description")}
+                />
+              )}
+
             <div className="flex flex-col gap-y-4">
               <Form.Field
                 control={form.control}
@@ -189,7 +202,6 @@ export const EditPromotionDetailsForm = ({
                   return (
                     <Form.Item>
                       <Form.Label>{t("promotions.form.code.title")}</Form.Label>
-
                       <Form.Control>
                         <Input {...field} />
                       </Form.Control>