fix tests

Author: adrien2p

packages/modules/workflow-engine-inmemory/integration-tests/__tests__/index.spec.ts

@@ -143,7 +143,7 @@ moduleIntegrationTestRunner<IWorkflowEngineService>({
       })
 
       describe("Cancel transaction", function () {
-        it("should cancel an ongoing execution with async unfinished yet step", async () => {
+        it("should cancel an ongoing execution with async unfinished yet step", (done) => {
           const transactionId = "transaction-to-cancel-id"
           const step1 = createStep("step1", async () => {
             return new StepResponse("step1")
@@ -168,25 +168,39 @@ moduleIntegrationTestRunner<IWorkflowEngineService>({
             return new WorkflowResponse("finished")
           })
 
-          await workflowOrcModule.run(workflowId, {
-            input: {},
-            transactionId,
-          })
-
-          await setTimeoutPromise(100)
-
-          await workflowOrcModule.cancel(workflowId, {
-            transactionId,
-          })
-
-          await setTimeoutPromise(1000)
-
-          const execution = await workflowOrcModule.listWorkflowExecutions({
-            transaction_id: transactionId,
-          })
+          workflowOrcModule
+            .run(workflowId, {
+              input: {},
+              transactionId,
+            })
+            .then(async () => {
+              await setTimeoutPromise(100)
+
+              await workflowOrcModule.cancel(workflowId, {
+                transactionId,
+              })
+
+              workflowOrcModule.subscribe({
+                workflowId,
+                transactionId,
+                subscriber: async (event) => {
+                  if (event.eventType === "onFinish") {
+                    const execution =
+                      await workflowOrcModule.listWorkflowExecutions({
+                        transaction_id: transactionId,
+                      })
+
+                    expect(execution.length).toEqual(1)
+                    expect(execution[0].state).toEqual(
+                      TransactionState.REVERTED
+                    )
+                    done()
+                  }
+                },
+              })
+            })
 
-          expect(execution.length).toEqual(1)
-          expect(execution[0].state).toEqual(TransactionState.REVERTED)
+          failTrap(done)
         })
 
         it("should cancel a complete execution with a sync workflow running as async", async () => {

packages/modules/workflow-engine-redis/integration-tests/__tests__/index.spec.ts

@@ -151,7 +151,7 @@ moduleIntegrationTestRunner<IWorkflowEngineService>({
 
       describe("Testing basic workflow", function () {
         describe("Cancel transaction", function () {
-          it("should cancel an ongoing execution with async unfinished yet step", async () => {
+          it("should cancel an ongoing execution with async unfinished yet step", (done) => {
             const transactionId = "transaction-to-cancel-id"
             const step1 = createStep("step1", async () => {
               return new StepResponse("step1")
@@ -179,25 +179,42 @@ moduleIntegrationTestRunner<IWorkflowEngineService>({
               }
             )
 
-            await workflowOrcModule.run(workflowId, {
-              input: {},
-              transactionId,
-            })
-
-            await setTimeout(100)
-
-            await workflowOrcModule.cancel(workflowId, {
-              transactionId,
-            })
+            workflowOrcModule
+              .run(workflowId, {
+                input: {},
+                transactionId,
+              })
+              .then(async () => {
+                await setTimeout(100)
 
-            await setTimeout(1000)
+                await workflowOrcModule.cancel(workflowId, {
+                  transactionId,
+                })
 
-            const execution = await workflowOrcModule.listWorkflowExecutions({
-              transaction_id: transactionId,
-            })
+                workflowOrcModule.subscribe({
+                  workflowId,
+                  transactionId,
+                  subscriber: async (event) => {
+                    if (event.eventType === "onFinish") {
+                      const execution =
+                        await workflowOrcModule.listWorkflowExecutions({
+                          transaction_id: transactionId,
+                        })
+
+                      expect(execution.length).toEqual(1)
+                      expect(execution[0].state).toEqual(
+                        TransactionState.REVERTED
+                      )
+                      done()
+                    }
+                  },
+                })
+              })
 
-            expect(execution.length).toEqual(1)
-            expect(execution[0].state).toEqual(TransactionState.REVERTED)
+            failTrap(
+              done,
+              "should cancel an ongoing execution with async unfinished yet step"
+            )
           })
 
           it("should cancel a complete execution with a sync workflow running as async", async () => {