fix(core-flows): correctly clear a region payment providers (#15986)

Author: NicolasGorga

.changeset/silent-insects-double.md

@@ -0,0 +1,5 @@
+---
+"@medusajs/core-flows": patch
+---
+
+fix(core-flows): correctly clear a region payment providers

integration-tests/modules/__tests__/regions/admin/regions.spec.ts

@@ -238,6 +238,46 @@ medusaIntegrationTestRunner({
             ]),
           })
         )
+
+        /**
+         * Omitting payment_providers should leave the existing links untouched
+         */
+
+        await api.post(
+          `/admin/regions/${created.data.region.id}`,
+          {
+            name: "Test Region updated",
+          },
+          adminHeaders
+        )
+
+        regionResponse = await api.get(
+          `/admin/regions/${created.data.region.id}?fields=*payment_providers`,
+          adminHeaders
+        )
+
+        expect(regionResponse.status).toEqual(200)
+        expect(regionResponse.data.region.payment_providers).toHaveLength(2)
+
+        /**
+         * Passing an empty payment_providers list should clear all links
+         */
+
+        await api.post(
+          `/admin/regions/${created.data.region.id}`,
+          {
+            payment_providers: [],
+          },
+          adminHeaders
+        )
+
+        regionResponse = await api.get(
+          `/admin/regions/${created.data.region.id}?fields=*payment_providers`,
+          adminHeaders
+        )
+
+        expect(regionResponse.status).toEqual(200)
+        expect(regionResponse.data.region.payment_providers).toEqual([])
       })
 
       it("should throw on update if the given payment providers does not exists", async () => {

packages/core/core-flows/src/region/steps/set-regions-payment-providers.ts

@@ -9,6 +9,7 @@ import {
   MedusaError,
   Modules,
   arrayDifference,
+  isDefined,
   promiseAll,
 } from "@medusajs/framework/utils"
 import { StepResponse, createStep } from "@medusajs/framework/workflows-sdk"
@@ -104,7 +105,7 @@ export const setRegionsPaymentProvidersStepId =
   "add-region-payment-providers-step"
 /**
  * This step sets the payment providers available in regions.
- * 
+ *
  * @example
  * const data = setRegionsPaymentProvidersStep({
  *   input: [
@@ -119,7 +120,7 @@ export const setRegionsPaymentProvidersStep = createStep(
   setRegionsPaymentProvidersStepId,
   async (data: SetRegionsPaymentProvidersStepInput, { container }) => {
     const dataInputToProcess = data.input.filter((inputData) => {
-      return inputData.payment_providers?.length
+      return isDefined(inputData.payment_providers)
     }) as FilteredSetRegionsPaymentProvidersStepInput[]
 
     if (!dataInputToProcess.length) {

packages/core/core-flows/src/region/workflows/update-regions.ts

@@ -45,7 +45,7 @@ export const updateRegionsWorkflow = createWorkflow(
   ): WorkflowResponse<WorkflowTypes.RegionWorkflow.UpdateRegionsWorkflowOutput> => {
     const normalizedInput = transform(input, (data) => {
       const { selector, update } = data
-      const { payment_providers = [], is_tax_inclusive, ...rest } = update
+      const { payment_providers, is_tax_inclusive, ...rest } = update
       return {
         selector,
         update: rest,