fix(link-modules,core-flows): Carry over cart promotions to order promotions

Author: riqwan

.changeset/odd-apricots-marry.md

@@ -0,0 +1,6 @@
+---
+"@medusajs/link-modules": patch
+"@medusajs/core-flows": patch
+---
+
+fix(link-modules,core-flows): Carry over cart promotions to order promotions

integration-tests/http/__tests__/cart/store/cart.spec.ts

@@ -1252,6 +1252,60 @@ medusaIntegrationTestRunner({
             )
           })
 
+          it("should successfully complete cart with promotions", async () => {
+            const oldCart = (
+              await api.get(`/store/carts/${cart.id}`, storeHeaders)
+            ).data.cart
+
+            createCartCreditLinesWorkflow.run({
+              input: [
+                {
+                  cart_id: oldCart.id,
+                  amount: oldCart.total,
+                  currency_code: "usd",
+                  reference: "test",
+                  reference_id: "test",
+                },
+              ],
+              container: appContainer,
+            })
+
+            const cartResponse = await api.post(
+              `/store/carts/${cart.id}/complete`,
+              {},
+              storeHeaders
+            )
+
+            const orderResponse = await api.get(
+              `/store/orders/${cartResponse.data.order.id}?fields=+promotions.*`,
+              storeHeaders
+            )
+
+            expect(cartResponse.status).toEqual(200)
+            expect(orderResponse.data.order).toEqual(
+              expect.objectContaining({
+                promotions: [
+                  expect.objectContaining({
+                    code: promotion.code,
+                  }),
+                ],
+                items: expect.arrayContaining([
+                  expect.objectContaining({
+                    unit_price: 1500,
+                    compare_at_unit_price: null,
+                    quantity: 1,
+                    adjustments: expect.arrayContaining([
+                      expect.objectContaining({
+                        amount: 100,
+                        code: promotion.code,
+                      }),
+                    ]),
+                  }),
+                ]),
+              })
+            )
+          })
+
           it("should successfully complete cart without shipping for digital products", async () => {
             /**
              * Product has a shipping profile so cart item should not require shipping

packages/core/core-flows/src/cart/utils/fields.ts

@@ -36,6 +36,7 @@ export const cartFieldsForRefreshSteps = [
   "shipping_methods.tax_lines.*",
   "customer.*",
   "customer.groups.*",
+  "promotions.id",
   "promotions.code",
   "payment_collection.id",
   "payment_collection.raw_amount",
@@ -105,6 +106,7 @@ export const completeCartFields = [
   "credit_lines.*",
   "payment_collection.*",
   "payment_collection.payment_sessions.*",
+  "promotions.id",
   "items.variant.id",
   "items.variant.product.id",
   "items.variant.product.is_giftcard",

packages/core/core-flows/src/cart/workflows/complete-cart.ts

@@ -1,6 +1,8 @@
 import {
   CartCreditLineDTO,
   CartWorkflowDTO,
+  LinkDefinition,
+  PromotionDTO,
   UsageComputedActions,
 } from "@medusajs/framework/types"
 import {
@@ -326,13 +328,22 @@ export const completeCartWorkflow = createWorkflow(
       const linksToCreate = transform(
         { cart, createdOrder },
         ({ cart, createdOrder }) => {
-          const links: Record<string, any>[] = [
+          const links: LinkDefinition[] = [
             {
               [Modules.ORDER]: { order_id: createdOrder.id },
               [Modules.CART]: { cart_id: cart.id },
             },
           ]
 
+          if (cart.promotions?.length) {
+            cart.promotions.forEach((promotion: PromotionDTO) => {
+              links.push({
+                [Modules.ORDER]: { order_id: createdOrder.id },
+                [Modules.PROMOTION]: { promotion_id: promotion.id },
+              })
+            })
+          }
+
           if (isDefined(cart.payment_collection?.id)) {
             links.push({
               [Modules.ORDER]: { order_id: createdOrder.id },

packages/modules/link-modules/src/definitions/order-promotion.ts

@@ -32,7 +32,7 @@ export const OrderPromotion: ModuleJoinerConfig = {
       entity: "Promotion",
       primaryKey: "id",
       foreignKey: "promotion_id",
-      alias: "promotion",
+      alias: "promotions",
       args: {
         methodSuffix: "Promotions",
       },
@@ -44,8 +44,8 @@ export const OrderPromotion: ModuleJoinerConfig = {
       serviceName: Modules.ORDER,
       entity: "Order",
       fieldAlias: {
-        promotion: {
-          path: "promotion_link.promotion",
+        promotions: {
+          path: "promotion_link.promotions",
           isList: true,
         },
       },
@@ -54,16 +54,7 @@ export const OrderPromotion: ModuleJoinerConfig = {
         primaryKey: "order_id",
         foreignKey: "id",
         alias: "promotion_link",
-      },
-    },
-    {
-      serviceName: Modules.PROMOTION,
-      entity: "Promotion",
-      relationship: {
-        serviceName: LINKS.OrderPromotion,
-        primaryKey: "promotion_id",
-        foreignKey: "id",
-        alias: "order_link",
+        isList: true,
       },
     },
   ],