chore(dashboard): fix type and lint errors (4/n) (#15212)

> This PR is part of a series of PRs to fix type and lint issues in the dashboard package. The last PR will enable the type checking as part of the build and add a changeset

1-liner type fixes for the campaign, categories, and customer routes

Author: shahednasser

packages/admin/dashboard/src/routes/campaigns/campaign-budget-edit/components/edit-campaign-budget-form/edit-campaign-budget-form.tsx

@@ -95,7 +95,7 @@ export const EditCampaignBudgetForm = ({
                           key="usage"
                           min={0}
                           {...field}
-                          value={value}
+                          value={value ?? undefined}
                           onChange={(e) => {
                             onChange(
                               e.target.value === ""

packages/admin/dashboard/src/routes/campaigns/campaign-create/components/create-campaign-form/create-campaign-form.tsx

@@ -23,7 +23,12 @@ export const CreateCampaignSchema = zod.object({
   budget: zod.object({
     attribute: zod.string().nullish(),
     limit: zod.number().min(0).nullish(),
-    type: zod.enum(["spend", "usage", "use_by_attribute"]),
+    type: zod.enum([
+      "spend",
+      "usage",
+      "use_by_attribute",
+      "spend_by_attribute",
+    ]),
     currency_code: zod.string().nullish(),
   }),
 })

packages/admin/dashboard/src/routes/campaigns/campaign-detail/components/campaign-configuration-section/index.ts

@@ -1 +1 @@
-export * from "./campaign-configuration-section";
+export * from "./campaign-configuration-section"

packages/admin/dashboard/src/routes/campaigns/campaign-detail/components/campaign-spend/campaign-spend.tsx

@@ -23,8 +23,8 @@ export const CampaignSpend = ({ campaign }: CampaignSpendProps) => {
           {campaign.budget?.type === "use_by_attribute"
             ? t("campaigns.fields.totalUsedByAttribute")
             : campaign.budget?.type === "spend"
-              ? t("campaigns.fields.total_spend")
-              : t("campaigns.fields.total_used")}
+            ? t("campaigns.fields.total_spend")
+            : t("campaigns.fields.total_used")}
         </Heading>
       </div>
 

packages/admin/dashboard/src/routes/campaigns/common/components/create-campaign-form-fields/create-campaign-form-fields.tsx

@@ -21,7 +21,13 @@ import {
 } from "../../../../../lib/data/currencies"
 import { Combobox } from "../../../../../components/inputs/combobox"
 
-export const CreateCampaignFormFields = ({ form, fieldScope = "" }) => {
+export const CreateCampaignFormFields = ({
+  form,
+  fieldScope = "",
+}: {
+  form: any
+  fieldScope?: string
+}) => {
   const { t } = useTranslation()
   const { store } = useStore()
   const direction = useDocumentDirection()

packages/admin/dashboard/src/routes/categories/categories-metadata/categories-metadata.tsx

@@ -10,8 +10,12 @@ import { RouteDrawer } from "../../../components/modals"
 export const CategoriesMetadata = () => {
   const { id } = useParams()
 
-  const { product_category, isPending, isError, error } = useProductCategory(id)
-  const { mutateAsync, isPending: isMutating } = useUpdateProductCategory(id)
+  const { product_category, isPending, isError, error } = useProductCategory(
+    id ?? ""
+  )
+  const { mutateAsync, isPending: isMutating } = useUpdateProductCategory(
+    id ?? ""
+  )
 
   if (isError) {
     throw error

packages/admin/dashboard/src/routes/categories/category-create/components/create-category-form/create-category-details.tsx

@@ -81,11 +81,7 @@ export const CreateCategoryDetails = ({ form }: CreateCategoryDetailsProps) => {
                 <Form.Item>
                   <Form.Label>{t("categories.fields.status.label")}</Form.Label>
                   <Form.Control>
-                    <Select
-                      dir={direction}
-                      {...field}
-                      onValueChange={onChange}
-                    >
+                    <Select dir={direction} {...field} onValueChange={onChange}>
                       <Select.Trigger ref={ref}>
                         <Select.Value />
                       </Select.Trigger>
@@ -114,11 +110,7 @@ export const CreateCategoryDetails = ({ form }: CreateCategoryDetailsProps) => {
                     {t("categories.fields.visibility.label")}
                   </Form.Label>
                   <Form.Control>
-                    <Select
-                      dir={direction}
-                      {...field}
-                      onValueChange={onChange}
-                    >
+                    <Select dir={direction} {...field} onValueChange={onChange}>
                       <Select.Trigger ref={ref}>
                         <Select.Value />
                       </Select.Trigger>

packages/admin/dashboard/src/routes/categories/category-create/components/create-category-form/create-category-form.tsx

@@ -61,10 +61,10 @@ export const CreateCategoryForm = ({
       })
 
       if (!result.success) {
-        result.error.errors.forEach((error) => {
-          form.setError(error.path.join(".") as keyof CreateCategorySchema, {
+        result.error.issues.forEach(({ path, message }) => {
+          form.setError(path.join(".") as keyof CreateCategorySchema, {
             type: "manual",
-            message: error.message,
+            message,
           })
         })
 
@@ -130,8 +130,9 @@ export const CreateCategoryForm = ({
         onSubmit={handleSubmit}
         className="flex size-full flex-col overflow-hidden"
       >
-         <ProgressTabs
-        dir={direction}value={activeTab}
+        <ProgressTabs
+          dir={direction}
+          value={activeTab}
           onValueChange={(tab) => handleTabChange(tab as Tab)}
           className="flex size-full flex-col"
         >

packages/admin/dashboard/src/routes/customers/customer-detail/components/customer-order-section/customer-order-section.tsx

@@ -19,7 +19,8 @@ type CustomerGeneralSectionProps = {
 
 const PREFIX = "cusord"
 const PAGE_SIZE = 10
-const DEFAULT_RELATIONS = "*customer,*items,*sales_channel,*payment_collections,+shipping_address.country_code"
+const DEFAULT_RELATIONS =
+  "*customer,*items,*sales_channel,*payment_collections,+shipping_address.country_code"
 const DEFAULT_FIELDS =
   "id,status,display_id,created_at,email,fulfillment_status,payment_status,total,currency_code"
 
@@ -63,12 +64,12 @@ export const CustomerOrderSection = ({
     <Container className="divide-y p-0">
       <div className="flex items-center justify-between px-6 py-4">
         <Heading level="h2">{t("orders.domain")}</Heading>
-        {/*TODO: ENABLE WHEN DRAFT ORDERS ARE DONE*/}
-        {/*<div className="flex items-center gap-x-2">*/}
+        {/* TODO: ENABLE WHEN DRAFT ORDERS ARE DONE*/}
+        {/* <div className="flex items-center gap-x-2">*/}
         {/*  <Button size="small" variant="secondary">*/}
         {/*    {t("actions.create")}*/}
         {/*  </Button>*/}
-        {/*</div>*/}
+        {/* </div>*/}
       </div>
       <_DataTable
         columns={columns}

packages/admin/dashboard/src/routes/customers/customers-add-customer-group/components/add-customers-form/add-customer-groups-form.tsx

@@ -129,7 +129,9 @@ export const AddCustomerGroupsForm = ({
 
       handleSuccess(`/customers/${customerId}`)
     } catch (e) {
-      toast.error(e.message)
+      toast.error(
+        e instanceof Error ? e.message : t("errorBoundary.defaultTitle")
+      )
     } finally {
       setIsPending(false)
     }