Skip to content

Commit 29a3cbd

Browse files
timiclaude
authored andcommitted
fix: properly expand secret in sed command
Move SIGNING_IDENTITY export inside run block to ensure it's expanded correctly before sed runs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 7660e08 commit 29a3cbd

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

.github/workflows/build.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,14 +133,12 @@ jobs:
133133
134134
- name: Patch optimize-tauri-bundle.sh for CI signing
135135
working-directory: ./lumis/apps/web/scripts
136-
env:
137-
SIGNING_IDENTITY: "${{ secrets.APPLE_SIGNING_IDENTITY }}"
138136
run: |
139137
# Replace ad-hoc signing with Developer ID signing in optimize script
140-
# This is needed because the script uses --sign - which breaks notarization
138+
SIGNING_IDENTITY="${{ secrets.APPLE_SIGNING_IDENTITY }}"
141139
sed -i.bak "s/codesign --force --sign -/codesign --force --sign $SIGNING_IDENTITY/g" optimize-tauri-bundle.sh
142140
sed -i.bak "s/codesign --force --deep --sign -/codesign --force --deep --sign $SIGNING_IDENTITY/g" optimize-tauri-bundle.sh
143-
# Add timestamp option to all codesign commands in the script
141+
# Add timestamp option to all codesign commands
144142
sed -i.bak 's/codesign --force/codesign --force --timestamp/g' optimize-tauri-bundle.sh
145143
# Verify the changes
146144
echo "Patched optimize-tauri-bundle.sh:"

0 commit comments

Comments
 (0)