Skip to content

Commit 4407be8

Browse files
timiclaude
authored andcommitted
fix: exclude cli-bundle from Node.js re-signing to prevent runtime issues
The cli-bundle/node is already signed by bundle-runtime.sh with ad-hoc signature. Re-signing it with Developer ID in CI causes the Node.js runtime to fail when spawned by Rust. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 3aa6471 commit 4407be8

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/build.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,9 @@ jobs:
203203
find "$APP_BUNDLE" -type f \( -name "*.node" -o -name "*.dylib" \) -print0 | xargs -0 xattr -cr 2>/dev/null || true
204204
205205
# Sign all .node files with Developer ID, timestamp, and hardened runtime
206+
# But skip cli-bundle/node which is already signed by bundle-runtime.sh
206207
echo " Signing .node files..."
207-
find "$APP_BUNDLE" -type f -name "*.node" -print0 | xargs -0 codesign --force --sign "$SIGN_ID" --options runtime --timestamp || true
208+
find "$APP_BUNDLE" -type f -name "*.node" -not -path "*/cli-bundle/*" -print0 | xargs -0 codesign --force --sign "$SIGN_ID" --options runtime --timestamp || true
208209
209210
# Sign all .dylib files with Developer ID, timestamp, and hardened runtime
210211
echo " Signing .dylib files..."

0 commit comments

Comments
 (0)