Skip to content

Commit 9c9c7fd

Browse files
timiclaude
authored andcommitted
fix: fix ordering - sign app bundle before rebuilding DMG
The app bundle must be signed BEFORE the DMG is rebuilt, not after. Move the deep signing step to before the DMG rebuild step. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 84947c6 commit 9c9c7fd

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

.github/workflows/build.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -193,15 +193,6 @@ jobs:
193193
194194
echo "✅ Fallback signing complete"
195195
196-
- name: Rebuild DMG with signed binaries
197-
run: |
198-
# Remove old DMG
199-
rm -f ./lumis/apps/web/src-tauri/target/release/bundle/dmg/Lumis*.dmg
200-
201-
# Rebuild DMG using Tauri (which will use the already signed app bundle)
202-
cd ./lumis/apps/web
203-
pnpm tauri build --bundles dmg
204-
205196
- name: Sign app bundle with Developer ID (deep)
206197
env:
207198
APPLE_SIGNING_IDENTITY: "${{ secrets.APPLE_SIGNING_IDENTITY }}"
@@ -212,6 +203,15 @@ jobs:
212203
codesign --deep --force --sign "$APPLE_SIGNING_IDENTITY" --options runtime --timestamp "$APP_BUNDLE"
213204
echo "✅ App bundle deep signed"
214205
206+
- name: Rebuild DMG with signed binaries
207+
run: |
208+
# Remove old DMG (the app bundle is now properly signed)
209+
rm -f ./lumis/apps/web/src-tauri/target/release/bundle/dmg/Lumis*.dmg
210+
211+
# Rebuild DMG using Tauri (which will use the already signed app bundle)
212+
cd ./lumis/apps/web
213+
pnpm tauri build --bundles dmg
214+
215215
- name: Sign DMG with Developer ID
216216
env:
217217
APPLE_SIGNING_IDENTITY: "${{ secrets.APPLE_SIGNING_IDENTITY }}"

0 commit comments

Comments
 (0)