Cartridge emulation improvements (#2595)

* refine cart interface implementation to match hardware, including timing fixes
* add second cart slot for DSi
* fully implement SCFG_MC
* move cart classes to subdirectory

fixes #2586
fixes #380 (might need extensive testing)
fixes Surviving High School (DSiWare)

Author: Arisotura

src/ARMJIT_Memory.cpp

@@ -1433,9 +1433,14 @@ static void GPU_WriteVRAM_ARM7(u32 addr, T val) noexcept
     NDS::Current->GPU.WriteVRAM_ARM7<T>(addr, val);
 }
 
-u32 NDSCartSlot_ReadROMData()
-{ // TODO: Add a NDS* parameter, when NDS* is eventually implemented
-    return NDS::Current->NDSCartSlot.ReadROMData();
+u32 NDSCartSlot_ReadROMData9()
+{
+    return NDS::Current->NDSCartSlots[0]->ReadROMData(0);
+}
+
+u32 NDSCartSlot_ReadROMData7()
+{
+    return NDS::Current->NDSCartSlots[0]->ReadROMData(1);
 }
 
 static u8 NDS_ARM9IORead8(u32 addr)
@@ -1505,8 +1510,8 @@ void* ARMJIT_Memory::GetFuncForAddr(ARM* cpu, u32 addr, bool store, int size) co
         switch (addr & 0xFF000000)
         {
         case 0x04000000:
-            if (!store && size == 32 && addr == 0x04100010 && NDS.ExMemCnt[0] & (1<<11))
-                return (void*)NDSCartSlot_ReadROMData;
+            if (!store && size == 32 && addr == 0x04100010)
+                return (void*)NDSCartSlot_ReadROMData9;
 
             /*
                 unfortunately we can't map GPU2D this way

src/CMakeLists.txt

@@ -41,11 +41,9 @@ add_library(core STATIC
     GPU3D_Soft.cpp
     GPU3D_Texcache.cpp
     GPU3D_Texcache.h
-    melonDLDI.h
     Mic.cpp
     NDS.cpp
     NDSCart.cpp
-    NDSCartR4.cpp
     Platform.h
     ROMList.h
     ROMList.cpp
@@ -67,6 +65,15 @@ add_library(core STATIC
     DSP_HLE/G711Ucode.cpp
     DSP_HLE/GraphicsUcode.cpp
 
+    NDSCart/CartCommon.cpp
+    NDSCart/CartRetail.cpp
+    NDSCart/CartRetailNAND.cpp
+    NDSCart/CartRetailIR.cpp
+    NDSCart/CartRetailBT.cpp
+    NDSCart/CartSD.cpp
+    NDSCart/CartHomebrew.cpp
+    NDSCart/CartR4.cpp
+
     fatfs/ff.c
     fatfs/ffsystem.c
     fatfs/ffunicode.c