chore: add todos

Author: baroooo

contracts/interfaces/IFPMMFactory.sol

@@ -177,15 +177,13 @@ interface IFPMMFactory {
    * @param token0 The address of the first token
    * @param token1 The address of the second token
    * @param referenceRateFeedID The address of the reference rate feed
-   * @param revertRateFeed Whether to revert if the rate feed is not available
    * @return proxy The address of the deployed FPMM proxy
    */
   function deployFPMM(
     address fpmmImplementation,
     address token0,
     address token1,
-    address referenceRateFeedID,
-    bool revertRateFeed
+    address referenceRateFeedID
   ) external returns (address proxy);
 
   /**
@@ -198,7 +196,6 @@ interface IFPMMFactory {
    * @param token0 The address of the first token
    * @param token1 The address of the second token
    * @param referenceRateFeedID The address of the reference rate feed
-   * @param revertRateFeed Whether to revert if the rate feed is not available
    * @return proxy The address of the deployed FPMM proxy
    */
   function deployFPMM(
@@ -209,7 +206,6 @@ interface IFPMMFactory {
     address customGovernance,
     address token0,
     address token1,
-    address referenceRateFeedID,
-    bool revertRateFeed
+    address referenceRateFeedID
   ) external returns (address proxy);
 }

contracts/swap/FPMMFactory.sol

@@ -208,6 +208,7 @@ contract FPMMFactory is IFPMMFactory, OwnableUpgradeable {
     emit FPMMImplementationUnregistered(fpmmImplementation);
   }
 
+  // bool revertRateFeed // TODO: Add this back in
   /// @inheritdoc IFPMMFactory
   function deployFPMM(
     address fpmmImplementation,
@@ -217,8 +218,7 @@ contract FPMMFactory is IFPMMFactory, OwnableUpgradeable {
     address customGovernance,
     address token0,
     address token1,
-    address referenceRateFeedID,
-    bool revertRateFeed
+    address referenceRateFeedID
   ) external onlyOwner returns (address) {
     FPMMFactoryStorage storage $ = _getFPMMStorage();
     require($.isRegisteredImplementation[fpmmImplementation], "FPMMFactory: IMPLEMENTATION_NOT_REGISTERED");
@@ -246,14 +246,14 @@ contract FPMMFactory is IFPMMFactory, OwnableUpgradeable {
     return fpmmProxy;
   }
 
+  // bool revertRateFeed // TODO: Add this back in
   // slither-disable-start reentrancy-no-eth
   /// @inheritdoc IFPMMFactory
   function deployFPMM(
     address fpmmImplementation,
     address token0,
     address token1,
-    address referenceRateFeedID,
-    bool revertRateFeed
+    address referenceRateFeedID
   ) external onlyOwner returns (address) {
     FPMMFactoryStorage storage $ = _getFPMMStorage();
     require($.isRegisteredImplementation[fpmmImplementation], "FPMMFactory: IMPLEMENTATION_NOT_REGISTERED");

script/DeployLiquity2.s.sol

@@ -255,8 +255,7 @@ contract DeployLiquity2Script is StdCheats, MetadataDeployment, Logging {
       CONFIG.fpmmImplementation,
       address(r.stableToken),
       CONFIG.USDm_ALFAJORES_ADDRESS,
-      CONFIG.referenceRateFeedID,
-      false // revertRateFeed - set to false as default
+      CONFIG.referenceRateFeedID
     );
   }
 

script/DeployReserveFPMM.s.sol

@@ -58,13 +58,7 @@ contract DeployReserveFPMM is Script {
     fpmmFactory.initialize(sortedOracles, address(proxyAdmin), breakerBox, deployer, address(fpmmImplementation));
 
     // Deploy FPMM Proxy mUSD.m/USDC
-    cUSDaxlUSDCFPMM = fpmmFactory.deployFPMM(
-      address(fpmmImplementation),
-      address(USDm),
-      USDC,
-      USDCUSDRateFeedID,
-      false // revertRateFeed - set to false as default
-    );
+    cUSDaxlUSDCFPMM = fpmmFactory.deployFPMM(address(fpmmImplementation), address(USDm), USDC, USDCUSDRateFeedID);
 
     // Deploy Liquidity Strategy
     liquidityStrategy.initialize(reserve);