refactor the ´compare´ tool

[andlaus]

the code of the compare tool currently is a bowl of spaghetti with sub-optimal type annotations (lots of type: ignore comments) and desperately needs a cleanup.

[vinothk-master]

Hi @andlaus
Can I contribute to this open issue?
Thanks
Vinoth Kannan

[andlaus]

sure, that would be much appreciated. if you're looking for a place to start, a great one would to refactor the code to making use of dataclasses in order to make it easier to understand what data is expected/available where and to get rid (or at least reduce the number) of type: ignore comments...

[vinothk-master]

Ok @andlaus Thanks for the info, Let me check the code first
Thanks

[vinothk-master]

Hi @andlaus

Status: I am working on implementing the @dataclass as you mentioned and trying to reduce the type: ignore comments

Thanks

[vinothk-master]

Hi @andlaus

As per this commit a602a79 can we close this issue ?

Thanks

[andlaus]

as I see it, #393 is a great first step, but IIRC there are still a few issues lurking, e.g. using two lists which must be of the same size instead of a single list with objects that contain two attributes (for the removed and added diagcomms of a set of diag layers?) . I have to go over the latest version of the code to come to a definitive conclusion, though.