Skip to content

Bug: incorrect SNREF/SNPATHREF validation in StateTransitionRef and PreConditionStateRef #515

Description

@seif-galal

In both StateTransitionRef and PreConditionStateRef, the validation performed when VALUE is specified checks in_param_if_snref twice:

self.in_param_if_snref is not None or self.in_param_if_snref is not None

The second operand appears to be intended to check in_param_if_snpathref.

As a result, a reference provided exclusively through IN-PARAM-IF-SNPATHREF does not satisfy this validation.

Files:

  • odxtools/statetransitionref.py
  • odxtools/preconditionstateref.py

A local correction changes the second operand to in_param_if_snpathref.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions