Skip to content

Commit 9a2de7e

Browse files
authored
Merge pull request #30 from meshery/update-node
upgrade node js version from node 18 to node 20
2 parents 16016ff + 0b2dc18 commit 9a2de7e

4 files changed

Lines changed: 15 additions & 12 deletions

File tree

.github/workflows/build-ui-and-server.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
fetch-depth: 1
5151
- uses: actions/setup-node@v4
5252
with:
53-
node-version: 18
53+
node-version: '20.x'
5454
- name: Cache node modules
5555
id: node-cache
5656
uses: actions/cache@v4
@@ -145,7 +145,7 @@ jobs:
145145
- name: Setup node
146146
uses: actions/setup-node@v4
147147
with:
148-
node-version: 18
148+
node-version: '20.x'
149149
- name: Restore node modules cache
150150
id: node-cache
151151
uses: actions/cache@v4

.github/workflows/build-ui-server-reusable-workflow.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
fetch-depth: 1
4747
- uses: actions/setup-node@v4
4848
with:
49-
node-version: 18
49+
node-version: '20.x'
5050
- name: Cache node modules
5151
id: node-cache
5252
uses: actions/cache@v4

.github/workflows/redocly.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ jobs:
1414
- name: checkout
1515
uses: actions/checkout@v4
1616
- name: Install Node.js
17-
uses: actions/setup-node@v3
17+
uses: actions/setup-node@v4
1818
with:
19-
node-version: 16
19+
node-version: '20.x'
2020
- name: Setup go-swagger
2121
uses: minchao/setup-go-swagger@v1
2222
with:

Makefile

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -283,15 +283,18 @@ ui-server: ui-meshery-build ui-provider-build server
283283
UI_BUILD_SCRIPT = build16
284284
UI_DEV_SCRIPT = dev16
285285

286-
ifeq ($(findstring v19, $(shell node --version)), v19)
287-
UI_BUILD_SCRIPT = build
288-
UI_DEV_SCRIPT = dev
286+
ifeq ($(findstring v20, $(shell node --version)), v20)
287+
UI_BUILD_SCRIPT = build
288+
UI_DEV_SCRIPT = dev
289+
else ifeq ($(findstring v19, $(shell node --version)), v19)
290+
UI_BUILD_SCRIPT = build
291+
UI_DEV_SCRIPT = dev
289292
else ifeq ($(findstring v18, $(shell node --version)), v18)
290-
UI_BUILD_SCRIPT = build
291-
UI_DEV_SCRIPT = dev
293+
UI_BUILD_SCRIPT = build
294+
UI_DEV_SCRIPT = dev
292295
else ifeq ($(findstring v17, $(shell node --version)), v17)
293-
UI_BUILD_SCRIPT = build
294-
UI_DEV_SCRIPT = dev
296+
UI_BUILD_SCRIPT = build
297+
UI_DEV_SCRIPT = dev
295298
endif
296299

297300
## Install dependencies for building Meshery UI.

0 commit comments

Comments
 (0)