Fix OAuth2 credentials for installed app flow

Author: michael-lazar

rtv/oauth.py

@@ -127,9 +127,15 @@ def __init__(self, reddit, term, config):
         # unless we know that the server needs to be used.
         self.server = None
 
+        # Reddit changed their behavior at some point, and the "Installed App"
+        # flow now expects an empty client secret instead of a dummy string.
+        client_secret = self.config['oauth_client_secret']
+        if client_secret == "praw_gapfill":
+            client_secret = ""
+
         self.reddit.set_oauth_app_info(
             self.config['oauth_client_id'],
-            self.config['oauth_client_secret'],
+            client_secret,
             self.config['oauth_redirect_uri'])
 
         # Reddit's mobile website works better on terminal browsers

rtv/templates/rtv.cfg

@@ -70,7 +70,7 @@ force_new_browser_window = False
 ; These settings are defined at https://www.reddit.com/prefs/apps and should
 ; not be altered unless you are defining your own developer application.
 oauth_client_id = E2oEtRQfdfAfNQ
-oauth_client_secret = praw_gapfill
+oauth_client_secret =
 oauth_redirect_uri = http://127.0.0.1:65000/
 
 ; Port that the rtv webserver will listen on. This should match the redirect