fix: resolve settings revert, infinite reactive loops, and double-unmount in 4.9.0 (#685)

- Convert plugin.settings to getter/setter so TS mutations route through
     the Svelte 5 proxy, fixing view settings reverting on reload
   - Wrap proxy writes in untrack() in Matrix, TreeView, and TrailView
     effects to break effect_update_depth_exceeded infinite loops
   - Wrap $effect.pre proxy reads in untrack() so they only re-run on
     plugin prop changes, not on every settings write-back
   - Debounce REDRAW_SIDE_VIEWS handler (100ms) in Matrix and Tree views
     to prevent double-unmount and redundant remounts during load
   - Serialize codeblock fatal errors as readable plain-text log lines
   - Bump version to 4.9.1 and document fixes in CHANGELOG

Author: michaelpporter

CHANGELOG.md

@@ -4,6 +4,17 @@ All notable changes to this project will be documented in this file. See [standa
 
 ## 4.X
 
+### [4.9.1](https://github.com/SkepticMystic/breadcrumbs/compare/4.9.0...4.9.1) (2026-05-11)
+
+### Bug Fixes
+
+* Fix view settings (trail enabled, prev/next enabled, matrix collapse) reverting on reload — settings written by TypeScript callbacks were lost because the Svelte 5 reactive proxy did not propagate plain-object mutations back to its internal signal sources. Converted `plugin.settings` to a getter/setter so all writes route through the proxy.
+* Fix infinite reactive loop (`effect_update_depth_exceeded`) triggered when toggling trail or side view settings — `$effect` bodies in Matrix, TreeView, and TrailView were writing back to `plugin.settings` without `untrack()`, causing the proxy signal sources to re-trigger the same effects endlessly. Wrapped all proxy writes in `untrack()`.
+* Fix `$effect.pre` in Matrix, TreeView, and TrailView re-running on every proxy write — the effects tracked proxy signal sources when reading `plugin.settings.views.*` to initialise local settings state, creating a feedback loop with the write-back `$effect`. Wrapped the snapshot call in `untrack()` so `$effect.pre` only re-runs when the `plugin` prop itself changes.
+* Fix `lifecycle_double_unmount` error — concurrent `REDRAW_SIDE_VIEWS` events caused multiple `onOpen()` calls to race; both saw the same live component and both tried to unmount it. Debounced the event-driven `onOpen()` calls (100 ms trailing) so burst events collapse to a single remount.
+* Fix Matrix and Tree side views remounting on every graph update or active-leaf change — debounced `REDRAW_SIDE_VIEWS` handler collapses rapid-fire workspace events into one remount per burst.
+* Fix codeblock fatal-error log entries showing unexpandable `{…}` objects in the Obsidian developer console — errors are now logged as a formatted plain-text string with one line per error.
+
 ### [4.8.2](https://github.com/SkepticMystic/breadcrumbs/compare/4.8.1...4.8.2) (2026-05-03)
 
 ### Bug Fixes

manifest-beta.json

@@ -1,7 +1,7 @@
 {
 	"id": "breadcrumbs",
 	"name": "Breadcrumbs",
-	"version": "4.9.0",
+	"version": "4.9.1",
 	"minAppVersion": "1.12.0",
 	"description": "Add structured hierarchies to your notes",
 	"author": "SkepticMystic",

manifest.json

@@ -1,7 +1,7 @@
 {
 	"id": "breadcrumbs",
 	"name": "Breadcrumbs",
-	"version": "4.9.0",
+	"version": "4.9.1",
 	"minAppVersion": "1.12.0",
 	"description": "Add structured hierarchies to your notes",
 	"author": "SkepticMystic",

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "breadcrumbs",
-	"version": "4.9.0",
+	"version": "4.9.1",
 	"description": "Add typed-links to your Obsidian notes",
 	"main": "main.js",
 	"scripts": {

src/codeblocks/MDRC.ts

@@ -68,7 +68,10 @@ export class CodeblockMDRC extends MarkdownRenderChild {
 		log.debug(timer_inner.elapsedMessage("Codeblocks.parse_source", true));
 
 		if (!parsed) {
-			log.warn("fatal codeblock errors", errors);
+			log.warn(
+				"fatal codeblock errors\n" +
+				errors.map((e) => `  [${e.code}] ${e.path}: ${e.message}`).join("\n"),
+			);
 
 			mount(CodeblockErrors, {
 				target: this.containerEl,

src/components/page_views/TrailView.svelte

@@ -32,7 +32,7 @@
 		if (last_plugin !== plugin) {
 			last_plugin = plugin;
 			settings = json_clone(
-				$state.snapshot(plugin.settings.views.page.trail),
+				untrack(() => $state.snapshot(plugin.settings.views.page.trail)),
 			);
 		}
 	});
@@ -44,9 +44,10 @@
 	let is_initial_mount = true;
 
 	$effect(() => {
-		// Keep `plugin.settings.views.page.trail` aligned with the local `settings`
-		// clone (same pattern as Matrix). Skip persisting on the first run only.
-		plugin.settings.views.page.trail = $state.snapshot(settings);
+		const trail_snapshot = $state.snapshot(settings);
+		untrack(() => {
+			plugin.settings.views.page.trail = trail_snapshot;
+		});
 		if (is_initial_mount) {
 			is_initial_mount = false;
 		} else {

src/components/side_views/Matrix.svelte

@@ -34,19 +34,19 @@
 		if (last_plugin !== plugin) {
 			last_plugin = plugin;
 			settings = json_clone(
-				$state.snapshot(plugin.settings.views.side.matrix),
+				untrack(() => $state.snapshot(plugin.settings.views.side.matrix)),
 			);
 		}
 	});
 
 	let is_initial_mount = true;
 
 	$effect(() => {
-		plugin.settings.views.side.matrix = $state.snapshot(settings);
-		untrack(() => void plugin.saveSettings());
-		// We only want to run this when *we* have changed `settings`,
-		// and not when the component is initially mounted into the DOM,
-		// or when the settings have been updated externally.
+		const matrix_snapshot = $state.snapshot(settings);
+		untrack(() => {
+			plugin.settings.views.side.matrix = matrix_snapshot;
+			void plugin.saveSettings();
+		});
 		if (is_initial_mount) {
 			is_initial_mount = false;
 			return;

src/components/side_views/TreeView.svelte

@@ -65,14 +65,17 @@
 		if (last_plugin !== plugin) {
 			last_plugin = plugin;
 			settings = json_clone(
-				$state.snapshot(plugin.settings.views.side.tree),
+				untrack(() => $state.snapshot(plugin.settings.views.side.tree)),
 			);
 		}
 	});
 
 	$effect(() => {
-		plugin.settings.views.side.tree = $state.snapshot(settings);
-		untrack(() => void plugin.saveSettings());
+		const tree_snapshot = $state.snapshot(settings);
+		untrack(() => {
+			plugin.settings.views.side.tree = tree_snapshot;
+			void plugin.saveSettings();
+		});
 	});
 
 	let edge_field_labels = $derived(

src/main.ts

@@ -43,7 +43,12 @@ export enum BCEvent {
 }
 
 export default class BreadcrumbsPlugin extends Plugin {
-	settings!: BreadcrumbsSettings;
+	get settings(): BreadcrumbsSettings {
+		return reactive_settings.current;
+	}
+	set settings(value: BreadcrumbsSettings) {
+		reactive_settings.init(value);
+	}
 	graph!: NoteGraph;
 	api!: BCAPI;
 	events!: Events;
@@ -305,8 +310,6 @@ export default class BreadcrumbsPlugin extends Plugin {
 			((await this.loadData()) ?? {}) as BreadcrumbsSettings,
 			DEFAULT_SETTINGS,
 		);
-
-		reactive_settings.init(this.settings);
 	}
 
 	private handleFileMenu(menu: Menu, file: TAbstractFile): void {
@@ -321,9 +324,7 @@ export default class BreadcrumbsPlugin extends Plugin {
 
 	async saveSettings() {
 		reactive_settings.current.is_dirty = false;
-		this.settings = reactive_settings.snapshot();
-
-		await this.saveData(this.settings);
+		await this.saveData(reactive_settings.snapshot());
 	}
 
 	async backup_old_settings(): Promise<void> {

src/views/matrix.ts

@@ -1,5 +1,5 @@
 import type { WorkspaceLeaf } from "obsidian";
-import { ItemView } from "obsidian";
+import { debounce, ItemView } from "obsidian";
 import MatrixComponent from "src/components/side_views/Matrix.svelte";
 import { VIEW_IDS } from "src/const/views";
 import type BreadcrumbsPlugin from "src/main";
@@ -8,7 +8,7 @@ import { mount, unmount } from "svelte";
 
 export class MatrixView extends ItemView {
 	plugin: BreadcrumbsPlugin;
-	component!: ReturnType<typeof MatrixComponent>;
+	component: ReturnType<typeof MatrixComponent> | undefined;
 
 	constructor(leaf: WorkspaceLeaf, plugin: BreadcrumbsPlugin) {
 		super(leaf);
@@ -26,10 +26,9 @@ export class MatrixView extends ItemView {
 	icon = "blinds";
 
 	onload(): void {
+		const redraw = debounce(() => void this.onOpen(), 100);
 		this.registerEvent(
-			this.plugin.events.on(BCEvent.REDRAW_SIDE_VIEWS, () => {
-				void this.onOpen();
-			}),
+			this.plugin.events.on(BCEvent.REDRAW_SIDE_VIEWS, redraw),
 		);
 	}
 
@@ -45,7 +44,9 @@ export class MatrixView extends ItemView {
 
 	async onClose() {
 		if (this.component) {
-			await unmount(this.component);
+			const old = this.component;
+			this.component = undefined;
+			await unmount(old);
 		}
 	}
 }