Skip to content

Fix guard conditions#209

Merged
pablogs9 merged 3 commits intomainfrom
fix/guard_conditions
Nov 29, 2021
Merged

Fix guard conditions#209
pablogs9 merged 3 commits intomainfrom
fix/guard_conditions

Conversation

@pablogs9
Copy link
Copy Markdown
Member

Signed-off-by: Pablo Garrido pablogs9@gmail.com

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
@github-actions
Copy link
Copy Markdown

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 272 B
Publisher 4 288 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34468 B

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 29, 2021

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49.19%. Comparing base (e58676c) to head (4640e81).

Files with missing lines Patch % Lines
rmw_microxrcedds_c/src/rmw_wait.c 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   47.80%   49.19%   +1.39%     
==========================================
  Files          42       42              
  Lines        1686     1687       +1     
  Branches      332      332              
==========================================
+ Hits          806      830      +24     
+ Misses        670      644      -26     
- Partials      210      213       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
@pablogs9
Copy link
Copy Markdown
Member Author

@mergify backport foxy galactic

@github-actions
Copy link
Copy Markdown

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 272 B
Publisher 4 288 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34468 B

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 29, 2021

backport foxy galactic

🟠 Waiting for conditions to match

Details
  • merged [:pushpin: backport requirement]

Hey, I reacted but my real name is @Mergifyio

Comment thread rmw_microxrcedds_c/src/rmw_wait.c
@pablogs9 pablogs9 requested a review from Acuadros95 November 29, 2021 08:55
@pablogs9 pablogs9 merged commit 7bffd49 into main Nov 29, 2021
@pablogs9 pablogs9 deleted the fix/guard_conditions branch November 29, 2021 09:16
mergify bot pushed a commit that referenced this pull request Nov 29, 2021
* Fix guard conditions

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Add regression test

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Minor fixes

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
(cherry picked from commit 7bffd49)
mergify bot pushed a commit that referenced this pull request Nov 29, 2021
* Fix guard conditions

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Add regression test

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Minor fixes

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
(cherry picked from commit 7bffd49)
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 29, 2021

backport foxy galactic

✅ Backports have been created

Details

pablogs9 added a commit that referenced this pull request Nov 29, 2021
* Fix guard conditions

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Add regression test

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Minor fixes

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
(cherry picked from commit 7bffd49)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
pablogs9 added a commit that referenced this pull request Nov 29, 2021
* Fix guard conditions

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Add regression test

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>

* Minor fixes

Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
(cherry picked from commit 7bffd49)

Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants