Skip to content

Execution Tests: Long Vectors fix-up HLK feature reference.#8353

Open
alsepkow wants to merge 3 commits intomicrosoft:mainfrom
alsepkow:user/alsepkow/fixHLKFeature
Open

Execution Tests: Long Vectors fix-up HLK feature reference.#8353
alsepkow wants to merge 3 commits intomicrosoft:mainfrom
alsepkow:user/alsepkow/fixHLKFeature

Conversation

@alsepkow
Copy link
Copy Markdown
Contributor

@alsepkow alsepkow commented Apr 8, 2026

The TAEF metadata for referencing the HLK feature name was not conformant.
Manually verified by importing the updated test binary and requirement files to a custom HLK server setup to verify end-to-end.

Resolves the DXC side work for #7611

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff ec6ba97b757633c2e680d307342716527645930c 7600fbee39ef24cdd80717eb07898398b77812b4 -- tools/clang/unittests/HLSLExec/LongVectors.cpp
View the diff from clang-format here.
diff --git a/tools/clang/unittests/HLSLExec/LongVectors.cpp b/tools/clang/unittests/HLSLExec/LongVectors.cpp
index 22872c40..51e4f412 100644
--- a/tools/clang/unittests/HLSLExec/LongVectors.cpp
+++ b/tools/clang/unittests/HLSLExec/LongVectors.cpp
@@ -2996,9 +2996,9 @@ public:
 #define HLK_TEST_DOUBLE(Op, DataType)                                          \
   TEST_METHOD(Op##_##DataType) {                                               \
     BEGIN_TEST_METHOD_PROPERTIES()                                             \
-    TEST_METHOD_PROPERTY(                                                      \
-        "Kits.Specification",                                                  \
-        "Device.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecision.Optional")                                                             \
+    TEST_METHOD_PROPERTY("Kits.Specification",                                 \
+                         "Device.Graphics.D3D12.DXILCore.ShaderModel69."       \
+                         "DoublePrecision.Optional")                           \
     END_TEST_METHOD_PROPERTIES()                                               \
     runTest<DataType, OpType::Op>();                                           \
   }
@@ -3006,9 +3006,9 @@ public:
 #define HLK_WAVEOP_TEST_DOUBLE(Op, DataType)                                   \
   TEST_METHOD(Op##_##DataType) {                                               \
     BEGIN_TEST_METHOD_PROPERTIES()                                             \
-    TEST_METHOD_PROPERTY(                                                      \
-        "Kits.Specification",                                                  \
-        "Device.Graphics.D3D12.DXILCore.ShaderModel69.DoublePrecision.Optional")                                                             \
+    TEST_METHOD_PROPERTY("Kits.Specification",                                 \
+                         "Device.Graphics.D3D12.DXILCore.ShaderModel69."       \
+                         "DoublePrecision.Optional")                           \
     END_TEST_METHOD_PROPERTIES()                                               \
     runWaveOpTest<DataType, OpType::Op>();                                     \
   }
  • Check this box to apply formatting changes to this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

2 participants