copilot suggested changes

Author: Rafi-Microsoft

.github/workflows/deploy-linux.yml

@@ -6,7 +6,7 @@ on:
       - dev
       - demo
   schedule:
-    - cron: "0 10,22 * * *" # Runs at 10:00 AM and 10:00 PM GMT
+    - cron: "0 10,22 * * *" # Runs at 10:00 AM and 10:00 PM UTC
 
   workflow_dispatch:
     inputs:
@@ -74,9 +74,9 @@ jobs:
     with:
       azure_location: ${{ github.event.inputs.azure_location || 'australiaeast' }}
       resource_group_name: ${{ github.event.inputs.resource_group_name || '' }}
-      waf_enabled: ${{ github.event.inputs.waf_enabled == 'true' }}
-      EXP: ${{ github.event.inputs.EXP == 'true' }}
-      cleanup_resources: ${{ github.event.inputs.cleanup_resources == 'true' }}
+      waf_enabled: ${{ github.event.inputs.waf_enabled }}
+      EXP: ${{ github.event.inputs.EXP }}
+      cleanup_resources: ${{ github.event.inputs.cleanup_resources }}
       run_e2e_tests: ${{ github.event.inputs.run_e2e_tests || 'GoldenPath-Testing' }}
       AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID: ${{ github.event.inputs.AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID || '' }}
       existing_webapp_url: ${{ github.event.inputs.existing_webapp_url || '' }}

.github/workflows/deploy-orchestrator.yml

@@ -68,7 +68,7 @@ jobs:
     secrets: inherit
 
   e2e-test:
-    if: "!cancelled() && ((needs.deploy.result == 'success' && needs.deploy.outputs.WEB_APPURL != '') || (inputs.existing_webapp_url != '' && inputs.existing_webapp_url != null)) && (inputs.trigger_type != 'workflow_dispatch' || (inputs.run_e2e_tests != 'None' && inputs.run_e2e_tests != '' && inputs.run_e2e_tests != null))"
+    if: "!cancelled() && ((needs.deploy.outputs.WEB_APPURL != '' && needs.deploy.outputs.WEB_APPURL != null) || (inputs.existing_webapp_url != '' && inputs.existing_webapp_url != null)) && (inputs.trigger_type != 'workflow_dispatch' || (inputs.run_e2e_tests != 'None' && inputs.run_e2e_tests != '' && inputs.run_e2e_tests != null))"
     needs: [deploy]
     uses: ./.github/workflows/test-automation-v2.yml
     with:

.github/workflows/job-cleanup-deployment.yml

@@ -82,7 +82,6 @@ jobs:
         if: always()
         shell: bash
         run: |
-          azd auth logout || true
           az logout || echo "Warning: Failed to logout from Azure CLI"
           echo "Logged out from Azure."
       

.github/workflows/job-deploy-linux.yml

@@ -76,8 +76,8 @@ jobs:
           fi
 
           # Ensure prerequisites are present
-            sudo apt-get update
-            sudo apt-get install -y apt-transport-https ca-certificates curl gnupg lsb-release
+          sudo apt-get update
+          sudo apt-get install -y apt-transport-https ca-certificates curl gnupg lsb-release
 
           # Ensure keyrings dir exists
           sudo mkdir -p /usr/share/keyrings

.github/workflows/job-deploy.yml

@@ -172,6 +172,10 @@ jobs:
         id: set_region
         shell: bash
         run: |
+          if [[ -z "$VALID_REGION" ]]; then
+            echo "❌ ERROR: VALID_REGION is not set. The quota check script (Deployment/checkquota.ps1) must set this variable before this step runs." >&2
+            exit 1
+          fi
           echo "Selected Region from Quota Check: $VALID_REGION"
           echo "AZURE_ENV_OPENAI_LOCATION=$VALID_REGION" >> $GITHUB_ENV
           echo "AZURE_ENV_OPENAI_LOCATION=$VALID_REGION" >> $GITHUB_OUTPUT
@@ -225,18 +229,6 @@ jobs:
           echo "RESOURCE_GROUP_NAME=$RESOURCE_GROUP_NAME" >> $GITHUB_OUTPUT
           echo "RESOURCE_GROUP_NAME=$RESOURCE_GROUP_NAME" >> $GITHUB_ENV
 
-      - name: Generate Unique Solution Prefix
-        id: generate_solution_prefix
-        shell: bash
-        run: |
-          set -e
-          COMMON_PART="psldg"
-          TIMESTAMP=$(date +%s)  
-          UPDATED_TIMESTAMP=$(echo $TIMESTAMP | tail -c 6) 
-          UNIQUE_SOLUTION_PREFIX="${COMMON_PART}${UPDATED_TIMESTAMP}"
-          echo "SOLUTION_PREFIX=${UNIQUE_SOLUTION_PREFIX}" >> $GITHUB_ENV
-          echo "Generated SOLUTION_PREFIX: ${UNIQUE_SOLUTION_PREFIX}" 
-
       - name: Determine Docker Image Tag
         id: determine_image_tag
         run: |

.github/workflows/test-automation-v2.yml

@@ -63,6 +63,14 @@ jobs:
             echo "ERROR: No URL provided for testing"
             exit 1
           fi
+          
+          # Validate test suite is implemented
+          if [ "${{ env.test_suite }}" == "Smoke-Testing" ]; then
+            echo "ERROR: Smoke-Testing is not yet implemented"
+            echo "Available test suites: GoldenPath-Testing"
+            exit 1
+          fi
+          
           echo "Testing URL: ${{ env.url }}"
           echo "Test Suite: ${{ env.test_suite }}"