Skip to content

Commit ef723be

Browse files
removed comments
1 parent a1b93f9 commit ef723be

2 files changed

Lines changed: 3 additions & 17 deletions

File tree

.github/workflows/job-deploy-linux.yml

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -339,8 +339,6 @@ jobs:
339339
env:
340340
# From GitHub secrets
341341
AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
342-
# Needed so the script can refresh the OIDC federated token mid-run
343-
# (avoids AADSTS700024 'client assertion expired' before `az acr login`).
344342
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
345343
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
346344

@@ -400,10 +398,7 @@ jobs:
400398
webapp_url="${{ steps.get_webapp_url.outputs.WEB_APPURL }}"
401399
echo "Validating web app at: $webapp_url"
402400
403-
# Wait for AKS workloads to become Available before probing the public endpoint.
404-
# First-time pod startup (large container images + cert-manager Let's Encrypt
405-
# issuance + ingress wiring) commonly takes 5-10 minutes, which previously
406-
# caused the curl health check to give up while pods were still Pending.
401+
# Wait for AKS workloads to become Available
407402
if [ -n "$AZURE_AKS_NAME" ] && [ -n "$RESOURCE_GROUP_NAME" ]; then
408403
echo "Fetching AKS kubeconfig for $AZURE_AKS_NAME..."
409404
az aks get-credentials \
@@ -427,9 +422,7 @@ jobs:
427422
fi
428423
fi
429424
430-
# HTTP health check with retry logic.
431-
# ~10 minutes of additional headroom on top of the pod-readiness wait above
432-
# to cover ingress propagation and TLS cert issuance.
425+
# HTTP health check with retry logic
433426
max_attempts=20
434427
attempt=1
435428
success=false
@@ -459,9 +452,6 @@ jobs:
459452
exit 1
460453
fi
461454
462-
# Post-success strict-TLS probe: warn (but do not fail) if the Let's Encrypt
463-
# cert hasn't propagated or is invalid. Keeps existing pass/fail behavior
464-
# while surfacing TLS issues that the -k loop above intentionally tolerates.
465455
tls_code=$(curl -sS -o /dev/null -w "%{http_code}" "$webapp_url" 2>/tmp/tls_err.log || echo "000")
466456
if [ "$tls_code" -eq 200 ]; then
467457
echo "✅ Public endpoint also validates with strict TLS (HTTP $tls_code)."

Deployment/resourcedeployment.ps1

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1001,11 +1001,7 @@ try {
10011001
# $acrKernelMemoryTag = "$($deploymentResult.AzContainerRegistryName).azurecr.io/$acrNamespace/kernelmemory"
10021002
# $acrFrontAppTag = "$($deploymentResult.AzContainerRegistryName).azurecr.io/$acrNamespace/frontapp"
10031003

1004-
# 1. Refresh Azure CLI auth using a fresh GitHub OIDC token before ACR login.
1005-
# The federated client assertion issued by azure/login@v2 has only ~5 min
1006-
# validity and AKS provisioning above can take much longer, which causes
1007-
# `az acr login` to fail with AADSTS700024 (assertion expired) and then
1008-
# docker push returns 401 unauthorized. Re-mint a fresh token here.
1004+
# 1. Refresh Azure CLI auth using a fresh GitHub OIDC token before ACR login
10091005
if ($env:ACTIONS_ID_TOKEN_REQUEST_URL -and $env:ACTIONS_ID_TOKEN_REQUEST_TOKEN `
10101006
-and $env:AZURE_CLIENT_ID -and $env:AZURE_TENANT_ID) {
10111007
Write-Host "Refreshing Azure CLI federated credentials before ACR login..." -ForegroundColor Yellow

0 commit comments

Comments
 (0)